All of lore.kernel.org
 help / color / mirror / Atom feed
From: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH] arch/Config.in.xtensa: provide BR2_ENDIAN symbol
Date: Tue, 5 May 2015 17:45:00 +0200	[thread overview]
Message-ID: <20150505174500.24a31bcf@free-electrons.com> (raw)
In-Reply-To: <1430840532-2115-1-git-send-email-jcmvbkbc@gmail.com>

Dear Max Filippov,

On Tue,  5 May 2015 18:42:12 +0300, Max Filippov wrote:
> Signed-off-by: Max Filippov <jcmvbkbc@gmail.com>
> ---
>  arch/Config.in.xtensa | 14 ++++++++++++++
>  1 file changed, 14 insertions(+)

Thanks for coming up so quickly with a patch for this!

I think it's important to mention that this is fixing an autobuilder
failure, and put the pointer to the corresponding failure.

> +choice
> +	prompt "Target Architecture Endianness"
> +	depends on BR2_XTENSA_CUSTOM
> +	default BR2_XTENSA_LITTLE_ENDIAN
> +config BR2_XTENSA_LITTLE_ENDIAN
> +	bool "Little endian"
> +config BR2_XTENSA_BIG_ENDIAN
> +	bool "Big endian"
> +endchoice

A little bit of spacing between options would be good I believe.

Other than that, looks good to me.

Thanks,

Thomas
-- 
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com

      reply	other threads:[~2015-05-05 15:45 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-05-05 15:42 [Buildroot] [PATCH] arch/Config.in.xtensa: provide BR2_ENDIAN symbol Max Filippov
2015-05-05 15:45 ` Thomas Petazzoni [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20150505174500.24a31bcf@free-electrons.com \
    --to=thomas.petazzoni@free-electrons.com \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.