From mboxrd@z Thu Jan 1 00:00:00 1970 From: Alexandre Belloni Subject: Re: [rtc-linux] [PATCH v3 2/3] rtc: mediatek: Add MT6397 RTC driver Date: Tue, 5 May 2015 22:00:10 +0200 Message-ID: <20150505200010.GP4276@piout.net> References: <1430206556-18254-1-git-send-email-eddie.huang@mediatek.com> <1430206556-18254-3-git-send-email-eddie.huang@mediatek.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: <1430206556-18254-3-git-send-email-eddie.huang@mediatek.com> Sender: linux-kernel-owner@vger.kernel.org To: Eddie Huang Cc: Lee Jones , Alessandro Zummo , Matthias Brugger , Andrew Morton , Tomasz Figa , Uwe =?iso-8859-1?Q?Kleine-K=F6nig?= , srv_heupstream@mediatek.com, Samuel Ortiz , Greg KH , Joe Perches , linux-kernel@vger.kernel.org, rtc-linux@googlegroups.com, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org, Tianping Fang List-Id: linux-mediatek@lists.infradead.org Hi, This looks mostly good. Could you align the wrapped function parameters to the open parenthesis (use checkpatch --strict)? On 28/04/2015 at 15:35:55 +0800, Eddie Huang wrote : > +static int mtk_rtc_write_trigger(struct mt6397_rtc *rtc) > +{ > + unsigned long timeout = jiffies + HZ; > + int ret; > + u32 data; > + > + ret = regmap_write(rtc->regmap, rtc->addr_base + RTC_WRTGR, 1); > + if (ret < 0) > + return ret; > + > + do { > + cpu_relax(); > + ret = regmap_read(rtc->regmap, rtc->addr_base + RTC_BBPU, > + &data); > + if (ret < 0) > + goto exit; > + } while ((data & RTC_BBPU_CBUSY) && time_after(timeout, jiffies)); > + Shouldn't you return -ETIMEDOUT if the loop breaks because of time_after? Thanks, -- Alexandre Belloni, Free Electrons Embedded Linux, Kernel and Android engineering http://free-electrons.com From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail.free-electrons.com (down.free-electrons.com. [37.187.137.238]) by gmr-mx.google.com with ESMTP id t6si162257wiz.0.2015.05.05.13.00.11 for ; Tue, 05 May 2015 13:00:11 -0700 (PDT) Date: Tue, 5 May 2015 22:00:10 +0200 From: Alexandre Belloni To: Eddie Huang Cc: Lee Jones , Alessandro Zummo , Matthias Brugger , Andrew Morton , Tomasz Figa , Uwe =?iso-8859-1?Q?Kleine-K=F6nig?= , srv_heupstream@mediatek.com, Samuel Ortiz , Greg KH , Joe Perches , linux-kernel@vger.kernel.org, rtc-linux@googlegroups.com, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org, Tianping Fang Subject: Re: [rtc-linux] [PATCH v3 2/3] rtc: mediatek: Add MT6397 RTC driver Message-ID: <20150505200010.GP4276@piout.net> References: <1430206556-18254-1-git-send-email-eddie.huang@mediatek.com> <1430206556-18254-3-git-send-email-eddie.huang@mediatek.com> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 In-Reply-To: <1430206556-18254-3-git-send-email-eddie.huang@mediatek.com> Reply-To: rtc-linux@googlegroups.com List-ID: List-Post: , List-Help: , List-Archive: , List-Unsubscribe: , Hi, This looks mostly good. Could you align the wrapped function parameters to the open parenthesis (use checkpatch --strict)? On 28/04/2015 at 15:35:55 +0800, Eddie Huang wrote : > +static int mtk_rtc_write_trigger(struct mt6397_rtc *rtc) > +{ > + unsigned long timeout = jiffies + HZ; > + int ret; > + u32 data; > + > + ret = regmap_write(rtc->regmap, rtc->addr_base + RTC_WRTGR, 1); > + if (ret < 0) > + return ret; > + > + do { > + cpu_relax(); > + ret = regmap_read(rtc->regmap, rtc->addr_base + RTC_BBPU, > + &data); > + if (ret < 0) > + goto exit; > + } while ((data & RTC_BBPU_CBUSY) && time_after(timeout, jiffies)); > + Shouldn't you return -ETIMEDOUT if the loop breaks because of time_after? Thanks, -- Alexandre Belloni, Free Electrons Embedded Linux, Kernel and Android engineering http://free-electrons.com -- -- You received this message because you are subscribed to "rtc-linux". Membership options at http://groups.google.com/group/rtc-linux . Please read http://groups.google.com/group/rtc-linux/web/checklist before submitting a driver. --- You received this message because you are subscribed to the Google Groups "rtc-linux" group. To unsubscribe from this group and stop receiving emails from it, send an email to rtc-linux+unsubscribe@googlegroups.com. For more options, visit https://groups.google.com/d/optout. From mboxrd@z Thu Jan 1 00:00:00 1970 From: alexandre.belloni@free-electrons.com (Alexandre Belloni) Date: Tue, 5 May 2015 22:00:10 +0200 Subject: [rtc-linux] [PATCH v3 2/3] rtc: mediatek: Add MT6397 RTC driver In-Reply-To: <1430206556-18254-3-git-send-email-eddie.huang@mediatek.com> References: <1430206556-18254-1-git-send-email-eddie.huang@mediatek.com> <1430206556-18254-3-git-send-email-eddie.huang@mediatek.com> Message-ID: <20150505200010.GP4276@piout.net> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org Hi, This looks mostly good. Could you align the wrapped function parameters to the open parenthesis (use checkpatch --strict)? On 28/04/2015 at 15:35:55 +0800, Eddie Huang wrote : > +static int mtk_rtc_write_trigger(struct mt6397_rtc *rtc) > +{ > + unsigned long timeout = jiffies + HZ; > + int ret; > + u32 data; > + > + ret = regmap_write(rtc->regmap, rtc->addr_base + RTC_WRTGR, 1); > + if (ret < 0) > + return ret; > + > + do { > + cpu_relax(); > + ret = regmap_read(rtc->regmap, rtc->addr_base + RTC_BBPU, > + &data); > + if (ret < 0) > + goto exit; > + } while ((data & RTC_BBPU_CBUSY) && time_after(timeout, jiffies)); > + Shouldn't you return -ETIMEDOUT if the loop breaks because of time_after? Thanks, -- Alexandre Belloni, Free Electrons Embedded Linux, Kernel and Android engineering http://free-electrons.com