Re: [PATCH] ASoC: Intel: Enabled button jack for BSW platform with rt5650 codec

[Mark Brown <broonie@kernel.org>]

[-- Attachment #1.1: Type: text/plain, Size: 1035 bytes --]

On Tue, May 05, 2015 at 03:42:52PM -0700, Dylan Reid wrote:
> On Tue, May 5, 2015 at 3:39 PM, Fang, Yang A <yang.a.fang@intel.com> wrote:

> >> It's fine to do that in the CODEC driver and actually good for the headphone
> >> and microphone - the board can always pass in the same jack for all of them
> >> but if it does have split headphone and mic jacks then it can do that.

> > Thanks. I will post v2 after Bard modifies the api

> If I'm interpreting Mark's comment correctly, he is suggesting that
> the API remain the same and have cht_bsw_rt5645.c pass the same jack
> to all three parameters.  I like this idea, as unlike the 227e driver
> the 5650 could be used with separate hp and mic jacks. I'd imagine
> there wouldn't be a button jack in that case since that is headset
> specific, but that shouldn't matter.

Yes, that's what I meant - I had originally interpreted the ability to
specify the buttons separately as the ability to turn button detection
on or off from the machine driver, either the same as mic or null.

[-- Attachment #1.2: Digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]

[-- Attachment #2: Type: text/plain, Size: 0 bytes --]