From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Edgar E. Iglesias" Subject: Re: [PATCH v4 2/3] xen/arm: Add p2m_ipa_bits Date: Wed, 6 May 2015 14:28:38 +1000 Message-ID: <20150506042838.GU10142@toto> References: <1430444419-11564-1-git-send-email-edgar.iglesias@gmail.com> <1430444419-11564-3-git-send-email-edgar.iglesias@gmail.com> <1430832203.2660.93.camel@citrix.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Content-Disposition: inline In-Reply-To: <1430832203.2660.93.camel@citrix.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Ian Campbell Cc: julien.grall@citrix.com, tim@xen.org, edgar.iglesias@xilinx.com, stefano.stabellini@citrix.com, xen-devel@lists.xen.org List-Id: xen-devel@lists.xenproject.org On Tue, May 05, 2015 at 02:23:23PM +0100, Ian Campbell wrote: > On Fri, 2015-05-01 at 11:40 +1000, Edgar E. Iglesias wrote: > > From: "Edgar E. Iglesias" > > > > Export p2m_ipa_bits holding the bit size of IPAs used in p2m tables. > > > > Signed-off-by: Edgar E. Iglesias > > --- > > xen/arch/arm/p2m.c | 5 +++++ > > xen/include/asm-arm/p2m.h | 3 +++ > > 2 files changed, 8 insertions(+) > > > > diff --git a/xen/arch/arm/p2m.c b/xen/arch/arm/p2m.c > > index 8dfee24..c6507ae 100644 > > --- a/xen/arch/arm/p2m.c > > +++ b/xen/arch/arm/p2m.c > > @@ -27,6 +27,9 @@ static unsigned int __read_mostly p2m_root_level; > > > > #define P2M_ROOT_PAGES (1< > > > +/* Size of IPAs in bits. */ > > +unsigned int p2m_ipa_bits; > > I think this should be __read_mostly. > > I'm also wondering about suggesting to put it in the existing #ifdef > with P2M_ROOT_LEVEL etc and have it be: > const unsigned int __read_mostly = 40 > on 32-bit and only vary on 64-bit. > Sounds good, I've changed it accordingly for v5. Thanks, Edgar