From: Christoph Hellwig <hch@infradead.org>
To: Linus Torvalds <torvalds@linux-foundation.org>
Cc: Herbert Xu <herbert@gondor.apana.org.au>,
Jens Axboe <axboe@kernel.dk>,
Christophe Leroy <christophe.leroy@c-s.fr>,
Al Viro <viro@zeniv.linux.org.uk>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
linux-fsdevel <linux-fsdevel@vger.kernel.org>,
Linux Crypto Mailing List <linux-crypto@vger.kernel.org>
Subject: Re: [PATCH v2] splice: sendfile() at once fails for big files
Date: Tue, 5 May 2015 21:34:51 -0700 [thread overview]
Message-ID: <20150506043451.GA9130@infradead.org> (raw)
In-Reply-To: <CA+55aFyc+A25ozSTVNNHmBL_kUhv9u5kUq9esxjYggmqfPRE9w@mail.gmail.com>
On Tue, May 05, 2015 at 08:41:05PM -0700, Linus Torvalds wrote:
> Jens, ping?
>
> The test results should make this a no-brainer, but I hate how random
> these flag ops.
Not Jens here, but:
(a) the patch looks correct, we do want to set the more flag if there
is more data
(b) I think the AF_ALG model is totally broken if it relies on that
for data integrity purposes.
next prev parent reply other threads:[~2015-05-06 4:34 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-04-23 15:03 [PATCH v2] splice: sendfile() at once fails for big files Christophe Leroy
2015-04-27 7:01 ` Herbert Xu
2015-05-06 3:41 ` Linus Torvalds
2015-05-06 4:34 ` Christoph Hellwig [this message]
2015-05-06 14:23 ` Jens Axboe
2015-05-06 14:38 ` leroy christophe
2015-05-06 14:40 ` Jens Axboe
2015-05-06 14:40 ` Jens Axboe
2015-05-06 15:07 ` Jens Axboe
2015-05-06 15:07 ` Jens Axboe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150506043451.GA9130@infradead.org \
--to=hch@infradead.org \
--cc=axboe@kernel.dk \
--cc=christophe.leroy@c-s.fr \
--cc=herbert@gondor.apana.org.au \
--cc=linux-crypto@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=torvalds@linux-foundation.org \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.