Re: [Qemu-devel] [RFC PATCH v3 21/24] spapr: Initialize hotplug memory address space

[Bharata B Rao <bharata@linux.vnet.ibm.com>]

On Tue, May 05, 2015 at 05:33:33PM +1000, David Gibson wrote:
> On Fri, Apr 24, 2015 at 12:17:43PM +0530, Bharata B Rao wrote:
> > Initialize a hotplug memory region under which all the hotplugged
> > memory is accommodated. Also enable memory hotplug by setting
> > CONFIG_MEM_HOTPLUG.
> > 
> > Modelled on i386 memory hotplug.
> > 
> > Signed-off-by: Bharata B Rao <bharata@linux.vnet.ibm.com>
> 
> So, the cpu hotplug stuff has been caught up in these generic level
> design discussions.  Could you split out the memory hotplug part of
> this series so that we might be able to move forwards with that while
> the cpu hotplug discussion continues?

Yes, in fact I too was planning to split memory and push it separately.

> 
> > ---
> >  default-configs/ppc64-softmmu.mak |  1 +
> >  hw/ppc/spapr.c                    | 38 ++++++++++++++++++++++++++++++++++++++
> >  include/hw/ppc/spapr.h            | 12 ++++++++++++
> >  3 files changed, 51 insertions(+)
> > 
> > diff --git a/default-configs/ppc64-softmmu.mak b/default-configs/ppc64-softmmu.mak
> > index 22ef132..16b3011 100644
> > --- a/default-configs/ppc64-softmmu.mak
> > +++ b/default-configs/ppc64-softmmu.mak
> > @@ -51,3 +51,4 @@ CONFIG_XICS_KVM=$(and $(CONFIG_PSERIES),$(CONFIG_KVM))
> >  # For PReP
> >  CONFIG_MC146818RTC=y
> >  CONFIG_ISA_TESTDEV=y
> > +CONFIG_MEM_HOTPLUG=y
> > diff --git a/hw/ppc/spapr.c b/hw/ppc/spapr.c
> > index 910a50f..9dc4c36 100644
> > --- a/hw/ppc/spapr.c
> > +++ b/hw/ppc/spapr.c
> > @@ -125,6 +125,9 @@ struct sPAPRMachineState {
> >  
> >      /*< public >*/
> >      char *kvm_type;
> > +    ram_addr_t hotplug_memory_base;
> > +    MemoryRegion hotplug_memory;
> > +    bool enforce_aligned_dimm;
> 
> As mentioned on the earlier version, on ppc we don't have
> compatibility reasons we need to have a mode for unaligned dimms.  Get
> rid of this bool and treat it as always on instead.

ok.

Regards,
Bharata.