From: Daniel Vetter <daniel@ffwll.ch>
To: Jani Nikula <jani.nikula@linux.intel.com>
Cc: intel-gfx@lists.freedesktop.org
Subject: Re: [PATCH] drm/i915/bxt: BLC implementation
Date: Wed, 6 May 2015 13:17:30 +0200 [thread overview]
Message-ID: <20150506111730.GA30184@phenom.ffwll.local> (raw)
In-Reply-To: <87sibb6yy4.fsf@intel.com>
On Tue, May 05, 2015 at 02:33:39PM +0300, Jani Nikula wrote:
> On Tue, 05 May 2015, Vandana Kannan <vandana.kannan@intel.com> wrote:
> > Enabling BLC on BXT.
> > Includes register definition, and new functions for BXT.
> >
> > In BXT, there are 2 sets of registers for BLC. Until there is clarity
> > about which set would be effective, set 1 is being used.
> > This would have to be re-visited if there is any change or when 2 LFPs are
> > enabled on BXT.
> >
> > This patch enables brightness change which would be effected by use of
> > hot-keys or sysfs entry.
> >
> > TODO:- BLC implementation will have to re-visited when
> > 1. there is clarity about which set of registers has to be used and when.
> > 2. CDCLK frequency is changed
> >
> > v2: Jani's review comments
> > - Modified comment in i915_reg.h
> > - Renamed register defintions
> > - Removed definition of duty cycle max. Not required now and its not 64-bit.
> >
> > v3:
> > - Rebase on top of VLV/CHV backlight changes, in particuliar
> > bxt_set_backlight() now has a different prototype (Damien)
> >
> > Reviewed-by: Jani Nikula <jani.nikula@intel.com>
>
> Yup.
Queued for -next, thanks for the patch.
-Daniel
--
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2015-05-06 11:15 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-05-05 9:21 [PATCH] drm/i915/bxt: BLC implementation Vandana Kannan
2015-05-05 11:33 ` Jani Nikula
2015-05-06 11:17 ` Daniel Vetter [this message]
2015-05-05 14:30 ` shuang.he
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150506111730.GA30184@phenom.ffwll.local \
--to=daniel@ffwll.ch \
--cc=intel-gfx@lists.freedesktop.org \
--cc=jani.nikula@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.