All of lore.kernel.org
 help / color / mirror / Atom feed
From: Pavel Dovgalyuk <Pavel.Dovgaluk@ispras.ru>
To: qemu-devel@nongnu.org
Cc: peter.maydell@linaro.org, peter.crosthwaite@xilinx.com,
	alex.bennee@linaro.org, mark.burton@greensocs.com,
	real@ispras.ru, batuzovk@ispras.ru,
	maria.klimushenkova@ispras.ru, pavel.dovgaluk@ispras.ru,
	pbonzini@redhat.com, fred.konrad@greensocs.com
Subject: [Qemu-devel] [RFC PATCH v13 09/21] i386: interrupt poll processing
Date: Wed, 06 May 2015 17:03:33 +0300	[thread overview]
Message-ID: <20150506140332.17288.64074.stgit@PASHA-ISP> (raw)
In-Reply-To: <20150506140238.17288.87548.stgit@PASHA-ISP>

This patch updates x86_cpu_exec_interrupt function.
It can process two interrupt request at a time (poll and another one).
This makes its execution non-deterministic. Determinism is requred
for recorded icount execution.

Signed-off-by: Pavel Dovgalyuk <pavel.dovgaluk@ispras.ru>
---
 target-i386/seg_helper.c |    3 +++
 1 files changed, 3 insertions(+), 0 deletions(-)

diff --git a/target-i386/seg_helper.c b/target-i386/seg_helper.c
index 2bc757a..92a49b3 100644
--- a/target-i386/seg_helper.c
+++ b/target-i386/seg_helper.c
@@ -1294,6 +1294,9 @@ bool x86_cpu_exec_interrupt(CPUState *cs, int interrupt_request)
     if (interrupt_request & CPU_INTERRUPT_POLL) {
         cs->interrupt_request &= ~CPU_INTERRUPT_POLL;
         apic_poll_irq(cpu->apic_state);
+        /* Don't process multiple interrupt requests in a single call.
+           This is required to make icount-driven execution deterministic. */
+        return true;
     }
 #endif
     if (interrupt_request & CPU_INTERRUPT_SIPI) {

  parent reply	other threads:[~2015-05-06 14:03 UTC|newest]

Thread overview: 25+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-05-06 14:02 [Qemu-devel] [RFC PATCH v13 00/21] Deterministic replay core Pavel Dovgalyuk
2015-05-06 14:02 ` [Qemu-devel] [RFC PATCH v13 01/21] i386: partial revert of interrupt poll fix Pavel Dovgalyuk
2015-05-06 14:02 ` [Qemu-devel] [RFC PATCH v13 02/21] replay: global variables and function stubs Pavel Dovgalyuk
2015-05-06 14:02 ` [Qemu-devel] [RFC PATCH v13 03/21] sysemu: system functions for replay Pavel Dovgalyuk
2015-05-06 14:03 ` [Qemu-devel] [RFC PATCH v13 04/21] replay: internal functions for replay log Pavel Dovgalyuk
2015-05-06 14:03 ` [Qemu-devel] [RFC PATCH v13 05/21] replay: introduce mutex to protect the " Pavel Dovgalyuk
2015-05-06 14:03 ` [Qemu-devel] [RFC PATCH v13 06/21] replay: introduce icount event Pavel Dovgalyuk
2015-05-06 14:03 ` [Qemu-devel] [RFC PATCH v13 07/21] cpu-exec: allow temporary disabling icount Pavel Dovgalyuk
2015-05-06 14:03 ` [Qemu-devel] [RFC PATCH v13 08/21] cpu: replay instructions sequence Pavel Dovgalyuk
2015-05-06 14:03 ` Pavel Dovgalyuk [this message]
2015-05-06 14:03 ` [Qemu-devel] [RFC PATCH v13 10/21] replay: interrupts and exceptions Pavel Dovgalyuk
2015-05-06 14:03 ` [Qemu-devel] [RFC PATCH v13 11/21] replay: asynchronous events infrastructure Pavel Dovgalyuk
2015-05-06 14:03 ` [Qemu-devel] [RFC PATCH v13 12/21] replay: recording and replaying clock ticks Pavel Dovgalyuk
2015-05-06 14:03 ` [Qemu-devel] [RFC PATCH v13 13/21] replay: shutdown event Pavel Dovgalyuk
2015-05-06 14:04 ` [Qemu-devel] [RFC PATCH v13 14/21] replay: checkpoints Pavel Dovgalyuk
2015-05-06 14:04 ` [Qemu-devel] [RFC PATCH v13 15/21] bottom halves: introduce bh call function Pavel Dovgalyuk
2015-05-06 14:39   ` Paolo Bonzini
2015-05-07  6:48     ` Pavel Dovgaluk
2015-05-06 14:04 ` [Qemu-devel] [RFC PATCH v13 16/21] replay: ptimer Pavel Dovgalyuk
2015-05-06 14:04 ` [Qemu-devel] [RFC PATCH v13 17/21] typedef: add typedef for QemuOpts Pavel Dovgalyuk
2015-05-06 14:04 ` [Qemu-devel] [RFC PATCH v13 18/21] replay: initialization and deinitialization Pavel Dovgalyuk
2015-05-06 14:04 ` [Qemu-devel] [RFC PATCH v13 19/21] replay: replay blockers for devices Pavel Dovgalyuk
2015-05-06 14:04 ` [Qemu-devel] [RFC PATCH v13 20/21] replay: command line options Pavel Dovgalyuk
2015-05-06 14:04 ` [Qemu-devel] [RFC PATCH v13 21/21] replay: recording of the user input Pavel Dovgalyuk
2015-05-19  7:44 ` [Qemu-devel] [RFC PATCH v13 00/21] Deterministic replay core Pavel Dovgaluk

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20150506140332.17288.64074.stgit@PASHA-ISP \
    --to=pavel.dovgaluk@ispras.ru \
    --cc=alex.bennee@linaro.org \
    --cc=batuzovk@ispras.ru \
    --cc=fred.konrad@greensocs.com \
    --cc=maria.klimushenkova@ispras.ru \
    --cc=mark.burton@greensocs.com \
    --cc=pbonzini@redhat.com \
    --cc=peter.crosthwaite@xilinx.com \
    --cc=peter.maydell@linaro.org \
    --cc=qemu-devel@nongnu.org \
    --cc=real@ispras.ru \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.