From: Felix Janda <felix.janda@posteo.de>
To: Alexey Gladkov <gladkov.alexey@gmail.com>
Cc: kbd@lists.altlinux.org
Subject: Re: [kbd] [PATCH 5/5] Replace error() by fprintf() and perror()
Date: Wed, 6 May 2015 21:34:09 +0200 [thread overview]
Message-ID: <20150506193409.GA30407@euler> (raw)
In-Reply-To: <20150504195148.GA3967@euler>
Alexey Gladkov wrote:
> I prefer to save compatibility with the error() function. It costs
> nothing, but it does not require to keep in mind the difference
> between two implementations.
There is a small cost (which might not be relevant for kbd):
The compiler does not know that kbd_error() will not return in most
cases and might emit warnings about possibly uninitialized variables
because of that.
Just to mentoin it...
Felix
next prev parent reply other threads:[~2015-05-06 19:34 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-04-22 19:06 [kbd] [PATCH 5/5] Replace error() by fprintf() and perror() Felix Janda
2015-04-26 11:18 ` Alexey Gladkov
2015-04-28 22:08 ` Alexey Gladkov
2015-04-29 18:11 ` Felix Janda
2015-04-30 19:21 ` Alexey Gladkov
2015-04-30 20:36 ` Felix Janda
2015-05-04 18:38 ` Alexey Gladkov
[not found] ` <20150504195148.GA3967@euler>
2015-05-04 23:10 ` Alexey Gladkov
2015-05-06 19:34 ` Felix Janda [this message]
2015-05-11 22:00 ` Alexey Gladkov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150506193409.GA30407@euler \
--to=felix.janda@posteo.de \
--cc=gladkov.alexey@gmail.com \
--cc=kbd@lists.altlinux.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.