From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:60829) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YqDlL-0003aj-BX for qemu-devel@nongnu.org; Thu, 07 May 2015 00:50:20 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YqDlG-0000Ee-7e for qemu-devel@nongnu.org; Thu, 07 May 2015 00:50:19 -0400 Received: from e28smtp07.in.ibm.com ([122.248.162.7]:52661) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YqDlF-00009Y-Kd for qemu-devel@nongnu.org; Thu, 07 May 2015 00:50:14 -0400 Received: from /spool/local by e28smtp07.in.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Thu, 7 May 2015 10:20:09 +0530 Date: Thu, 7 May 2015 10:20:03 +0530 From: Bharata B Rao Message-ID: <20150507045003.GW18380@in.ibm.com> References: <1430971024-27899-1-git-send-email-david@gibson.dropbear.id.au> <1430971024-27899-4-git-send-email-david@gibson.dropbear.id.au> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1430971024-27899-4-git-send-email-david@gibson.dropbear.id.au> Subject: Re: [Qemu-devel] [PATCH 3/4] spapr: Remove obsolete entry_point field from sPAPRMachineState Reply-To: bharata@linux.vnet.ibm.com List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: David Gibson Cc: lvivier@redhat.com, thuth@redhat.com, mdroth@linux.vnet.ibm.com, aik@ozlabs.ru, qemu-devel@nongnu.org, agraf@suse.de, qemu-ppc@nongnu.org, afaerber@suse.de On Thu, May 07, 2015 at 01:57:03PM +1000, David Gibson wrote: > The sPAPRMachineState structure includes an entry_point field containing > the initial PC value for starting the machine, even though this always has > the value 0x100. > > I think this is a hangover from very early versions which bypassed the > firmware when using -kernel. In any case it has no function now, so remove > it. > > Signed-off-by: David Gibson > --- > hw/ppc/spapr.c | 4 +--- > include/hw/ppc/spapr.h | 2 +- > 2 files changed, 2 insertions(+), 4 deletions(-) > > diff --git a/hw/ppc/spapr.c b/hw/ppc/spapr.c > index 1123358..c4c7a07 100644 > --- a/hw/ppc/spapr.c > +++ b/hw/ppc/spapr.c > @@ -928,7 +928,7 @@ static void ppc_spapr_reset(void) > first_ppc_cpu->env.gpr[3] = sm->fdt_addr; > first_ppc_cpu->env.gpr[5] = 0; > first_cpu->halted = 0; > - first_ppc_cpu->env.nip = sm->entry_point; > + first_ppc_cpu->env.nip = SPAPR_ENTRY_POINT; > > } > > @@ -1641,8 +1641,6 @@ static void ppc_spapr_init(MachineState *machine) > } > g_free(filename); > > - sm->entry_point = 0x100; > - > /* FIXME: Should register thigs through the MachineState's qdev > * interface, this is a legacy from the sPAPREnvironment structure > * which predated MachineState but had a similar function */ > diff --git a/include/hw/ppc/spapr.h b/include/hw/ppc/spapr.h > index 9e7cf0f..108ff45 100644 > --- a/include/hw/ppc/spapr.h > +++ b/include/hw/ppc/spapr.h > @@ -13,6 +13,7 @@ typedef struct sPAPRConfigureConnectorState sPAPRConfigureConnectorState; > typedef struct sPAPREventLogEntry sPAPREventLogEntry; > > #define HPTE64_V_HPTE_DIRTY 0x0000000000000040ULL > +#define SPAPR_ENTRY_POINT 0x100 checkpatch.pl complains about the use of tab here. Other than that I did a quick compile and VM boot test, things look ok. Regards, Bharata.