From: Wei Liu <wei.liu2@citrix.com>
To: Olaf Hering <olaf@aepfle.de>
Cc: Wei Liu <wei.liu2@citrix.com>,
Stefano Stabellini <stefano.stabellini@eu.citrix.com>,
Ian Jackson <ian.jackson@eu.citrix.com>,
Ian Campbell <ian.campbell@citrix.com>,
xen-devel@lists.xen.org
Subject: Re: [PATCH v2] tools: add configure --with-dumpdir=DIR option
Date: Thu, 7 May 2015 09:01:44 +0100 [thread overview]
Message-ID: <20150507080144.GA28443@zion.uk.xensource.com> (raw)
In-Reply-To: <1430896124-604-1-git-send-email-olaf@aepfle.de>
On Wed, May 06, 2015 at 07:08:44AM +0000, Olaf Hering wrote:
> The current base directory /var/xen for domU dumps will be patched to
> /var/lib/xen by most distros. Provide a configure option to avoid
> patching the source.
>
> If the option is not specified the default remains /var/xen/dump.
>
> Please rerun autogen.sh after applying this patch.
>
> Signed-off-by: Olaf Hering <olaf@aepfle.de>
> Cc: Ian Jackson <ian.jackson@eu.citrix.com>
> Cc: Stefano Stabellini <stefano.stabellini@eu.citrix.com>
> Cc: Ian Campbell <ian.campbell@citrix.com>
> Cc: Wei Liu <wei.liu2@citrix.com>
> Acked-by: Wei Liu <wei.liu2@citrix.com>
> ---
>
> v2:
> - fix "conigure" typo in Subject line
>
> Config.mk | 2 +-
> INSTALL | 4 ++++
> config/Paths.mk.in | 1 +
> m4/paths.m4 | 9 +++++++++
> tools/Makefile | 2 +-
> tools/libxl/xl_cmdimpl.c | 2 +-
> 6 files changed, 17 insertions(+), 3 deletions(-)
You have not patched docs. I think it still references /var/xen/dump.
I discovered this when I read the manpage of xl.cfg.
Sorry for not noticing this earlier.
Wei.
next prev parent reply other threads:[~2015-05-07 8:01 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-05-06 7:08 [PATCH v2] tools: add configure --with-dumpdir=DIR option Olaf Hering
2015-05-07 8:01 ` Wei Liu [this message]
2015-05-07 8:10 ` Olaf Hering
2015-05-07 8:14 ` Wei Liu
2015-05-07 9:22 ` Ian Campbell
2015-05-08 6:54 ` Olaf Hering
2015-05-08 9:37 ` Ian Campbell
2015-05-11 14:17 ` Olaf Hering
-- strict thread matches above, loose matches on Subject: below --
2015-05-11 15:33 Olaf Hering
2015-05-21 14:09 ` Ian Campbell
2015-05-21 14:27 ` Olaf Hering
2015-05-21 15:23 ` Ian Campbell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150507080144.GA28443@zion.uk.xensource.com \
--to=wei.liu2@citrix.com \
--cc=ian.campbell@citrix.com \
--cc=ian.jackson@eu.citrix.com \
--cc=olaf@aepfle.de \
--cc=stefano.stabellini@eu.citrix.com \
--cc=xen-devel@lists.xen.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.