From mboxrd@z Thu Jan 1 00:00:00 1970 From: Chao Peng Subject: Re: [PATCH v6 03/14] x86: detect and initialize Intel CAT feature Date: Thu, 7 May 2015 17:08:28 +0800 Message-ID: <20150507090828.GG3458@pengc-linux.bj.intel.com> References: <1429782951-18813-1-git-send-email-chao.p.peng@linux.intel.com> <1429782951-18813-4-git-send-email-chao.p.peng@linux.intel.com> <553A76740200007800075A5F@mail.emea.novell.com> Reply-To: Chao Peng Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Content-Disposition: inline In-Reply-To: <553A76740200007800075A5F@mail.emea.novell.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Jan Beulich Cc: wei.liu2@citrix.com, Ian.Campbell@citrix.com, stefano.stabellini@eu.citrix.com, andrew.cooper3@citrix.com, dario.faggioli@citrix.com, Ian.Jackson@eu.citrix.com, xen-devel@lists.xen.org, will.auld@intel.com, keir@xen.org, dgdegra@tycho.nsa.gov List-Id: xen-devel@lists.xenproject.org On Fri, Apr 24, 2015 at 03:59:32PM +0100, Jan Beulich wrote: > >>> On 23.04.15 at 11:55, wrote: > > struct psr_cmt *__read_mostly psr_cmt; > > + > > +static unsigned long __read_mostly * cat_socket_init_bitmap; > > +static unsigned long __read_mostly * cat_socket_enable_bitmap; > > +static struct psr_cat_socket_info *__read_mostly cat_socket_info; > > So the last line looks right, and the line of context left in place is > well formed too. Why did you not follow these good examples for > the two newly added lines? > > And what is cat_socket_enable_bitmap needed for anyway? Sorry for missing this. It indicates if CAT is enabled on the socket while cat_socket_init_bitmap only indicates the socket is initialized(but the socket may not support CAT or CAT is not enabled successfully by software). cat_socket_init_bitmap is totally for performance optimization, to avoid initializing the same socket for more than one times. If you think one should removed, then cat_socket_init_bitmap will be the candidate. Chao