From: Andi Kleen <andi@firstfloor.org>
To: Kan Liang <kan.liang@intel.com>
Cc: peterz@infradead.org, mingo@kernel.org, acme@infradead.org,
eranian@google.com, andi@firstfloor.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH V8 8/8] perf tools: handle PERF_RECORD_LOST_SAMPLES
Date: Thu, 7 May 2015 12:33:42 +0200 [thread overview]
Message-ID: <20150507103342.GO2366@two.firstfloor.org> (raw)
In-Reply-To: <1430940834-8964-9-git-send-email-kan.liang@intel.com>
On Wed, May 06, 2015 at 03:33:54PM -0400, Kan Liang wrote:
> From: Kan Liang <kan.liang@intel.com>
>
> This patch modified the perf tool to handle the new RECORD type,
> PERF_RECORD_LOST_SAMPLES.
> The number of lost-sample events is stored in
> .nr_events[PERF_EVENT_LOST_SAMPLES]. While the exact number of samples
> which the kernel dropped is stored in total_lost_samples.
> When the percentage of dropped samples is greater than 5%, a warning
> will be sent out.
That's nice. Would be good to also print this in perf report --stdio
output (without -D), like the samples are.
Could you please do the same for the normal PERF_RECORD_LOST too?
There we don't have a exact percentage, but at least could count the
lost events too. This can be a separate patch of course, doesn't need
to be tied to this patchkit.
-Andi
next prev parent reply other threads:[~2015-05-07 10:33 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-05-06 19:33 [PATCH V8 0/8] large PEBS interrupt threshold Kan Liang
2015-05-06 19:33 ` [PATCH V8 1/8] perf, x86: use the PEBS auto reload mechanism when possible Kan Liang
2015-06-07 17:49 ` [tip:perf/core] perf/x86/intel: Use " tip-bot for Yan, Zheng
2015-05-06 19:33 ` [PATCH V8 2/8] perf, x86: introduce setup_pebs_sample_data() Kan Liang
2015-06-07 17:49 ` [tip:perf/core] perf/x86/intel: Introduce setup_pebs_sample_data( ) tip-bot for Yan, Zheng
2015-05-06 19:33 ` [PATCH V8 3/8] perf, x86: handle multiple records in PEBS buffer Kan Liang
2015-05-08 11:05 ` Andi Kleen
2015-05-08 11:29 ` Peter Zijlstra
2015-06-07 17:49 ` [tip:perf/core] perf/x86/intel: Handle multiple records in the " tip-bot for Yan, Zheng
2015-05-06 19:33 ` [PATCH V8 4/8] perf, x86: large PEBS interrupt threshold Kan Liang
2015-06-07 17:49 ` [tip:perf/core] perf/x86/intel: Implement batched PEBS interrupt handling (large PEBS interrupt threshold ) tip-bot for Yan, Zheng
2015-05-06 19:33 ` [PATCH V8 5/8] perf, x86: drain PEBS buffer during context switch Kan Liang
2015-06-07 17:50 ` [tip:perf/core] perf/x86/intel: Drain the PEBS buffer during context switches tip-bot for Yan, Zheng
2015-05-06 19:33 ` [PATCH V8 6/8] perf, x86: enlarge PEBS buffer Kan Liang
2015-06-07 17:50 ` [tip:perf/core] perf/intel/x86: Enlarge the " tip-bot for Yan, Zheng
2015-05-06 19:33 ` [PATCH V8 7/8] perf, x86: introduce PERF_RECORD_LOST_SAMPLES Kan Liang
2015-05-07 11:35 ` Peter Zijlstra
2015-05-07 11:54 ` Peter Zijlstra
2015-05-07 14:15 ` Arnaldo Carvalho de Melo
2015-05-07 14:21 ` Arnaldo Carvalho de Melo
2015-05-07 14:39 ` Peter Zijlstra
2015-05-07 16:22 ` Arnaldo Carvalho de Melo
2015-05-07 17:37 ` Peter Zijlstra
2015-05-07 20:01 ` Arnaldo Carvalho de Melo
2015-05-07 13:56 ` Liang, Kan
2015-05-07 13:58 ` Peter Zijlstra
2015-05-06 19:33 ` [PATCH V8 8/8] perf tools: handle PERF_RECORD_LOST_SAMPLES Kan Liang
2015-05-07 10:33 ` Andi Kleen [this message]
2015-05-07 14:17 ` Liang, Kan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150507103342.GO2366@two.firstfloor.org \
--to=andi@firstfloor.org \
--cc=acme@infradead.org \
--cc=eranian@google.com \
--cc=kan.liang@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@kernel.org \
--cc=peterz@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.