From mboxrd@z Thu Jan 1 00:00:00 1970 From: Alexandre Belloni Subject: Re: [PATCH v4 2/3] rtc: mediatek: Add MT6397 RTC driver Date: Thu, 7 May 2015 14:06:01 +0200 Message-ID: <20150507120601.GH3465@piout.net> References: <1430897022-63357-1-git-send-email-eddie.huang@mediatek.com> <1430897022-63357-3-git-send-email-eddie.huang@mediatek.com> <1430898299.9365.74.camel@perches.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: <1430898299.9365.74.camel@perches.com> Sender: linux-kernel-owner@vger.kernel.org To: Joe Perches Cc: Eddie Huang , Lee Jones , Alessandro Zummo , srv_heupstream@mediatek.com, Samuel Ortiz , Matthias Brugger , Andrew Morton , Greg KH , "David S. Miller" , Mauro Carvalho Chehab , Tejun Heo , linux-kernel@vger.kernel.org, rtc-linux@googlegroups.com, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org, Sascha Hauer , Tomasz Figa , Tianping Fang List-Id: linux-mediatek@lists.infradead.org On 06/05/2015 at 00:44:59 -0700, Joe Perches wrote : > On Wed, 2015-05-06 at 15:23 +0800, Eddie Huang wrote: > > From: Tianping Fang > > trivia: no need to resend now, maybe in a future patch. > > > diff --git a/drivers/rtc/rtc-mt6397.c b/drivers/rtc/rtc-mt6397.c > [] > > +static int mtk_rtc_probe(struct platform_device *pdev) > > +{ > [] > > + ret = request_threaded_irq(rtc->irq, NULL, > > + mtk_rtc_irq_handler_thread, > > + IRQF_ONESHOT | IRQF_TRIGGER_HIGH, > > + "mt6397-rtc", rtc); > > It'd be nicer to align all the statement lines > to that open parenthesis > > I'll fix it up when applying. -- Alexandre Belloni, Free Electrons Embedded Linux, Kernel and Android engineering http://free-electrons.com From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail.free-electrons.com (down.free-electrons.com. [37.187.137.238]) by gmr-mx.google.com with ESMTP id k2si258691wif.0.2015.05.07.05.06.02 for ; Thu, 07 May 2015 05:06:02 -0700 (PDT) Date: Thu, 7 May 2015 14:06:01 +0200 From: Alexandre Belloni To: Joe Perches Cc: Eddie Huang , Lee Jones , Alessandro Zummo , srv_heupstream@mediatek.com, Samuel Ortiz , Matthias Brugger , Andrew Morton , Greg KH , "David S. Miller" , Mauro Carvalho Chehab , Tejun Heo , linux-kernel@vger.kernel.org, rtc-linux@googlegroups.com, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org, Sascha Hauer , Tomasz Figa , Tianping Fang Subject: [rtc-linux] Re: [PATCH v4 2/3] rtc: mediatek: Add MT6397 RTC driver Message-ID: <20150507120601.GH3465@piout.net> References: <1430897022-63357-1-git-send-email-eddie.huang@mediatek.com> <1430897022-63357-3-git-send-email-eddie.huang@mediatek.com> <1430898299.9365.74.camel@perches.com> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 In-Reply-To: <1430898299.9365.74.camel@perches.com> Reply-To: rtc-linux@googlegroups.com List-ID: List-Post: , List-Help: , List-Archive: , List-Unsubscribe: , On 06/05/2015 at 00:44:59 -0700, Joe Perches wrote : > On Wed, 2015-05-06 at 15:23 +0800, Eddie Huang wrote: > > From: Tianping Fang > > trivia: no need to resend now, maybe in a future patch. > > > diff --git a/drivers/rtc/rtc-mt6397.c b/drivers/rtc/rtc-mt6397.c > [] > > +static int mtk_rtc_probe(struct platform_device *pdev) > > +{ > [] > > + ret = request_threaded_irq(rtc->irq, NULL, > > + mtk_rtc_irq_handler_thread, > > + IRQF_ONESHOT | IRQF_TRIGGER_HIGH, > > + "mt6397-rtc", rtc); > > It'd be nicer to align all the statement lines > to that open parenthesis > > I'll fix it up when applying. -- Alexandre Belloni, Free Electrons Embedded Linux, Kernel and Android engineering http://free-electrons.com -- -- You received this message because you are subscribed to "rtc-linux". Membership options at http://groups.google.com/group/rtc-linux . Please read http://groups.google.com/group/rtc-linux/web/checklist before submitting a driver. --- You received this message because you are subscribed to the Google Groups "rtc-linux" group. To unsubscribe from this group and stop receiving emails from it, send an email to rtc-linux+unsubscribe@googlegroups.com. For more options, visit https://groups.google.com/d/optout. From mboxrd@z Thu Jan 1 00:00:00 1970 From: alexandre.belloni@free-electrons.com (Alexandre Belloni) Date: Thu, 7 May 2015 14:06:01 +0200 Subject: [PATCH v4 2/3] rtc: mediatek: Add MT6397 RTC driver In-Reply-To: <1430898299.9365.74.camel@perches.com> References: <1430897022-63357-1-git-send-email-eddie.huang@mediatek.com> <1430897022-63357-3-git-send-email-eddie.huang@mediatek.com> <1430898299.9365.74.camel@perches.com> Message-ID: <20150507120601.GH3465@piout.net> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On 06/05/2015 at 00:44:59 -0700, Joe Perches wrote : > On Wed, 2015-05-06 at 15:23 +0800, Eddie Huang wrote: > > From: Tianping Fang > > trivia: no need to resend now, maybe in a future patch. > > > diff --git a/drivers/rtc/rtc-mt6397.c b/drivers/rtc/rtc-mt6397.c > [] > > +static int mtk_rtc_probe(struct platform_device *pdev) > > +{ > [] > > + ret = request_threaded_irq(rtc->irq, NULL, > > + mtk_rtc_irq_handler_thread, > > + IRQF_ONESHOT | IRQF_TRIGGER_HIGH, > > + "mt6397-rtc", rtc); > > It'd be nicer to align all the statement lines > to that open parenthesis > > I'll fix it up when applying. -- Alexandre Belloni, Free Electrons Embedded Linux, Kernel and Android engineering http://free-electrons.com