From: Jacob Pan <jacob.jun.pan@linux.intel.com>
To: Anand Moon <linux.amoon@gmail.com>
Cc: Zhang Rui <rui.zhang@intel.com>,
Brian Norris <computersforpeace@gmail.com>,
Florian Fainelli <f.fainelli@gmail.com>,
Javi Merino <javi.merino@arm.com>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] tools/thermal: tmon: fixed the 'make install' command
Date: Thu, 7 May 2015 13:31:45 -0700 [thread overview]
Message-ID: <20150507133145.66079d01@jacob-VirtualBox> (raw)
In-Reply-To: <1431022144-5173-1-git-send-email-linux.amoon@gmail.com>
On Fri, 8 May 2015 03:39:04 +0930
Anand Moon <linux.amoon@gmail.com> wrote:
> To install tmon we issue "make install" which produces bellow error.
>
looks good, there is no config file for now.
Thanks for the fix.
Acked-by: Jacob Pan <jacob.jun.pan@linux.intel.com>
> root@odroidxu3:/usr/src/odroidxu3-4.y-testing/tools/thermal/tmon#
> make install mkdir -p /usr/bin
> install -m 755 -p "tmon" "/usr/bin/tmon"
> mkdir -p /
> install -m 644 -p "" "/"
> install: cannot stat ‘’: No such file or directory
> make: [install] Error 1 (ignored)
>
> Signed-off-by: Anand Moon <linux.amoon@gmail.com>
> ---
> tools/thermal/tmon/Makefile | 8 --------
> 1 file changed, 8 deletions(-)
>
> diff --git a/tools/thermal/tmon/Makefile b/tools/thermal/tmon/Makefile
> index 0788621..2e83dd3 100644
> --- a/tools/thermal/tmon/Makefile
> +++ b/tools/thermal/tmon/Makefile
> @@ -12,10 +12,6 @@ TARGET=tmon
> INSTALL_PROGRAM=install -m 755 -p
> DEL_FILE=rm -f
>
> -INSTALL_CONFIGFILE=install -m 644 -p
> -CONFIG_FILE=
> -CONFIG_PATH=
> -
> # Static builds might require -ltinfo, for instance
> ifneq ($(findstring -static, $(LDFLAGS)),)
> STATIC := --static
> @@ -38,13 +34,9 @@ valgrind: tmon
> install:
> - mkdir -p $(INSTALL_ROOT)/$(BINDIR)
> - $(INSTALL_PROGRAM) "$(TARGET)"
> "$(INSTALL_ROOT)/$(BINDIR)/$(TARGET)"
> - - mkdir -p $(INSTALL_ROOT)/$(CONFIG_PATH)
> - - $(INSTALL_CONFIGFILE) "$(CONFIG_FILE)"
> "$(INSTALL_ROOT)/$(CONFIG_PATH)"
> uninstall:
> $(DEL_FILE) "$(INSTALL_ROOT)/$(BINDIR)/$(TARGET)"
> - $(CONFIG_FILE) "$(CONFIG_PATH)"
> -
>
> clean:
> find . -name "*.o" | xargs $(DEL_FILE)
[Jacob Pan]
next prev parent reply other threads:[~2015-05-07 20:31 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-05-07 18:09 [PATCH] tools/thermal: tmon: fixed the 'make install' command Anand Moon
2015-05-07 20:31 ` Jacob Pan [this message]
2015-05-08 3:04 ` Zhang Rui
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150507133145.66079d01@jacob-VirtualBox \
--to=jacob.jun.pan@linux.intel.com \
--cc=computersforpeace@gmail.com \
--cc=f.fainelli@gmail.com \
--cc=javi.merino@arm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux.amoon@gmail.com \
--cc=rui.zhang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.