From: Jeff King <peff@peff.net>
To: Junio C Hamano <gitster@pobox.com>
Cc: git@vger.kernel.org
Subject: Re: [PATCH] tests: skip dav http-push tests under NO_EXPAT=NoThanks
Date: Thu, 7 May 2015 12:13:11 -0400 [thread overview]
Message-ID: <20150507161311.GA26219@peff.net> (raw)
In-Reply-To: <xmqqzj5gqsnd.fsf_-_@gitster.dls.corp.google.com>
On Thu, May 07, 2015 at 09:06:14AM -0700, Junio C Hamano wrote:
> When built with NO_EXPAT=NoThanks, we will not have a working http-push
> over webdav.
Hmph, I used to build with NO_EXPAT long ago and don't remember running
into this, but it is clearly broken now. I wonder what bizarre
combination of leftover build products made it work. ;)
> diff --git a/t/lib-httpd.sh b/t/lib-httpd.sh
> index 872a252..d823664 100644
> --- a/t/lib-httpd.sh
> +++ b/t/lib-httpd.sh
> @@ -36,6 +36,12 @@ then
> test_done
> fi
>
> +if test -n "$NO_EXPAT" && test -n "$LIB_HTTPD_DAV"
> +then
> + skip_all='skipping test, git built without expat support'
> + test_done
> +fi
I was confused at first why this is in lib-httpd.sh and not 5540, but I
see LIB_HTTPD_DAV is provided by t5540 as a feature flag to
lib-httpd.sh. I learn something new every day about our test
infrastructure.
-Peff
prev parent reply other threads:[~2015-05-07 16:13 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-05-06 16:58 [PATCH] t5540: skip under NO_CURL=NoThanks Junio C Hamano
2015-05-06 17:32 ` Jeff King
2015-05-06 17:42 ` Jeff King
2015-05-06 18:49 ` Junio C Hamano
2015-05-07 16:06 ` [PATCH] tests: skip dav http-push tests under NO_EXPAT=NoThanks Junio C Hamano
2015-05-07 16:13 ` Jeff King [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150507161311.GA26219@peff.net \
--to=peff@peff.net \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.