From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ismael Luceno Subject: Re: [PATCH] drm/i915: Fix screen flickering on X Date: Thu, 7 May 2015 18:23:02 -0300 Message-ID: <20150507182302.4534634d@pirotess> References: <1428792034-6131-1-git-send-email-ismael@iodev.co.uk> <20150423091532.GA21511@nuc-i3427.alporthouse.com> <87zj5g69al.fsf@intel.com> <20150507132715.GA22531@intel.com> <87r3qs5wtf.fsf@intel.com> <20150507141827.GW22099@nuc-i3427.alporthouse.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from iodev.co.uk (iodev.co.uk [82.211.30.53]) by gabe.freedesktop.org (Postfix) with ESMTP id 68E2E6E21E for ; Thu, 7 May 2015 14:23:22 -0700 (PDT) In-Reply-To: <20150507141827.GW22099@nuc-i3427.alporthouse.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Chris Wilson Cc: intel-gfx@lists.freedesktop.org, linux-kernel@vger.kernel.org List-Id: intel-gfx@lists.freedesktop.org T24gVGh1LCA3IE1heSAyMDE1IDE1OjE4OjI3ICswMTAwCkNocmlzIFdpbHNvbiA8Y2hyaXNAY2hy aXMtd2lsc29uLmNvLnVrPiB3cm90ZToKPiBPbiBUaHUsIE1heSAwNywgMjAxNSBhdCAwNDo0MTo0 OFBNICswMzAwLCBKYW5pIE5pa3VsYSB3cm90ZToKPiA+IE9uIFRodSwgMDcgTWF5IDIwMTUsIE1h dHQgUm9wZXIgPG1hdHRoZXcuZC5yb3BlckBpbnRlbC5jb20+IHdyb3RlOgo+ID4gPiBPbiBUaHUs IE1heSAwNywgMjAxNSBhdCAxMjoxMjoxOFBNICswMzAwLCBKYW5pIE5pa3VsYSB3cm90ZToKPiA+ ID4+IE9uIFRodSwgMjMgQXByIDIwMTUsIENocmlzIFdpbHNvbiA8Y2hyaXNAY2hyaXMtd2lsc29u LmNvLnVrPgo+ID4gPj4gd3JvdGU6Cj4gPiA+PiA+IFtjYydpbmcgdGhlIGF1dGhvcnNdCj4gPiA+ PiAKPiA+ID4+IFRoaXMgaGFzIGJlZW4gcG9zdGVkIGVhcmxpZXIgWzFdIGFuZCBpdCBoYXMgcmV2 aWV3IHRvIGJlCj4gPiA+PiBhZGRyZXNzZWQgWzJdLgo+ID4gPj4gCj4gPiA+PiBCUiwKPiA+ID4+ IEphbmkuCj4gPiA+Cj4gPiA+IEkgYWdyZWUgd2l0aCBBbmRlcidzIHJlc3BvbnNlIGluIFsyXS4u LndlIGNhbid0IGNhbGwKPiA+ID4gaW50ZWxfdXBkYXRlX3dhdGVybWFya3MoKSBpbiB0aGUgY29t bWl0IGZ1bmN0aW9uIGJlY2F1c2Ugd2UncmUKPiA+ID4gdW5kZXIgdmJsYW5rIGV2YXNpb24uICBX ZSBzaG91bGQgYWxyZWFkeSBiZSBmbGFnZ2luZyB0aGUKPiA+ID4gdHJhbnNhY3Rpb24gYXMgbmVl ZGluZyBhIHdhdGVybWFyayB1cGRhdGUgaW4KPiA+ID4gaW50ZWxfY2hlY2tfY3Vyc29yX3BsYW5l KCksIGFuZCB0aGF0IGZsYWcgd2lsbCBiZSBhY3RlZCB1cG9uCj4gPiA+IGltbWVkaWF0ZWx5IGFm dGVyIHRoZSBjb21taXQgZnVuY3Rpb25zIGFyZSBkb25lIHJ1bm5pbmcsIG9uY2UKPiA+ID4gd2Un dmUgcmUtZW5hYmxlZCBpbnRlcnJ1cHRzLgo+ID4gPgo+ID4gPiBOb3RlIHRoYXQgb3VyIGN1cnJl bnQgY29kZWJhc2UgbG9va3MgYSBiaXQgZGlmZmVyZW50IHNpbmNlIHdlJ3ZlCj4gPiA+IGRyb3Bw ZWQgaW50ZWxfY3J0Yy0+Y3Vyc29yX3t3aWR0aCxoZWlnaHR9LiAgU28gdGhlIHJlbGV2YW50IGNo ZWNrCj4gPiA+IGluIGludGVsX2NoZWNrX2N1cnNvcl9wbGFuZSgpIG5vdyBsb29rcyBsaWtlOgo+ ID4gPgo+ID4gPiAgICAgICAgIGlmIChwbGFuZS0+c3RhdGUtPmNydGNfdyAhPSBzdGF0ZS0+YmFz ZS5jcnRjX3cpCj4gPiA+ICAgICAgICAgICAgICAgICBpbnRlbF9jcnRjLT5hdG9taWMudXBkYXRl X3dtID0gdHJ1ZTsKPiA+ID4KPiA+ID4gSXMgdGhlcmUgYSBidWd6aWxsYSBvcGVuIG9uIHRoaXMg aXNzdWUgd2l0aCBtb3JlIGRldGFpbHM/Cj4gPiAKPiA+IE5vdCB0aGF0IEkga25vdyBvZi4gSXNt YWVsPwo+ID4gCj4gCj4gUHJvYmFibHk6Cj4gaHR0cHM6Ly9idWdzLmZyZWVkZXNrdG9wLm9yZy9z aG93X2J1Zy5jZ2k/aWQ9ODg5NDQKPiBodHRwczovL2J1Z3ppbGxhLnJlZGhhdC5jb20vc2hvd19i dWcuY2dpP2lkPTExOTk4OTAKPiBhcmUgcmVsYXRlZC4KPiAtQ2hyaXMKPiAKCkkgYW0gZXhwZXJp ZW5jaW5nIG5laXRoZXIgb2YgdGhvc2UgdGhpbmdzLgpfX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fXwpJbnRlbC1nZnggbWFpbGluZyBsaXN0CkludGVsLWdmeEBs aXN0cy5mcmVlZGVza3RvcC5vcmcKaHR0cDovL2xpc3RzLmZyZWVkZXNrdG9wLm9yZy9tYWlsbWFu L2xpc3RpbmZvL2ludGVsLWdmeAo= From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751657AbbEGVXZ (ORCPT ); Thu, 7 May 2015 17:23:25 -0400 Received: from iodev.co.uk ([82.211.30.53]:56037 "EHLO iodev.co.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750900AbbEGVXW (ORCPT ); Thu, 7 May 2015 17:23:22 -0400 Date: Thu, 7 May 2015 18:23:02 -0300 From: Ismael Luceno To: Chris Wilson Cc: Jani Nikula , Matt Roper , intel-gfx@lists.freedesktop.org, linux-kernel@vger.kernel.org Subject: Re: [Intel-gfx] [PATCH] drm/i915: Fix screen flickering on X Message-ID: <20150507182302.4534634d@pirotess> In-Reply-To: <20150507141827.GW22099@nuc-i3427.alporthouse.com> References: <1428792034-6131-1-git-send-email-ismael@iodev.co.uk> <20150423091532.GA21511@nuc-i3427.alporthouse.com> <87zj5g69al.fsf@intel.com> <20150507132715.GA22531@intel.com> <87r3qs5wtf.fsf@intel.com> <20150507141827.GW22099@nuc-i3427.alporthouse.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, 7 May 2015 15:18:27 +0100 Chris Wilson wrote: > On Thu, May 07, 2015 at 04:41:48PM +0300, Jani Nikula wrote: > > On Thu, 07 May 2015, Matt Roper wrote: > > > On Thu, May 07, 2015 at 12:12:18PM +0300, Jani Nikula wrote: > > >> On Thu, 23 Apr 2015, Chris Wilson > > >> wrote: > > >> > [cc'ing the authors] > > >> > > >> This has been posted earlier [1] and it has review to be > > >> addressed [2]. > > >> > > >> BR, > > >> Jani. > > > > > > I agree with Ander's response in [2]...we can't call > > > intel_update_watermarks() in the commit function because we're > > > under vblank evasion. We should already be flagging the > > > transaction as needing a watermark update in > > > intel_check_cursor_plane(), and that flag will be acted upon > > > immediately after the commit functions are done running, once > > > we've re-enabled interrupts. > > > > > > Note that our current codebase looks a bit different since we've > > > dropped intel_crtc->cursor_{width,height}. So the relevant check > > > in intel_check_cursor_plane() now looks like: > > > > > > if (plane->state->crtc_w != state->base.crtc_w) > > > intel_crtc->atomic.update_wm = true; > > > > > > Is there a bugzilla open on this issue with more details? > > > > Not that I know of. Ismael? > > > > Probably: > https://bugs.freedesktop.org/show_bug.cgi?id=88944 > https://bugzilla.redhat.com/show_bug.cgi?id=1199890 > are related. > -Chris > I am experiencing neither of those things.