Re: [PATCH v3] http: add support for specifying an SSL cipher list

[Lars Kellogg-Stedman <lars@redhat.com>]

[-- Attachment #1: Type: text/plain, Size: 904 bytes --]

On Thu, May 07, 2015 at 02:41:07PM -0400, Eric Sunshine wrote:
> Format multi-line comments like this:
> 
>     /*
>      * This is a multi-line
>      * comment.
>      */

Noted, thanks.

> > +       if (ssl_cipherlist != NULL && ssl_cipherlist[0] != '\0')
> 
> In git code, this is usually spelled:
> 
>     if (ssl_cipherlist && *ssl_cipherlist)

Huh.  At least in http.c, explicit checks against NULL seem more
common:

    if (ssl_cert != NULL)
    if (ssl_key != NULL)
    if (ssl_capath != NULL)

Etc.  I was just trying to make the new code look like the existing
code.  If nobody else has an opinion on this, I'm inclined to leave
the first clause as-is so that it matches and change the check for an
empty string.

-- 
Lars Kellogg-Stedman <lars@redhat.com> | larsks @ {freenode,twitter,github}
Cloud Engineering / OpenStack          | http://blog.oddbit.com/


[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 819 bytes --]