From: Marek Vasut <marex@denx.de>
To: Dmitry Torokhov <dmitry.torokhov@gmail.com>
Cc: linux-input@vger.kernel.org,
Vipul Kumar Samar <vipulkumar.samar@st.com>,
Viresh Kumar <viresh.kumar@linaro.org>
Subject: Re: [PATCH] Input: smtpe-ts: Use msecs_to_jiffies() instead of HZ
Date: Fri, 8 May 2015 03:51:51 +0200 [thread overview]
Message-ID: <201505080351.51784.marex@denx.de> (raw)
In-Reply-To: <20150506235928.GG5580@dtor-ws>
On Thursday, May 07, 2015 at 01:59:28 AM, Dmitry Torokhov wrote:
[...]
Hi!
> > Maybe I'm fixing two bugs here ? The problem I really had is that with
> > kernel HZ set to 250 and the original code, the work was scheduled and
> > executed too quickly, so my touchscreen was bouncing between pendown and
> > penup events back and forth, without doing any usaful work.
> >
> > I tried changing the code to HZ/5 instead of HZ/50 and that fixes my
> > issue as well.
> >
> > My impression is that using msec_to_jiffies() is clearer especially
> > if the code is to represent a constant delay.
>
> It is indeed clearer and I would not mind such conversion, we just need
> to adjust the comment why we do that.
>
> > But maybe I should then
> > document why I changed the duration (because the original one was too
> > short) ?
>
> Please make a separate patch for that with separate justification.
>
> Thanks!
Roger, will do, thank you!
Best regards,
Marek Vasut
prev parent reply other threads:[~2015-05-08 1:54 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-05-05 23:46 [PATCH] Input: smtpe-ts: Use msecs_to_jiffies() instead of HZ Marek Vasut
2015-05-06 0:01 ` Dmitry Torokhov
2015-05-06 0:36 ` Marek Vasut
2015-05-06 23:59 ` Dmitry Torokhov
2015-05-08 1:51 ` Marek Vasut [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201505080351.51784.marex@denx.de \
--to=marex@denx.de \
--cc=dmitry.torokhov@gmail.com \
--cc=linux-input@vger.kernel.org \
--cc=vipulkumar.samar@st.com \
--cc=viresh.kumar@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.