All of lore.kernel.org
 help / color / mirror / Atom feed
From: Baruch Siach <baruch@tkos.co.il>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 2/2] powerpc-utils: remove --without-librtas
Date: Fri, 8 May 2015 07:57:58 +0300	[thread overview]
Message-ID: <20150508045758.GH2183@tarshish> (raw)
In-Reply-To: <05714bb15869de4bead83eec7df5e9c9b0bd8fa7.1431059241.git.sam.bobroff@au1.ibm.com>

Hi Sam,

On Fri, May 08, 2015 at 02:27:49PM +1000, Sam Bobroff wrote:
> Now that librtas is available, remove --without-librtas and make the
> rtas-dependant functions available.
> 
> Signed-off-by: Sam Bobroff <sam.bobroff@au1.ibm.com>
> ---
>  package/powerpc-utils/Config.in        |    1 +
>  package/powerpc-utils/powerpc-utils.mk |    3 +--
>  2 files changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/package/powerpc-utils/Config.in b/package/powerpc-utils/Config.in
> index eded41e..a754899 100644
> --- a/package/powerpc-utils/Config.in
> +++ b/package/powerpc-utils/Config.in
> @@ -2,6 +2,7 @@ config BR2_PACKAGE_POWERPC_UTILS
>  	bool "powerpc-utils"
>  	depends on BR2_powerpc || BR2_powerpc64 || BR2_powerpc64le
>  	select BR2_PACKAGE_ZLIB
> +	select BR2_PACKAGE_LIBRTAS
>  	help
>  	  System utilities for PowerPC machines.
>  
> diff --git a/package/powerpc-utils/powerpc-utils.mk b/package/powerpc-utils/powerpc-utils.mk
> index 3b30458..3fb9e24 100644
> --- a/package/powerpc-utils/powerpc-utils.mk
> +++ b/package/powerpc-utils/powerpc-utils.mk
> @@ -6,11 +6,10 @@
>  
>  POWERPC_UTILS_VERSION = 1.2.24
>  POWERPC_UTILS_SITE = http://downloads.sourceforge.net/project/powerpc-utils/powerpc-utils
> -POWERPC_UTILS_DEPENDENCIES = zlib
> +POWERPC_UTILS_DEPENDENCIES = zlib librtas

Why not make librtas an optional dependency? Something like:

ifeq ($(BR2_PACKAGE_LIBRTAS),y)
POWERPC_UTILS_DEPENDENCIES += librtas
POWERPC_UTILS_CONF_OPTS = --with-librtas
else
POWERPC_UTILS_CONF_OPTS = --without-librtas
endif

>  POWERPC_UTILS_LICENSE = Common Public License Version 1.0
>  POWERPC_UTILS_LICENSE_FILES = COPYRIGHT
>  
> -POWERPC_UTILS_CONF_OPTS = --without-librtas
>  POWERPC_UTILS_CONF_ENV = \
>  	ax_cv_check_cflags___fstack_protector_all=$(if $(BR2_TOOLCHAIN_HAS_SSP),yes,no)

baruch

-- 
     http://baruch.siach.name/blog/                  ~. .~   Tk Open Systems
=}------------------------------------------------ooO--U--Ooo------------{=
   - baruch at tkos.co.il - tel: +972.2.679.5364, http://www.tkos.co.il -

  reply	other threads:[~2015-05-08  4:57 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-05-08  4:27 [Buildroot] [PATCH 0/2] Improve powerpc-utils with librtas Sam Bobroff
2015-05-08  4:27 ` [Buildroot] [PATCH 1/2] librtas: new package Sam Bobroff
2015-05-08  4:52   ` Baruch Siach
2015-05-08  5:37     ` Sam Bobroff
2015-05-08  7:42     ` Peter Korsgaard
2015-05-10 23:58       ` Sam Bobroff
2015-05-11  9:31       ` Thomas Petazzoni
2015-05-08  4:27 ` [Buildroot] [PATCH 2/2] powerpc-utils: remove --without-librtas Sam Bobroff
2015-05-08  4:57   ` Baruch Siach [this message]
2015-05-11  0:43     ` Sam Bobroff
2015-05-11  4:34       ` Baruch Siach
2015-05-11  5:53         ` Sam Bobroff
2015-05-11  6:00           ` Baruch Siach
2015-05-11  7:56             ` Peter Korsgaard

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20150508045758.GH2183@tarshish \
    --to=baruch@tkos.co.il \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.