From mboxrd@z Thu Jan  1 00:00:00 1970
From: Olaf Hering <olaf@aepfle.de>
Subject: Re: [PATCH v2 6/8] xenalyze: handle more events in
	sched_process
Date: Fri, 8 May 2015 08:18:06 +0200
Message-ID: <20150508061806.GB1737@aepfle.de>
References: <1430994944-20471-1-git-send-email-olaf@aepfle.de>
	<1430994944-20471-7-git-send-email-olaf@aepfle.de>
	<20150508053047.GG3848@zion.uk.xensource.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xen.org>
Content-Disposition: inline
In-Reply-To: <20150508053047.GG3848@zion.uk.xensource.com>
List-Unsubscribe: <http://lists.xen.org/cgi-bin/mailman/options/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xen.org>
List-Help: <mailto:xen-devel-request@lists.xen.org?subject=help>
List-Subscribe: <http://lists.xen.org/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=subscribe>
Sender: xen-devel-bounces@lists.xen.org
Errors-To: xen-devel-bounces@lists.xen.org
To: Wei Liu <wei.liu2@citrix.com>
Cc: George Dunlap <george.dunlap@eu.citrix.com>, Stefano Stabellini <stefano.stabellini@eu.citrix.com>, Ian Jackson <ian.jackson@eu.citrix.com>, Ian Campbell <ian.campbell@citrix.com>, xen-devel@lists.xen.org
List-Id: xen-devel@lists.xenproject.org

On Fri, May 08, Wei Liu wrote:

> On Thu, May 07, 2015 at 10:35:42AM +0000, Olaf Hering wrote:
> > +void sched_class(struct record_info *ri)
> > +{
> > +}
> Huh, this does nothing? Is it because this is only a stub (you haven't
> got around to implement it) or it is supposed to be like this?

Whatever sched_class() may be in that context, someone who is interested
in that output can fill it. Right now its just a stub.

Olaf

> >  void sched_process(struct pcpu_info *p)
> >  {
> >      struct record_info *ri = &p->ri;
> >  
> > -    if(ri->evt.sub == 0xf) {
> > +    if (ri->evt.sub == 1) {
> > +        sched_runstate_process(p);
> > +    } else if (ri->evt.sub == 2) {
> > +        sched_class(ri);