From: Kevin Wolf <kwolf@redhat.com>
To: qemu-block@nongnu.org
Cc: qemu-stable@nongnu.org, qemu-devel@nongnu.org, mreitz@redhat.com
Subject: Re: [Qemu-devel] [PATCH] qcow2: Flush pending discards before allocating cluster
Date: Fri, 8 May 2015 12:55:20 +0200 [thread overview]
Message-ID: <20150508105520.GH4318@noname.redhat.com> (raw)
In-Reply-To: <1430911774-19006-1-git-send-email-kwolf@redhat.com>
Am 06.05.2015 um 13:29 hat Kevin Wolf geschrieben:
> Before a freed cluster can be reused, pending discards for this cluster
> must be processed.
>
> The original assumption was that this was not a problem because discards
> are only cached during discard/write zeroes operations, which are
> synchronous so that no concurrent write requests can cause cluster
> allocations.
>
> However, the discard/write zeroes operation itself can allocate a new L2
> table (and it has to in order to put zero flags there), so make sure we
> can cope with the situation.
>
> This fixes https://bugs.launchpad.net/bugs/1349972.
>
> Signed-off-by: Kevin Wolf <kwolf@redhat.com>
Cc: qemu-stable@nongnu.org
Applied to my block branch.
Kevin
prev parent reply other threads:[~2015-05-08 10:55 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-05-06 11:29 [Qemu-devel] [PATCH] qcow2: Flush pending discards before allocating cluster Kevin Wolf
2015-05-06 13:31 ` Max Reitz
2015-05-08 10:55 ` Kevin Wolf [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150508105520.GH4318@noname.redhat.com \
--to=kwolf@redhat.com \
--cc=mreitz@redhat.com \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=qemu-stable@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.