From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: linux-kernel@vger.kernel.org
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
stable@vger.kernel.org,
"Gerd v. Egidy" <gerd.von.egidy@intra2net.com>,
Herbert Xu <herbert@gondor.apana.org.au>,
"David S. Miller" <davem@davemloft.net>
Subject: [PATCH 3.19 2/7] route: Use ipv4_mtu instead of raw rt_pmtu
Date: Fri, 8 May 2015 13:12:21 +0200 [thread overview]
Message-ID: <20150508111055.127701510@linuxfoundation.org> (raw)
In-Reply-To: <20150508111054.717693099@linuxfoundation.org>
3.19-stable review patch. If anyone has any objections, please let me know.
------------------
From: Herbert Xu <herbert@gondor.apana.org.au>
[ Upstream commit cb6ccf09d6b94bec4def1ac5cf4678d12b216474 ]
The commit 3cdaa5be9e81a914e633a6be7b7d2ef75b528562 ("ipv4: Don't
increase PMTU with Datagram Too Big message") broke PMTU in cases
where the rt_pmtu value has expired but is smaller than the new
PMTU value.
This obsolete rt_pmtu then prevents the new PMTU value from being
installed.
Fixes: 3cdaa5be9e81 ("ipv4: Don't increase PMTU with Datagram Too Big message")
Reported-by: Gerd v. Egidy <gerd.von.egidy@intra2net.com>
Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>
Signed-off-by: David S. Miller <davem@davemloft.net>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
---
net/ipv4/route.c | 5 +----
1 file changed, 1 insertion(+), 4 deletions(-)
--- a/net/ipv4/route.c
+++ b/net/ipv4/route.c
@@ -963,10 +963,7 @@ static void __ip_rt_update_pmtu(struct r
if (dst_metric_locked(dst, RTAX_MTU))
return;
- if (dst->dev->mtu < mtu)
- return;
-
- if (rt->rt_pmtu && rt->rt_pmtu < mtu)
+ if (ipv4_mtu(dst) < mtu)
return;
if (mtu < ip_rt_min_pmtu)
next prev parent reply other threads:[~2015-05-08 11:12 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-05-08 11:12 [PATCH 3.19 0/7] 3.19.8-stable review Greg Kroah-Hartman
2015-05-08 11:12 ` [PATCH 3.19 1/7] bpf: fix 64-bit divide Greg Kroah-Hartman
2015-05-08 11:12 ` Greg Kroah-Hartman [this message]
2015-05-08 11:12 ` [PATCH 3.19 3/7] mlx4: Fix tx ring affinity_mask creation Greg Kroah-Hartman
2015-05-08 11:12 ` [PATCH 3.19 4/7] cxgb4: Fix MC1 memory offset calculation Greg Kroah-Hartman
2015-05-08 11:12 ` [PATCH 3.19 5/7] net/mlx4_en: Schedule napi when RX buffers allocation fails Greg Kroah-Hartman
2015-05-08 11:12 ` [PATCH 3.19 6/7] ipv4: Missing sk_nulls_node_init() in ping_unhash() Greg Kroah-Hartman
2015-05-08 11:12 ` [PATCH 3.19 7/7] clk: at91: usb: fix determine_rate prototype Greg Kroah-Hartman
2015-05-08 15:14 ` [PATCH 3.19 0/7] 3.19.8-stable review Shuah Khan
2015-05-08 20:45 ` Greg Kroah-Hartman
2015-05-08 18:51 ` Guenter Roeck
2015-05-08 20:45 ` Greg Kroah-Hartman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150508111055.127701510@linuxfoundation.org \
--to=gregkh@linuxfoundation.org \
--cc=davem@davemloft.net \
--cc=gerd.von.egidy@intra2net.com \
--cc=herbert@gondor.apana.org.au \
--cc=linux-kernel@vger.kernel.org \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.