From mboxrd@z Thu Jan 1 00:00:00 1970 From: Chen Baozi Subject: Re: [PATCH] xen/arm: gic-v3: Implement correctly the callback send_SGI Date: Sat, 9 May 2015 21:13:28 +0800 Message-ID: <20150509131328.GA12647@cbz-thinkpad> References: <1431104472-23616-1-git-send-email-julien.grall@citrix.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mail6.bemta5.messagelabs.com ([195.245.231.135]) by lists.xen.org with esmtp (Exim 4.72) (envelope-from ) id 1Yr4Yv-0008TO-VD for xen-devel@lists.xenproject.org; Sat, 09 May 2015 13:13:02 +0000 Content-Disposition: inline In-Reply-To: <1431104472-23616-1-git-send-email-julien.grall@citrix.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Julien Grall Cc: xen-devel@lists.xenproject.org, tim@xen.org, ian.campbell@citrix.com, stefano.stabellini@citrix.com List-Id: xen-devel@lists.xenproject.org On Fri, May 08, 2015 at 06:01:12PM +0100, Julien Grall wrote: > Currently, the GICv3 driver is only able to send an SGI when the cpumask > is provided. Although with the modes SGI_TARGET_OTHERS and SGI_TARGET_SELF, > no cpumask is provided. Any usage of those modes will crash the hypersivor. > > Rename gicv3_send_sgi to gicv3_send_sgi_list and implement the > different modes: > - SGI_TARGET_OTHERS: Set the Interrupt Routing Mode (bit 40) to 1 > (see Table 4 on Section 4.2.6 PRD03-GENC-010745 24.0) > - SGI_TARGET_SELF: Unlike GICv2, the GICv3 SGI registers don't > provide a specific field. So use gicv3_send_sgi_list and pass > the cpumask of the current CPU > - SGI_TARGET_LIST: Directly call gicv3_send_sgi_list with the given > cpumask > > Also, use WRITE_SYSREG64 to write into ICC_SGI1R_EL1 the access is > 64-bit on all the architectures. > > Reported-by: Chen Baozi > Signed-off-by: Julien Grall Tested-by: Chen Baozi Cheers, Baozi.