From mboxrd@z Thu Jan  1 00:00:00 1970
From: hch@lst.de (Christoph Hellwig)
Date: Sat, 9 May 2015 17:53:22 +0200
Subject: [PATCH 04/11] nvme: remove the unused dma_addr_t arguments to
 nvme_{get, set}_features
In-Reply-To: <20150508190351.GM4003@linux.intel.com>
References: <1431100836-28112-1-git-send-email-hch@lst.de>
 <1431100836-28112-5-git-send-email-hch@lst.de>
 <20150508190351.GM4003@linux.intel.com>
Message-ID: <20150509155322.GA32628@lst.de>

On Fri, May 08, 2015@03:03:51PM -0400, Matthew Wilcox wrote:
> >  int nvme_get_features(struct nvme_dev *dev, unsigned fid, unsigned nsid,
> > -					dma_addr_t dma_addr, u32 *result)
> > +		u32 *result)
> >  {
> >  	struct nvme_command c;
> >  
> >  	memset(&c, 0, sizeof(c));
> >  	c.features.opcode = nvme_admin_get_features;
> >  	c.features.nsid = cpu_to_le32(nsid);
> > -	c.features.prp1 = cpu_to_le64(dma_addr);
> >  	c.features.fid = cpu_to_le32(fid);
> >  
> >  	return __nvme_submit_sync_cmd(dev->admin_q, &c, result, 0);
> 
> Wait, what?  The PRP1 field is used for LBA Range Type and Autonomous
> Power State Transitions.

None of which is, or ever was issued by the Linux driver.