Re: [PATCH 2/3] perf report: Force tty output if -T/--thread option is given

[Arnaldo Carvalho de Melo <acme@kernel.org>]

Em Sun, May 10, 2015 at 12:19:43AM +0900, Namhyung Kim escreveu:
> The -T/--thread option is supported only on --stdio mode (at least for
> now).  So enforce the tty output if the option was requested.
> 
> Signed-off-by: Namhyung Kim <namhyung@kernel.org>
> ---
>  tools/perf/builtin-report.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/tools/perf/builtin-report.c b/tools/perf/builtin-report.c
> index b63aeda719be..ee541ad555f2 100644
> --- a/tools/perf/builtin-report.c
> +++ b/tools/perf/builtin-report.c
> @@ -803,8 +803,8 @@ repeat:
>  		goto error;
>  	}
>  
> -	/* Force tty output for header output. */
> -	if (report.header || report.header_only)
> +	/* Force tty output for header output and per-thread stat. */
> +	if (report.header || report.header_only || report.show_threads)
>  		use_browser = 0;

I will apply, but please consider sending a followup patch to emit a
warning for the cases when --tui or --gtk is explicitely passed, i.e.
emit a warning saying that that is not possible.

- Arnaldo

>  
>  	if (strcmp(input_name, "-") != 0)
> -- 
> 2.3.7