From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Chris Metcalf <cmetcalf@ezchip.com>
Cc: linuxppc-dev@lists.ozlabs.org, Jiri Slaby <jslaby@suse.cz>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] drivers/tty/hvc/hvc_tile.c: properly return -EAGAIN
Date: Sun, 10 May 2015 19:18:44 +0200 [thread overview]
Message-ID: <20150510171844.GA20715@kroah.com> (raw)
In-Reply-To: <1430845888-22164-1-git-send-email-cmetcalf@ezchip.com>
On Tue, May 05, 2015 at 01:11:28PM -0400, Chris Metcalf wrote:
> We were returning zero if no bytes could be written to the Tilera
> hypervisor console device, but this causes the output to be truncated.
> By returning -EAGAIN the tty hvc driver will come back and try again,
> which gives the semantics we want, and avoids dropping console output.
>
> Signed-off-by: Chris Metcalf <cmetcalf@ezchip.com>
> ---
> I have queued this in the tile tree as a tile-specific device, but
> if someone would prefer to pick it up for a tty or tty/hvc tree,
> that's fine too; just let me know.
Sounds good to me, feel free to add:
Acked-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
if you want it :)
WARNING: multiple messages have this Message-ID (diff)
From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Chris Metcalf <cmetcalf@ezchip.com>
Cc: Jiri Slaby <jslaby@suse.cz>,
linuxppc-dev@lists.ozlabs.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] drivers/tty/hvc/hvc_tile.c: properly return -EAGAIN
Date: Sun, 10 May 2015 19:18:44 +0200 [thread overview]
Message-ID: <20150510171844.GA20715@kroah.com> (raw)
In-Reply-To: <1430845888-22164-1-git-send-email-cmetcalf@ezchip.com>
On Tue, May 05, 2015 at 01:11:28PM -0400, Chris Metcalf wrote:
> We were returning zero if no bytes could be written to the Tilera
> hypervisor console device, but this causes the output to be truncated.
> By returning -EAGAIN the tty hvc driver will come back and try again,
> which gives the semantics we want, and avoids dropping console output.
>
> Signed-off-by: Chris Metcalf <cmetcalf@ezchip.com>
> ---
> I have queued this in the tile tree as a tile-specific device, but
> if someone would prefer to pick it up for a tty or tty/hvc tree,
> that's fine too; just let me know.
Sounds good to me, feel free to add:
Acked-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
if you want it :)
next prev parent reply other threads:[~2015-05-10 21:01 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-05-05 17:11 [PATCH] drivers/tty/hvc/hvc_tile.c: properly return -EAGAIN Chris Metcalf
2015-05-10 17:18 ` Greg Kroah-Hartman [this message]
2015-05-10 17:18 ` Greg Kroah-Hartman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150510171844.GA20715@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=cmetcalf@ezchip.com \
--cc=jslaby@suse.cz \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.