From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail.linuxfoundation.org (mail.linuxfoundation.org [140.211.169.12]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id DC3A21A0017 for ; Mon, 11 May 2015 07:01:11 +1000 (AEST) Date: Sun, 10 May 2015 19:18:44 +0200 From: Greg Kroah-Hartman To: Chris Metcalf Subject: Re: [PATCH] drivers/tty/hvc/hvc_tile.c: properly return -EAGAIN Message-ID: <20150510171844.GA20715@kroah.com> References: <1430845888-22164-1-git-send-email-cmetcalf@ezchip.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii In-Reply-To: <1430845888-22164-1-git-send-email-cmetcalf@ezchip.com> Cc: linuxppc-dev@lists.ozlabs.org, Jiri Slaby , linux-kernel@vger.kernel.org List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , On Tue, May 05, 2015 at 01:11:28PM -0400, Chris Metcalf wrote: > We were returning zero if no bytes could be written to the Tilera > hypervisor console device, but this causes the output to be truncated. > By returning -EAGAIN the tty hvc driver will come back and try again, > which gives the semantics we want, and avoids dropping console output. > > Signed-off-by: Chris Metcalf > --- > I have queued this in the tile tree as a tile-specific device, but > if someone would prefer to pick it up for a tty or tty/hvc tree, > that's fine too; just let me know. Sounds good to me, feel free to add: Acked-by: Greg Kroah-Hartman if you want it :) From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752275AbbEJVBT (ORCPT ); Sun, 10 May 2015 17:01:19 -0400 Received: from mail.linuxfoundation.org ([140.211.169.12]:50387 "EHLO mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752140AbbEJVBK (ORCPT ); Sun, 10 May 2015 17:01:10 -0400 Date: Sun, 10 May 2015 19:18:44 +0200 From: Greg Kroah-Hartman To: Chris Metcalf Cc: Jiri Slaby , linuxppc-dev@lists.ozlabs.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] drivers/tty/hvc/hvc_tile.c: properly return -EAGAIN Message-ID: <20150510171844.GA20715@kroah.com> References: <1430845888-22164-1-git-send-email-cmetcalf@ezchip.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1430845888-22164-1-git-send-email-cmetcalf@ezchip.com> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, May 05, 2015 at 01:11:28PM -0400, Chris Metcalf wrote: > We were returning zero if no bytes could be written to the Tilera > hypervisor console device, but this causes the output to be truncated. > By returning -EAGAIN the tty hvc driver will come back and try again, > which gives the semantics we want, and avoids dropping console output. > > Signed-off-by: Chris Metcalf > --- > I have queued this in the tile tree as a tile-specific device, but > if someone would prefer to pick it up for a tty or tty/hvc tree, > that's fine too; just let me know. Sounds good to me, feel free to add: Acked-by: Greg Kroah-Hartman if you want it :)