All of lore.kernel.org
 help / color / mirror / Atom feed
From: Marek Vasut <marex@denx.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH v5 12/15] usb: ohci: Skip unnecessary mdelay(1) calls in various places
Date: Sun, 10 May 2015 18:12:07 +0200	[thread overview]
Message-ID: <201505101812.07740.marex@denx.de> (raw)
In-Reply-To: <1431259827-8109-13-git-send-email-hdegoede@redhat.com>

On Sunday, May 10, 2015 at 02:10:24 PM, Hans de Goede wrote:
> For some reason the ohci code is full with:
> 
>  #ifdef DEBUG
> 		pkt_print(...)
>  #else
> 		mdelay(1);
>  #endif
> 
> AFAICT there is no reason for the mdelay(1) calls. This commit disables
> them when building the ohci code for new driver-model using boards. It
> leaves the mdelay(1) calls in place when building for older boards, so as
> to avoid causing any regressions there.
> 
> Signed-off-by: Hans de Goede <hdegoede@redhat.com>

Maybe those debug prints can be abstracted into one single function instead
of having the code littered with #ifdef-else-endif , but let's do that later
or in another patch.

Acked-by: Marek Vasut <marex@denx.de>
[...]
Best regards,
Marek Vasut

  reply	other threads:[~2015-05-10 16:12 UTC|newest]

Thread overview: 45+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-05-10 12:10 [U-Boot] [PATCH v5 00/15] usb: ohci dm support & add sunxi ehci + ohci support Hans de Goede
2015-05-10 12:10 ` [U-Boot] [PATCH v5 01/15] usb: Fix handover of full-speed devices from ehci to companion Hans de Goede
2015-05-10 16:12   ` Marek Vasut
2015-05-11 22:36     ` Simon Glass
2015-05-10 12:10 ` [U-Boot] [PATCH v5 02/15] usb: usb_control_msg() propagate controller error code Hans de Goede
2015-05-10 16:13   ` Marek Vasut
2015-05-11 22:36     ` Simon Glass
2015-05-10 12:10 ` [U-Boot] [PATCH v5 03/15] usb: legacy_hub_port_reset() check and propagate usb_set_port_feature() errors Hans de Goede
2015-05-10 16:13   ` Marek Vasut
2015-05-11 22:36     ` Simon Glass
2015-05-10 12:10 ` [U-Boot] [PATCH v5 04/15] usb: Stop reset procedure when a dev is handed over to a companion hcd Hans de Goede
2015-05-10 16:13   ` Marek Vasut
2015-05-11 22:37     ` Simon Glass
2015-05-10 12:10 ` [U-Boot] [PATCH v5 05/15] dm: usb: Prefix ehci interrupt-queue functions with _ehci_ Hans de Goede
2015-05-10 21:58   ` Simon Glass
2015-05-11 18:27     ` Hans de Goede
2015-05-10 12:10 ` [U-Boot] [PATCH v5 06/15] dm: usb: Add support for interrupt queues to the dm usb code Hans de Goede
2015-05-11 22:37   ` Simon Glass
2015-05-10 12:10 ` [U-Boot] [PATCH v5 07/15] dm: usb: Move printing of usb scan status to usb_scan_bus() Hans de Goede
2015-05-11 22:37   ` Simon Glass
2015-05-10 12:10 ` [U-Boot] [PATCH v5 08/15] dm: usb: Add support for companion controllers Hans de Goede
2015-05-11 22:33   ` Simon Glass
2015-05-11 22:37     ` Simon Glass
2015-05-10 12:10 ` [U-Boot] [PATCH v5 09/15] dm: usb: Do not scan companion buses if no devices where handed over Hans de Goede
2015-05-11 22:33   ` Simon Glass
2015-05-11 22:37     ` Simon Glass
2015-05-10 12:10 ` [U-Boot] [PATCH v5 10/15] usb: ohci: Do not resubmit and leak urbs for interrupt packets Hans de Goede
2015-05-11 22:37   ` Simon Glass
2015-05-10 12:10 ` [U-Boot] [PATCH v5 11/15] usb: ohci: Remove unnecessary delays from hc_start and power power-on paths Hans de Goede
2015-05-10 16:11   ` Marek Vasut
2015-05-11 22:37     ` Simon Glass
2015-05-10 12:10 ` [U-Boot] [PATCH v5 12/15] usb: ohci: Skip unnecessary mdelay(1) calls in various places Hans de Goede
2015-05-10 16:12   ` Marek Vasut [this message]
2015-05-11 22:37     ` Simon Glass
2015-05-10 12:10 ` [U-Boot] [PATCH v5 13/15] usb: ohci: Add dm support Hans de Goede
2015-05-11 22:37   ` Simon Glass
2015-05-10 12:10 ` [U-Boot] [PATCH v5 14/15] sunxi: ehci: Convert to the driver-model Hans de Goede
2015-05-10 12:22   ` Ian Campbell
2015-05-11 22:37     ` Simon Glass
2015-05-10 12:10 ` [U-Boot] [PATCH v5 15/15] sunxi: ohci: Add ohci usb host controller support Hans de Goede
2015-05-11 22:37   ` Simon Glass
2015-05-12  7:23     ` Hans de Goede
2015-05-12 22:39       ` Simon Glass
2015-05-13 12:40         ` Hans de Goede
2015-05-13 19:55           ` Simon Glass

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=201505101812.07740.marex@denx.de \
    --to=marex@denx.de \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.