From mboxrd@z Thu Jan 1 00:00:00 1970 From: patrik.r.jakobsson@gmail.com Subject: Re: [PATCH] gma500:Remove functions that are now deprecated and move to the newer functions in drm_dp_helper.c Date: Sun, 10 May 2015 21:45:36 +0200 Message-ID: <20150510194536.GA25199@patrik-arch.example2.org> References: <1430778546-23468-1-git-send-email-xerofoify@gmail.com> <5548DEF3.5040204@gmail.com> <20150510170435.GA3108@patrik-arch.example2.org> <554F99DE.3020608@gmail.com> <20150510183540.GA10437@patrik-arch.example2.org> <554FA628.6030102@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mail-wg0-f51.google.com (mail-wg0-f51.google.com [74.125.82.51]) by gabe.freedesktop.org (Postfix) with ESMTP id A750F6E052 for ; Sun, 10 May 2015 12:46:01 -0700 (PDT) Received: by wgiu9 with SMTP id u9so111316785wgi.3 for ; Sun, 10 May 2015 12:46:00 -0700 (PDT) Content-Disposition: inline In-Reply-To: <554FA628.6030102@gmail.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: nick Cc: linux-kernel , dri-devel List-Id: dri-devel@lists.freedesktop.org T24gU3VuLCBNYXkgMTAsIDIwMTUgYXQgMDI6NDA6NDBQTSAtMDQwMCwgbmljayB3cm90ZToKPiAK PiAKPiBPbiAyMDE1LTA1LTEwIDAyOjM1IFBNLCBwYXRyaWsuci5qYWtvYnNzb25AZ21haWwuY29t IHdyb3RlOgo+ID4gT24gU3VuLCBNYXkgMTAsIDIwMTUgYXQgMDE6NDg6MTRQTSAtMDQwMCwgbmlj ayB3cm90ZToKPiA+Pgo+ID4+Cj4gPj4gT24gMjAxNS0wNS0xMCAwMTowNCBQTSwgcGF0cmlrLnIu amFrb2Jzc29uQGdtYWlsLmNvbSB3cm90ZToKPiA+Pj4gT24gVHVlLCBNYXkgMDUsIDIwMTUgYXQg MTE6MTc6MDdBTSAtMDQwMCwgbmljayB3cm90ZToKPiA+Pj4+Cj4gPj4+Pgo+ID4+Pj4gT24gMjAx NS0wNS0wNSAwOTowNiBBTSwgUGF0cmlrIEpha29ic3NvbiB3cm90ZToKPiA+Pj4+PiBPbiBUdWUs IE1heSA1LCAyMDE1IGF0IDEyOjI5IEFNLCBOaWNob2xhcyBLcmF1c2UgPHhlcm9mb2lmeUBnbWFp bC5jb20+IHdyb3RlOgo+ID4+Pj4+PiBUaGlzIHJlbW92ZXMgdGhlIGRlcHJlY2F0ZWQgZnVuY3Rp b25zLGkyY19kcF9hdXhfYWRkX2J1cyBhbmQKPiA+Pj4+Pj4gaTJjX2RwX2F1eF9wcmVwYXJlX2J1 cyBhbmQgdGhlIG9ubHkgY2FsbCBpbiB0aGUgZnVuY3Rpb24sCj4gPj4+Pj4+IGNkdl9pbnRlbF9k cF9pMmNfaW5pdCB0byBpMmNfZHBfYXV4X2FkZF9idXMgcmVzcGVjdGZ1bGx5Lgo+ID4+Pj4+PiBU aGUgY2FsbCBhbmQgdXNlIG9mIHRoZXNlIGZ1bmN0aW9ucyBpcyBub3cgcmVwbGFjZWQgYWxvbmdz aWRlCj4gPj4+Pj4+IHRoZSByZW1vdmFsIG9mIHNldHRpbmcgb3RoZXIgdmFsdWVzIGluIHRoZSBm dW5jdGlvbixjZHZfaW50ZWxfZHBfaTJjX2luaXQKPiA+Pj4+Pj4gdG8gdXNlIHRoZSBoZWxwZXIg ZnVuY3Rpb24sIGRybV9kcF9hdXhfcmVnaXN0ZXIgdGhhdCBjYW4gaGFuZGxlIGFsbCB0aGlzCj4g Pj4+Pj4+IHdvcmsgaW50ZXJuYWxseS4KPiA+Pj4+Pgo+ID4+Pj4+IFlvdSBuZWVkIHRvIGZpbGwg aW4gdGhlIGRybV9kcF9hdXggc3RydWN0dXJlIGFuZCBpbXBsZW1lbnQgYSBwcm9wZXIgdHJhbnNm ZXIKPiA+Pj4+PiBmdW5jdGlvbi4gVGhpcyBwYXRjaCB3b3VsZCBvbmx5IGJyZWFrIHRoaW5ncy4g QnV0IHRoZSBjZHYgZHAgb3V0cHV0IGlzIGFscmVhZHkKPiA+Pj4+PiBicm9rZW4gb24gbXkgc3lz dGVtIHNvIGl0IG5lZWRzIGZpeGluZyBmaXJzdC4KPiA+Pj4+Pgo+ID4+Pj4+IC1QYXRyaWsKPiA+ Pj4+Pgo+ID4+Pj4gUGF0cmlrLAo+ID4+Pj4gRHVlIHRvIG1lIG5vdCBiZWluZyBhbiBleHBlcnQg aW4gdGhpcyBhcmVhIG9mIHRoZSBrZXJuZWwgSSBiYXNlZCBteSB3b3JrIG9mZiB0aGUgc2ltaWxh ciBmdW5jdGlvbiwKPiA+Pj4+IGludGVsX2RwX2F1eF9pbml0IGZvciBpOTE1LiBJIHdhcyB1bnN1 cmUgb2Ygd2hpY2ggaGVscGVyIGZ1bmN0aW9ucyBmb3IgaTkxNSBuZWVkIHRvIGJlIHdyaXR0ZW4g Cj4gPj4+PiBkaWZmZXJlbnRseSBmb3IgZ21hNTAwIGJhc2VkIHNvbHV0aW9ucyBhcyBJIGRvbid0 IGtub3duIHRoZSBkaWZmZXJlbmNlcyBiZXR3ZWVuIHRoZXNlIHR3byBpbiB0aGUKPiA+Pj4+IGdy YXBoaWNzIHNwZWNzIGFyZWEuCj4gPj4+PiBUaGFua3MsCj4gPj4+PiBOaWNrCj4gPj4+Cj4gPj4+ IEhpIE5pY2sKPiA+Pj4gWW91IGFyZSBfcmVxdWlyZWRfIHRvIGtub3cgd2hhdCB5b3VyIHBhdGNo ZXMgYXJlIGRvaW5nIGJlZm9yZSBzZW5kaW5nIHRoZW0uIElmCj4gPj4+IHlvdSBkb24ndCB0ZXN0 IHlvdXIgY29kZSBhbmQgZG9uJ3Qga25vdyB3aGF0IGl0J3MgZG9pbmcgdGhlbiB3ZSB3aWxsIG5v dCBhY2NlcHQKPiA+Pj4gaXQuIFlvdSdyZSBleHBlY3RlZCB0byByZWFkIHRoZSBhdmFpbGFibGUg ZG9jdW1lbnRhdGlvbiBhbmQgcmVsZXZhbnQgbGl0ZXJhdHVyZQo+ID4+PiBiZWZvcmUgc2VuZGlu ZyBwYXRjaGVzIGFuZCBhc2tpbmcgcXVlc3Rpb25zLiBPdGhlcndpc2Ugc29tZW9uZSBlbHNlIGlz IGRvaW5nIHRoZQo+ID4+PiB3b3JrIGZvciB5b3UsIHdoaWNoIEkgYXNzdW1lIGlzIG5vdCB0aGUg cHVycG9zZSBvZiB5b3UgcGF0Y2ggc3VibWlzc2lvbi4KPiA+Pj4KPiA+Pj4gVGhhbmtzCj4gPj4+ IFBhdHJpawo+IAo+ID4+IFBhdHJpaywKPiA+PiBTb3JyeSBhYm91dCB0aGF0IG15IHF1ZXN0aW9u IGlzIGFjdHVhbGx5IHRoaXMgLEkgYW0gdW5zdXJlIG9mIHdoYXQgcGFydHMgb2YgdGhlIGZ1bmN0 aW9uLGludGVsX2RwX2F1eF9pbml0Cj4gPj4gbmVlZCB0byBiZSBwb3J0ZWQgZm9yIHRoZSBnbWE1 MDAgZ3B1IGRyaXZlci4gRnVydGhlcm1vcmUgSSB3aWxsIGxpc3Qgd2hhdCBwYXJ0cyBmb3IgY2Vy dGFpbiBJIGtub3duIG5lZWQgdG8KPiA+PiBiZSBwb3J0ZWQgb3ZlciBhYm92ZSB0aGUgbGluZXMg b2YgY29kZSBpbiB0aGUgZnVuY3Rpb24gZGVmaW5pdGlvbiBJIGhhdmUgcGFzdGVkIGJlbG93LiBQ bGVhc2UgbGV0IG1lIGtub3duCj4gPj4gaWYgdGhlcmUgYXJlIGFueSBhcmVhcyBJIGFtIG1pc3Np bmcuIFRoaXMgaXMgbW9yZSBqdXN0IG9mIGEgZG91YmxlIGNoZWNrIHRvIG1ha2Ugc3VyZSBJIGRv bid0IG1pc3Mgc29tZXRoaW5nCj4gPj4gY3JpdGljYWw6KShJIGxpa2UgdG8gdmVyaWZ5IHNvbWV0 aGluZyBiZWZvcmUgSSBjb2RlIGl0KS4gCj4gPj4gU29ycnkgZm9yIHRoZSBtaXN1bmRlcnN0YW5k aW5nLAo+ID4gCj4gPiBZb3UgY2FuIGZpZ3VyZSB0aGlzIG91dCBieSByZWFkaW5nIHRoZSBkcm0g ZHAgaGVscGVycyBkb2NzIGFuZCBsb29raW5nIGF0Cj4gPiBjZHZfaW50ZWxfZHAuYy4gRm9yIGlu c3RhbmNlLCBpbiBnbWE1MDAgd2UgaW5pdGlhbGl6ZSBEUF9CIGFuZCBEUF9DLgo+ID4gCj4gPiBN eSBwb2ludCBpcyB0aGF0IF95b3VfIG5lZWQgdG8gcmVhZCB0aGUgY29kZSBhbmQgdW5kZXJzdGFu ZCBpdC4gSSBjYW5ub3QgaGVscAo+ID4geW91IHdpdGggdGhhdC4KPiA+IAo+ID4gQnV0IGFzIEkg c2FpZCBpbiBteSBmaXJzdCByZXBseS4gRFAgb24gQ0RWIGlzIGJyb2tlbiAoYXQgbGVhc3Qgb24g bXkgbWFjaGluZSkgc28KPiA+IHRoYXQgc2hvdWxkIGJlIGZpeGVkIGZpcnN0Lgo+ID4gCj4gPiBD aGVlcnMKPiA+IFBhdHJpawo+ID4gCj4gUGF0cmlrLAo+IFNvcnJ5IGFib3V0IHRoYXQgOikuIFlv dXIgcmlnaHQgaXQncyBhIGJhZCBoYWJpdCA6KCwgSSB3aWxsIHN0YXJ0IHdvcmtpbmcgb24gaXQu Cj4gRnVydGhlciBtb3JlIGJ5ICJicm9rZW4iIHlvdSBtZWFuIHdoYXQuIFRoaXMgaXMgdmVyeSB2 YWd1ZSBhbmQgaWYgeW91IHdvdWxkIGxpa2UKPiBzb21lIGhlbHAgd2l0aCBpdCwgSSBhbSB3aWxs aW5nIHRvIGlmIHlvdSBjYW4gZ2l2ZSBtZSBhIGRldGFpbGVkIHJlc3BvbnNlIG9mIHdoYXQKPiBp cyB3cm9uZy4KPiBOaWNrCgpWYWd1ZT8gQm90aCBEUCBhbmQgTFZEUyBkaXNwbGF5cyBhcmUgYmxh Y2sgYWZ0ZXIgYm9vdCB3aGVuIERQIGlzIGNvbm5lY3RlZC4gV2hhdAphZGRpdGlvbmFsIGluZm9y bWF0aW9uIGRvIHlvdSBuZWVkPwoKPiA+PiBOaWNrCj4gPj4gc3RhdGljIHZvaWQKPiA+PiAxMDAy IGludGVsX2RwX2F1eF9pbml0KHN0cnVjdCBpbnRlbF9kcCAqaW50ZWxfZHAsIHN0cnVjdCBpbnRl bF9jb25uZWN0b3IgKmNvbm5lY3RvcikKPiA+PiAxMDAzIHsKPiA+PiAJLypVbnN1cmUgYWJvdXQg aG93IHRvIHBvcnQgdGhpcyBvdmVyIHRoZSBmdW5jdGlvbnMgaW4gdGhlc2UgbGluZXMgIGEuay5h IGFueSBkaWZmZXJlbmNlcyBiZXR3ZWVuIGk5MTUgYW5kIGdtYTUwMCByZWxhdGVkIHRvIHRoZXNl IGZ1bmN0aW9ucz8KPiA+PiAJSSByZWFkIHRocm91Z2ggdGhlc2UgZnVuY3Rpb24gZGVmaW5pdGlv bnMgYnV0IHdvdWxkIGxpa2UgdG8gZG91YmxlIGNoZWNrKi8KPiA+PiAxMDA0ICAgICAgICAgc3Ry dWN0IGRybV9kZXZpY2UgKmRldiA9IGludGVsX2RwX3RvX2RldihpbnRlbF9kcCk7Cj4gPj4gMTAw NSAgICAgICAgIHN0cnVjdCBpbnRlbF9kaWdpdGFsX3BvcnQgKmludGVsX2RpZ19wb3J0ID0gZHBf dG9fZGlnX3BvcnQoaW50ZWxfZHApOwo+ID4+IDEwMDYgICAgICAgICBlbnVtIHBvcnQgcG9ydCA9 IGludGVsX2RpZ19wb3J0LT5wb3J0Owo+ID4+IC8qUG9ydCB0aGVzZSBsaW5lcyovCj4gPj4gMTAw NyAgICAgICAgIGNvbnN0IGNoYXIgKm5hbWUgPSBOVUxMOwo+ID4+IDEwMDggICAgICAgICBpbnQg cmV0Owo+ID4+IC8qUG9ydCB0aGlzIHN3aXRjaCBzdGF0ZW1lbnQgKi8KPiA+PiAxMDA5IAo+ID4+ IDEwMTAgICAgICAgICBzd2l0Y2ggKHBvcnQpIHsKPiA+PiAxMDExICAgICAgICAgY2FzZSBQT1JU X0E6Cj4gPj4gMTAxMiAgICAgICAgICAgICAgICAgaW50ZWxfZHAtPmF1eF9jaF9jdGxfcmVnID0g RFBBX0FVWF9DSF9DVEw7Cj4gPj4gMTAxMyAgICAgICAgICAgICAgICAgbmFtZSA9ICJEUEREQy1B IjsKPiA+PiAxMDE0ICAgICAgICAgICAgICAgICBicmVhazsKPiA+PiAxMDE1ICAgICAgICAgY2Fz ZSBQT1JUX0I6Cj4gPj4gMTAxNiAgICAgICAgICAgICAgICAgaW50ZWxfZHAtPmF1eF9jaF9jdGxf cmVnID0gUENIX0RQQl9BVVhfQ0hfQ1RMOwo+ID4+IDEwMTcgICAgICAgICAgICAgICAgIG5hbWUg PSAiRFBEREMtQiI7Cj4gPj4gMTAxOCAgICAgICAgICAgICAgICAgYnJlYWs7Cj4gPj4gMTAxOSAg ICAgICAgIGNhc2UgUE9SVF9DOgo+ID4+IDEwMjAgICAgICAgICAgICAgICAgIGludGVsX2RwLT5h dXhfY2hfY3RsX3JlZyA9IFBDSF9EUENfQVVYX0NIX0NUTDsKPiA+PiAxMDIxICAgICAgICAgICAg ICAgICBuYW1lID0gIkRQRERDLUMiOwo+ID4+IDEwMjIgICAgICAgICAgICAgICAgIGJyZWFrOwo+ ID4+IDEwMjMgICAgICAgICBjYXNlIFBPUlRfRDoKPiA+PiAxMDI0ICAgICAgICAgICAgICAgICBp bnRlbF9kcC0+YXV4X2NoX2N0bF9yZWcgPSBQQ0hfRFBEX0FVWF9DSF9DVEw7Cj4gPj4gMTAyNSAg ICAgICAgICAgICAgICAgbmFtZSA9ICJEUEREQy1EIjsKPiA+PiAxMDI2ICAgICAgICAgICAgICAg ICBicmVhazsKPiA+PiAxMDI3ICAgICAgICAgZGVmYXVsdDoKPiA+PiAxMDI4ICAgICAgICAgICAg ICAgICBCVUcoKTsKPiA+PiAxMDI5ICAgICAgICAgfQo+ID4+IDEwMzAgCj4gPj4gMTAzMSAgICAg ICAgIC8qCj4gPj4gMTAzMiAgICAgICAgICAqIFRoZSBBVVhfQ1RMIHJlZ2lzdGVyIGlzIHVzdWFs bHkgRFBfQ1RMICsgMHgxMC4KPiA+PiAxMDMzICAgICAgICAgICoKPiA+PiAxMDM0ICAgICAgICAg ICogT24gSGFzd2VsbCBhbmQgQnJvYWR3ZWxsIHRob3VnaDoKPiA+PiAxMDM1ICAgICAgICAgICog ICAtIEJvdGggcG9ydCBBIERESV9CVUZfQ1RMIGFuZCBERElfQVVYX0NUTCBhcmUgb24gdGhlIENQ VQo+ID4+IDEwMzYgICAgICAgICAgKiAgIC0gUG9ydCBCL0MvRCBBVVggY2hhbm5lbHMgYXJlIG9u IHRoZSBQQ0gsIERESV9CVUZfQ1RMIG9uIHRoZSBDUFUKPiA+PiAxMDM3ICAgICAgICAgICoKPiA+ PiAxMDM4ICAgICAgICAgICogU2t5bGFrZSBtb3ZlcyBBVVhfQ1RMIGJhY2sgbmV4dCB0byBERElf QlVGX0NUTCwgb24gdGhlIENQVS4KPiA+PiAxMDM5ICAgICAgICAgICovCj4gPj4gMTA0MCAgICAg ICAgIGlmICghSVNfSEFTV0VMTChkZXYpICYmICFJU19CUk9BRFdFTEwoZGV2KSkKPiA+PiAxMDQx ICAgICAgICAgICAgICAgICBpbnRlbF9kcC0+YXV4X2NoX2N0bF9yZWcgPSBpbnRlbF9kcC0+b3V0 cHV0X3JlZyArIDB4MTA7Cj4gPj4gMTA0MiAKPiA+PiAvKlBvcnQgdGhlc2UgbGluZXMqLwo+ID4+ IDEwNDMgICAgICAgICBpbnRlbF9kcC0+YXV4Lm5hbWUgPSBuYW1lOwo+ID4+IDEwNDQgICAgICAg ICBpbnRlbF9kcC0+YXV4LmRldiA9IGRldi0+ZGV2Owo+ID4+IDEwNDUgICAgICAgICBpbnRlbF9k cC0+YXV4LnRyYW5zZmVyID0gaW50ZWxfZHBfYXV4X3RyYW5zZmVyOwo+ID4+IDEwNDYgCj4gPj4g LypQb3J0IHRoaXMgZGV2dWdnaW5nIG1lc3NhZ2UgKi8KPiA+PiAxMDQ3IERSTV9ERUJVR19LTVMo InJlZ2lzdGVyaW5nICVzIGJ1cyBmb3IgJXNcbiIsIG5hbWUsCj4gPj4gMTA0OCAgICAgICAgICAg ICAgICAgICAgICAgY29ubmVjdG9yLT5iYXNlLmtkZXYtPmtvYmoubmFtZSk7Cj4gPj4gMTA0OSAK PiA+PiAvKlBvcnQgdGhlc2UgbGluZXMqLwo+ID4+IDEwNTAgICAgICAgICByZXQgPSBkcm1fZHBf YXV4X3JlZ2lzdGVyKCZpbnRlbF9kcC0+YXV4KTsKPiA+PiAxMDUxICAgICAgICAgaWYgKHJldCA8 IDApIHsKPiA+PiAxMDUyICAgICAgICAgICAgICAgICBEUk1fRVJST1IoImRybV9kcF9hdXhfcmVn aXN0ZXIoKSBmb3IgJXMgZmFpbGVkICglZClcbiIsCj4gPj4gMTA1MyAgICAgICAgICAgICAgICAg ICAgICAgICAgIG5hbWUsIHJldCk7Cj4gPj4gMTA1NCAgICAgICAgICAgICAgICAgcmV0dXJuOwo+ ID4+IDEwNTUgICAgICAgICB9Cj4gPj4gMTA1NiAKPiA+PiAvKlBvcnQgdGhlIG9mIHRoZSBmdW5j dGlvbiAqLwo+ID4+IDEwNTcgICAgICAgICByZXQgPSBzeXNmc19jcmVhdGVfbGluaygmY29ubmVj dG9yLT5iYXNlLmtkZXYtPmtvYmosCj4gPj4gMTA1OCAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICZpbnRlbF9kcC0+YXV4LmRkYy5kZXYua29iaiwKPiA+PiAxMDU5ICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgaW50ZWxfZHAtPmF1eC5kZGMuZGV2LmtvYmoubmFtZSk7Cj4g Pj4gMTA2MCAgICAgICAgIGlmIChyZXQgPCAwKSB7Cj4gPj4gMTA2MSAgICAgICAgICAgICAgICAg RFJNX0VSUk9SKCJzeXNmc19jcmVhdGVfbGluaygpIGZvciAlcyBmYWlsZWQgKCVkKVxuIiwgbmFt ZSwgcmV0KTsKPiA+PiAxMDYyICAgICAgICAgICAgICAgICBkcm1fZHBfYXV4X3VucmVnaXN0ZXIo JmludGVsX2RwLT5hdXgpOwo+ID4+IDEwNjMgICAgICAgICB9Cj4gPj4gMTA2NCB9Cj4gPj4gMTA2 NSAKPiA+Pj4KPiA+Pj4+Pj4gU2lnbmVkLW9mZi1ieTogTmljaG9sYXMgS3JhdXNlIDx4ZXJvZm9p ZnlAZ21haWwuY29tPgo+ID4+Pj4+PiAtLS0KPiA+Pj4+Pj4gIGRyaXZlcnMvZ3B1L2RybS9nbWE1 MDAvY2R2X2ludGVsX2RwLmMgfCA0MiArKy0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0t LQo+ID4+Pj4+PiAgMSBmaWxlIGNoYW5nZWQsIDIgaW5zZXJ0aW9ucygrKSwgNDAgZGVsZXRpb25z KC0pCj4gPj4+Pj4+Cj4gPj4+Pj4+IGRpZmYgLS1naXQgYS9kcml2ZXJzL2dwdS9kcm0vZ21hNTAw L2Nkdl9pbnRlbF9kcC5jIGIvZHJpdmVycy9ncHUvZHJtL2dtYTUwMC9jZHZfaW50ZWxfZHAuYwo+ ID4+Pj4+PiBpbmRleCAwZmFmYjhlLi5jOGMyMGZjIDEwMDY0NAo+ID4+Pj4+PiAtLS0gYS9kcml2 ZXJzL2dwdS9kcm0vZ21hNTAwL2Nkdl9pbnRlbF9kcC5jCj4gPj4+Pj4+ICsrKyBiL2RyaXZlcnMv Z3B1L2RybS9nbWE1MDAvY2R2X2ludGVsX2RwLmMKPiA+Pj4+Pj4gQEAgLTIwMCwzOCArMjAwLDYg QEAgc3RhdGljIGNvbnN0IHN0cnVjdCBpMmNfYWxnb3JpdGhtIGkyY19kcF9hdXhfYWxnbyA9IHsK PiA+Pj4+Pj4gICAgICAgICAuZnVuY3Rpb25hbGl0eSAgPSBpMmNfYWxnb19kcF9hdXhfZnVuY3Rp b25hbGl0eSwKPiA+Pj4+Pj4gIH07Cj4gPj4+Pj4+Cj4gPj4+Pj4+IC1zdGF0aWMgdm9pZAo+ID4+ Pj4+PiAtaTJjX2RwX2F1eF9yZXNldF9idXMoc3RydWN0IGkyY19hZGFwdGVyICphZGFwdGVyKQo+ ID4+Pj4+PiAtewo+ID4+Pj4+PiAtICAgICAgICh2b2lkKSBpMmNfYWxnb19kcF9hdXhfYWRkcmVz cyhhZGFwdGVyLCAwLCBmYWxzZSk7Cj4gPj4+Pj4+IC0gICAgICAgKHZvaWQpIGkyY19hbGdvX2Rw X2F1eF9zdG9wKGFkYXB0ZXIsIGZhbHNlKTsKPiA+Pj4+Pj4gLX0KPiA+Pj4+Pj4gLQo+ID4+Pj4+ PiAtc3RhdGljIGludAo+ID4+Pj4+PiAtaTJjX2RwX2F1eF9wcmVwYXJlX2J1cyhzdHJ1Y3QgaTJj X2FkYXB0ZXIgKmFkYXB0ZXIpCj4gPj4+Pj4+IC17Cj4gPj4+Pj4+IC0gICAgICAgYWRhcHRlci0+ YWxnbyA9ICZpMmNfZHBfYXV4X2FsZ287Cj4gPj4+Pj4+IC0gICAgICAgYWRhcHRlci0+cmV0cmll cyA9IDM7Cj4gPj4+Pj4+IC0gICAgICAgaTJjX2RwX2F1eF9yZXNldF9idXMoYWRhcHRlcik7Cj4g Pj4+Pj4+IC0gICAgICAgcmV0dXJuIDA7Cj4gPj4+Pj4+IC19Cj4gPj4+Pj4+IC0KPiA+Pj4+Pj4g LS8qCj4gPj4+Pj4+IC0gKiBGSVhNRTogVGhpcyBpcyB0aGUgb2xkIGRwIGF1eCBoZWxwZXIsIGdt YTUwMCBpcyB0aGUgbGFzdCBkcml2ZXIgdGhhdCBuZWVkcyB0bwo+ID4+Pj4+PiAtICogYmUgcG9y dGVkIG92ZXIgdG8gdGhlIG5ldyBoZWxwZXIgY29kZSBpbiBkcm1fZHBfaGVscGVyLmMgbGlrZSBp OTE1IG9yIHJhZGVvbi4KPiA+Pj4+Pj4gLSAqLwo+ID4+Pj4+PiAtc3RhdGljIGludCBfX2RlcHJl Y2F0ZWQKPiA+Pj4+Pj4gLWkyY19kcF9hdXhfYWRkX2J1cyhzdHJ1Y3QgaTJjX2FkYXB0ZXIgKmFk YXB0ZXIpCj4gPj4+Pj4+IC17Cj4gPj4+Pj4+IC0gICAgICAgaW50IGVycm9yOwo+ID4+Pj4+PiAt Cj4gPj4+Pj4+IC0gICAgICAgZXJyb3IgPSBpMmNfZHBfYXV4X3ByZXBhcmVfYnVzKGFkYXB0ZXIp Owo+ID4+Pj4+PiAtICAgICAgIGlmIChlcnJvcikKPiA+Pj4+Pj4gLSAgICAgICAgICAgICAgIHJl dHVybiBlcnJvcjsKPiA+Pj4+Pj4gLSAgICAgICBlcnJvciA9IGkyY19hZGRfYWRhcHRlcihhZGFw dGVyKTsKPiA+Pj4+Pj4gLSAgICAgICByZXR1cm4gZXJyb3I7Cj4gPj4+Pj4+IC19Cj4gPj4+Pj4+ IC0KPiA+Pj4+Pj4gICNkZWZpbmUgX3dhaXRfZm9yKENPTkQsIE1TLCBXKSAoeyBcCj4gPj4+Pj4+ ICAgICAgICAgIHVuc2lnbmVkIGxvbmcgdGltZW91dF9fID0gamlmZmllcyArIG1zZWNzX3RvX2pp ZmZpZXMoTVMpOyAgICAgICBcCj4gPj4+Pj4+ICAgICAgICAgIGludCByZXRfXyA9IDA7ICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICBcCj4gPj4+Pj4+IEBA IC0yNzUsNiArMjQzLDcgQEAgc3RydWN0IGNkdl9pbnRlbF9kcCB7Cj4gPj4+Pj4+ICAgICAgICAg aW50IGJhY2tsaWdodF9vbl9kZWxheTsKPiA+Pj4+Pj4gICAgICAgICBpbnQgYmFja2xpZ2h0X29m Zl9kZWxheTsKPiA+Pj4+Pj4gICAgICAgICBzdHJ1Y3QgZHJtX2Rpc3BsYXlfbW9kZSAqcGFuZWxf Zml4ZWRfbW9kZTsgIC8qIGZvciBlRFAgKi8KPiA+Pj4+Pj4gKyAgICAgICBzdHJ1Y3QgZHJtX2Rw X2F1eCBhdXg7Cj4gPj4+Pj4+ICAgICAgICAgYm9vbCBwYW5lbF9vbjsKPiA+Pj4+Pj4gIH07Cj4g Pj4+Pj4+Cj4gPj4+Pj4+IEBAIC04NTUsMTggKzgyNCwxMSBAQCBjZHZfaW50ZWxfZHBfaTJjX2lu aXQoc3RydWN0IGdtYV9jb25uZWN0b3IgKmNvbm5lY3RvciwKPiA+Pj4+Pj4gICAgICAgICBpbnRl bF9kcC0+YWxnby5ydW5uaW5nID0gZmFsc2U7Cj4gPj4+Pj4+ICAgICAgICAgaW50ZWxfZHAtPmFs Z28uYWRkcmVzcyA9IDA7Cj4gPj4+Pj4+ICAgICAgICAgaW50ZWxfZHAtPmFsZ28uYXV4X2NoID0g Y2R2X2ludGVsX2RwX2kyY19hdXhfY2g7Cj4gPj4+Pj4+IC0KPiA+Pj4+Pj4gICAgICAgICBtZW1z ZXQoJmludGVsX2RwLT5hZGFwdGVyLCAnXDAnLCBzaXplb2YgKGludGVsX2RwLT5hZGFwdGVyKSk7 Cj4gPj4+Pj4+IC0gICAgICAgaW50ZWxfZHAtPmFkYXB0ZXIub3duZXIgPSBUSElTX01PRFVMRTsK PiA+Pj4+Pj4gLSAgICAgICBpbnRlbF9kcC0+YWRhcHRlci5jbGFzcyA9IEkyQ19DTEFTU19EREM7 Cj4gPj4+Pj4+IC0gICAgICAgc3RybmNweSAoaW50ZWxfZHAtPmFkYXB0ZXIubmFtZSwgbmFtZSwg c2l6ZW9mKGludGVsX2RwLT5hZGFwdGVyLm5hbWUpIC0gMSk7Cj4gPj4+Pj4+IC0gICAgICAgaW50 ZWxfZHAtPmFkYXB0ZXIubmFtZVtzaXplb2YoaW50ZWxfZHAtPmFkYXB0ZXIubmFtZSkgLSAxXSA9 ICdcMCc7Cj4gPj4+Pj4+IC0gICAgICAgaW50ZWxfZHAtPmFkYXB0ZXIuYWxnb19kYXRhID0gJmlu dGVsX2RwLT5hbGdvOwo+ID4+Pj4+PiAtICAgICAgIGludGVsX2RwLT5hZGFwdGVyLmRldi5wYXJl bnQgPSBjb25uZWN0b3ItPmJhc2Uua2RldjsKPiA+Pj4+Pj4KPiA+Pj4+Pj4gICAgICAgICBpZiAo aXNfZWRwKGVuY29kZXIpKQo+ID4+Pj4+PiAgICAgICAgICAgICAgICAgY2R2X2ludGVsX2VkcF9w YW5lbF92ZGRfb24oZW5jb2Rlcik7Cj4gPj4+Pj4+IC0gICAgICAgcmV0ID0gaTJjX2RwX2F1eF9h ZGRfYnVzKCZpbnRlbF9kcC0+YWRhcHRlcik7Cj4gPj4+Pj4+ICsgICAgICAgcmV0ID0gZHJtX2Rw X2F1eF9yZWdpc3RlcigmaW50ZWxfZHAtPmF1eCk7Cj4gPj4+Pj4+ICAgICAgICAgaWYgKGlzX2Vk cChlbmNvZGVyKSkKPiA+Pj4+Pj4gICAgICAgICAgICAgICAgIGNkdl9pbnRlbF9lZHBfcGFuZWxf dmRkX29mZihlbmNvZGVyKTsKPiA+Pj4+Pj4KPiA+Pj4+Pj4gLS0KPiA+Pj4+Pj4gMi4xLjQKPiA+ Pj4+Pj4KX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KZHJp LWRldmVsIG1haWxpbmcgbGlzdApkcmktZGV2ZWxAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHA6 Ly9saXN0cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0aW5mby9kcmktZGV2ZWwK From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752082AbbEJTqG (ORCPT ); Sun, 10 May 2015 15:46:06 -0400 Received: from mail-wi0-f169.google.com ([209.85.212.169]:38660 "EHLO mail-wi0-f169.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751534AbbEJTqC (ORCPT ); Sun, 10 May 2015 15:46:02 -0400 From: patrik.r.jakobsson@gmail.com X-Google-Original-From: patrik@patrik-arch.example2.org Date: Sun, 10 May 2015 21:45:36 +0200 To: nick Cc: dri-devel , linux-kernel Subject: Re: [PATCH] gma500:Remove functions that are now deprecated and move to the newer functions in drm_dp_helper.c Message-ID: <20150510194536.GA25199@patrik-arch.example2.org> References: <1430778546-23468-1-git-send-email-xerofoify@gmail.com> <5548DEF3.5040204@gmail.com> <20150510170435.GA3108@patrik-arch.example2.org> <554F99DE.3020608@gmail.com> <20150510183540.GA10437@patrik-arch.example2.org> <554FA628.6030102@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <554FA628.6030102@gmail.com> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sun, May 10, 2015 at 02:40:40PM -0400, nick wrote: > > > On 2015-05-10 02:35 PM, patrik.r.jakobsson@gmail.com wrote: > > On Sun, May 10, 2015 at 01:48:14PM -0400, nick wrote: > >> > >> > >> On 2015-05-10 01:04 PM, patrik.r.jakobsson@gmail.com wrote: > >>> On Tue, May 05, 2015 at 11:17:07AM -0400, nick wrote: > >>>> > >>>> > >>>> On 2015-05-05 09:06 AM, Patrik Jakobsson wrote: > >>>>> On Tue, May 5, 2015 at 12:29 AM, Nicholas Krause wrote: > >>>>>> This removes the deprecated functions,i2c_dp_aux_add_bus and > >>>>>> i2c_dp_aux_prepare_bus and the only call in the function, > >>>>>> cdv_intel_dp_i2c_init to i2c_dp_aux_add_bus respectfully. > >>>>>> The call and use of these functions is now replaced alongside > >>>>>> the removal of setting other values in the function,cdv_intel_dp_i2c_init > >>>>>> to use the helper function, drm_dp_aux_register that can handle all this > >>>>>> work internally. > >>>>> > >>>>> You need to fill in the drm_dp_aux structure and implement a proper transfer > >>>>> function. This patch would only break things. But the cdv dp output is already > >>>>> broken on my system so it needs fixing first. > >>>>> > >>>>> -Patrik > >>>>> > >>>> Patrik, > >>>> Due to me not being an expert in this area of the kernel I based my work off the similar function, > >>>> intel_dp_aux_init for i915. I was unsure of which helper functions for i915 need to be written > >>>> differently for gma500 based solutions as I don't known the differences between these two in the > >>>> graphics specs area. > >>>> Thanks, > >>>> Nick > >>> > >>> Hi Nick > >>> You are _required_ to know what your patches are doing before sending them. If > >>> you don't test your code and don't know what it's doing then we will not accept > >>> it. You're expected to read the available documentation and relevant literature > >>> before sending patches and asking questions. Otherwise someone else is doing the > >>> work for you, which I assume is not the purpose of you patch submission. > >>> > >>> Thanks > >>> Patrik > > >> Patrik, > >> Sorry about that my question is actually this ,I am unsure of what parts of the function,intel_dp_aux_init > >> need to be ported for the gma500 gpu driver. Furthermore I will list what parts for certain I known need to > >> be ported over above the lines of code in the function definition I have pasted below. Please let me known > >> if there are any areas I am missing. This is more just of a double check to make sure I don't miss something > >> critical:)(I like to verify something before I code it). > >> Sorry for the misunderstanding, > > > > You can figure this out by reading the drm dp helpers docs and looking at > > cdv_intel_dp.c. For instance, in gma500 we initialize DP_B and DP_C. > > > > My point is that _you_ need to read the code and understand it. I cannot help > > you with that. > > > > But as I said in my first reply. DP on CDV is broken (at least on my machine) so > > that should be fixed first. > > > > Cheers > > Patrik > > > Patrik, > Sorry about that :). Your right it's a bad habit :(, I will start working on it. > Further more by "broken" you mean what. This is very vague and if you would like > some help with it, I am willing to if you can give me a detailed response of what > is wrong. > Nick Vague? Both DP and LVDS displays are black after boot when DP is connected. What additional information do you need? > >> Nick > >> static void > >> 1002 intel_dp_aux_init(struct intel_dp *intel_dp, struct intel_connector *connector) > >> 1003 { > >> /*Unsure about how to port this over the functions in these lines a.k.a any differences between i915 and gma500 related to these functions? > >> I read through these function definitions but would like to double check*/ > >> 1004 struct drm_device *dev = intel_dp_to_dev(intel_dp); > >> 1005 struct intel_digital_port *intel_dig_port = dp_to_dig_port(intel_dp); > >> 1006 enum port port = intel_dig_port->port; > >> /*Port these lines*/ > >> 1007 const char *name = NULL; > >> 1008 int ret; > >> /*Port this switch statement */ > >> 1009 > >> 1010 switch (port) { > >> 1011 case PORT_A: > >> 1012 intel_dp->aux_ch_ctl_reg = DPA_AUX_CH_CTL; > >> 1013 name = "DPDDC-A"; > >> 1014 break; > >> 1015 case PORT_B: > >> 1016 intel_dp->aux_ch_ctl_reg = PCH_DPB_AUX_CH_CTL; > >> 1017 name = "DPDDC-B"; > >> 1018 break; > >> 1019 case PORT_C: > >> 1020 intel_dp->aux_ch_ctl_reg = PCH_DPC_AUX_CH_CTL; > >> 1021 name = "DPDDC-C"; > >> 1022 break; > >> 1023 case PORT_D: > >> 1024 intel_dp->aux_ch_ctl_reg = PCH_DPD_AUX_CH_CTL; > >> 1025 name = "DPDDC-D"; > >> 1026 break; > >> 1027 default: > >> 1028 BUG(); > >> 1029 } > >> 1030 > >> 1031 /* > >> 1032 * The AUX_CTL register is usually DP_CTL + 0x10. > >> 1033 * > >> 1034 * On Haswell and Broadwell though: > >> 1035 * - Both port A DDI_BUF_CTL and DDI_AUX_CTL are on the CPU > >> 1036 * - Port B/C/D AUX channels are on the PCH, DDI_BUF_CTL on the CPU > >> 1037 * > >> 1038 * Skylake moves AUX_CTL back next to DDI_BUF_CTL, on the CPU. > >> 1039 */ > >> 1040 if (!IS_HASWELL(dev) && !IS_BROADWELL(dev)) > >> 1041 intel_dp->aux_ch_ctl_reg = intel_dp->output_reg + 0x10; > >> 1042 > >> /*Port these lines*/ > >> 1043 intel_dp->aux.name = name; > >> 1044 intel_dp->aux.dev = dev->dev; > >> 1045 intel_dp->aux.transfer = intel_dp_aux_transfer; > >> 1046 > >> /*Port this devugging message */ > >> 1047 DRM_DEBUG_KMS("registering %s bus for %s\n", name, > >> 1048 connector->base.kdev->kobj.name); > >> 1049 > >> /*Port these lines*/ > >> 1050 ret = drm_dp_aux_register(&intel_dp->aux); > >> 1051 if (ret < 0) { > >> 1052 DRM_ERROR("drm_dp_aux_register() for %s failed (%d)\n", > >> 1053 name, ret); > >> 1054 return; > >> 1055 } > >> 1056 > >> /*Port the of the function */ > >> 1057 ret = sysfs_create_link(&connector->base.kdev->kobj, > >> 1058 &intel_dp->aux.ddc.dev.kobj, > >> 1059 intel_dp->aux.ddc.dev.kobj.name); > >> 1060 if (ret < 0) { > >> 1061 DRM_ERROR("sysfs_create_link() for %s failed (%d)\n", name, ret); > >> 1062 drm_dp_aux_unregister(&intel_dp->aux); > >> 1063 } > >> 1064 } > >> 1065 > >>> > >>>>>> Signed-off-by: Nicholas Krause > >>>>>> --- > >>>>>> drivers/gpu/drm/gma500/cdv_intel_dp.c | 42 ++--------------------------------- > >>>>>> 1 file changed, 2 insertions(+), 40 deletions(-) > >>>>>> > >>>>>> diff --git a/drivers/gpu/drm/gma500/cdv_intel_dp.c b/drivers/gpu/drm/gma500/cdv_intel_dp.c > >>>>>> index 0fafb8e..c8c20fc 100644 > >>>>>> --- a/drivers/gpu/drm/gma500/cdv_intel_dp.c > >>>>>> +++ b/drivers/gpu/drm/gma500/cdv_intel_dp.c > >>>>>> @@ -200,38 +200,6 @@ static const struct i2c_algorithm i2c_dp_aux_algo = { > >>>>>> .functionality = i2c_algo_dp_aux_functionality, > >>>>>> }; > >>>>>> > >>>>>> -static void > >>>>>> -i2c_dp_aux_reset_bus(struct i2c_adapter *adapter) > >>>>>> -{ > >>>>>> - (void) i2c_algo_dp_aux_address(adapter, 0, false); > >>>>>> - (void) i2c_algo_dp_aux_stop(adapter, false); > >>>>>> -} > >>>>>> - > >>>>>> -static int > >>>>>> -i2c_dp_aux_prepare_bus(struct i2c_adapter *adapter) > >>>>>> -{ > >>>>>> - adapter->algo = &i2c_dp_aux_algo; > >>>>>> - adapter->retries = 3; > >>>>>> - i2c_dp_aux_reset_bus(adapter); > >>>>>> - return 0; > >>>>>> -} > >>>>>> - > >>>>>> -/* > >>>>>> - * FIXME: This is the old dp aux helper, gma500 is the last driver that needs to > >>>>>> - * be ported over to the new helper code in drm_dp_helper.c like i915 or radeon. > >>>>>> - */ > >>>>>> -static int __deprecated > >>>>>> -i2c_dp_aux_add_bus(struct i2c_adapter *adapter) > >>>>>> -{ > >>>>>> - int error; > >>>>>> - > >>>>>> - error = i2c_dp_aux_prepare_bus(adapter); > >>>>>> - if (error) > >>>>>> - return error; > >>>>>> - error = i2c_add_adapter(adapter); > >>>>>> - return error; > >>>>>> -} > >>>>>> - > >>>>>> #define _wait_for(COND, MS, W) ({ \ > >>>>>> unsigned long timeout__ = jiffies + msecs_to_jiffies(MS); \ > >>>>>> int ret__ = 0; \ > >>>>>> @@ -275,6 +243,7 @@ struct cdv_intel_dp { > >>>>>> int backlight_on_delay; > >>>>>> int backlight_off_delay; > >>>>>> struct drm_display_mode *panel_fixed_mode; /* for eDP */ > >>>>>> + struct drm_dp_aux aux; > >>>>>> bool panel_on; > >>>>>> }; > >>>>>> > >>>>>> @@ -855,18 +824,11 @@ cdv_intel_dp_i2c_init(struct gma_connector *connector, > >>>>>> intel_dp->algo.running = false; > >>>>>> intel_dp->algo.address = 0; > >>>>>> intel_dp->algo.aux_ch = cdv_intel_dp_i2c_aux_ch; > >>>>>> - > >>>>>> memset(&intel_dp->adapter, '\0', sizeof (intel_dp->adapter)); > >>>>>> - intel_dp->adapter.owner = THIS_MODULE; > >>>>>> - intel_dp->adapter.class = I2C_CLASS_DDC; > >>>>>> - strncpy (intel_dp->adapter.name, name, sizeof(intel_dp->adapter.name) - 1); > >>>>>> - intel_dp->adapter.name[sizeof(intel_dp->adapter.name) - 1] = '\0'; > >>>>>> - intel_dp->adapter.algo_data = &intel_dp->algo; > >>>>>> - intel_dp->adapter.dev.parent = connector->base.kdev; > >>>>>> > >>>>>> if (is_edp(encoder)) > >>>>>> cdv_intel_edp_panel_vdd_on(encoder); > >>>>>> - ret = i2c_dp_aux_add_bus(&intel_dp->adapter); > >>>>>> + ret = drm_dp_aux_register(&intel_dp->aux); > >>>>>> if (is_edp(encoder)) > >>>>>> cdv_intel_edp_panel_vdd_off(encoder); > >>>>>> > >>>>>> -- > >>>>>> 2.1.4 > >>>>>>