From: Dan Carpenter <dan.carpenter@oracle.com>
To: kernel-janitors@vger.kernel.org
Subject: Re: type mismatch
Date: Mon, 11 May 2015 08:14:17 +0000 [thread overview]
Message-ID: <20150511081417.GH14154@mwanda> (raw)
In-Reply-To: <alpine.DEB.2.10.1505101517100.2645@hadrien>
Hm... You're right. I'm going to retract some things.
1) I didn't end up adding a special case handling for this, I only
wanted to but never got around to it.
2) Also these aren't *that* common as I was thinking. They're mostly
limitted to emulex.
drivers/net/ethernet/emulex/benet/be_cmds.c
3173
3174 be_wrb_cmd_hdr_prepare(&req->hdr, CMD_SUBSYSTEM_COMMON,
^^^^^^^^^
First element.
3175 OPCODE_COMMON_SET_HSW_CONFIG, sizeof(*req), wrb,
^^^^^^^^^^^^
Here is the sizeof().
3176 NULL);
3177
3) It's also obvious why emulex would do this because the req struct
could be defined a lot of different ways so long as the first element
is a header. It's like a union.
Sorry for the misinformation. My bad.
regards,
dan carpenter
next prev parent reply other threads:[~2015-05-11 8:14 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-05-10 13:20 type mismatch Julia Lawall
2015-05-10 19:57 ` Dan Carpenter
2015-05-10 20:03 ` Julia Lawall
2015-05-11 7:18 ` Nicholas Mc Guire
2015-05-11 7:32 ` Julia Lawall
2015-05-11 8:14 ` Dan Carpenter [this message]
2015-05-11 8:29 ` Nicholas Mc Guire
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150511081417.GH14154@mwanda \
--to=dan.carpenter@oracle.com \
--cc=kernel-janitors@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.