From: David Sterba <dsterba@suse.cz>
To: Anand Jain <Anand.Jain@oracle.com>
Cc: linux-btrfs@vger.kernel.org
Subject: Re: [PATCH 1/1] btrfs-progs: improve troubleshooting avoid duplicate error strings
Date: Mon, 11 May 2015 13:23:18 +0200 [thread overview]
Message-ID: <20150511112318.GL23255@suse.cz> (raw)
In-Reply-To: <554C73A8.1030406@oracle.com>
On Fri, May 08, 2015 at 04:28:24PM +0800, Anand Jain wrote:
> >> @@ -187,7 +187,7 @@ static int cmd_rm_dev(int argc, char **argv)
> >> ret++;
> >> } else if (res < 0) {
> >> fprintf(stderr,
> >> - "ERROR: error removing the device '%s' - %s\n",
> >> + "ERROR: ioctl error removing the device '%s' - %s\n",
> >
> > The only difference is the strerror vs btrfs_err_str. As both ret > 0
> > and ret < 0 report some kind of error, the wording would be very similar
> > so I think that one error message would fit better. I'll fix that.
>
> You means res not ret (above) ?
Oh right, please send a patch.
prev parent reply other threads:[~2015-05-11 11:23 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-04-13 12:37 [PATCH 1/1] btrfs-progs: improve troubleshooting avoid duplicate error strings Anand Jain
2015-04-13 13:40 ` Marc MERLIN
2015-04-14 13:14 ` David Sterba
2015-05-08 8:28 ` Anand Jain
2015-05-11 11:23 ` David Sterba [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150511112318.GL23255@suse.cz \
--to=dsterba@suse.cz \
--cc=Anand.Jain@oracle.com \
--cc=linux-btrfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.