From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from list by lists.gnu.org with archive (Exim 4.71) id 1Yrlub-0001xH-Vi for mharc-grub-devel@gnu.org; Mon, 11 May 2015 07:30:17 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:39818) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Yrlua-0001vY-GV for grub-devel@gnu.org; Mon, 11 May 2015 07:30:17 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YrluZ-00023F-RP for grub-devel@gnu.org; Mon, 11 May 2015 07:30:16 -0400 Received: from mo6-p00-ob.smtp.rzone.de ([2a01:238:20a:202:5300::2]:17862) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YrluZ-000225-Gc for grub-devel@gnu.org; Mon, 11 May 2015 07:30:15 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; t=1431343813; l=692; s=domk; d=aepfle.de; h=In-Reply-To:Content-Disposition:Content-Type:MIME-Version: References:Subject:To:From:Date; bh=Hdjftfj25aEV27RtmN2dahcfhtq3IgjKCQKA8zxu3Gk=; b=e20ukVabj/V/TWWyJBfc0Kbdr3kJQtvjMdL4ZKkgF4Ea16NR2I8TQhbFd962qPo8xtK Ueg8PcwCoLxx6+b6BE57ftKAKfz/eHZgvJcVs23+RHXlnVwFoQD1DnZQyH1kTVsoH+zmd SSElPQaY6mWWcQVo9wRQIIJsYAoPwyr1NPM= X-RZG-AUTH: :P2EQZWCpfu+qG7CngxMFH1J+yackYocTD1iAi8x+OWi/zfN1cLnBYfssVY1SE5ClEYfb5sQvxDNUdfk3GFAM3xrxaZN0YQ== X-RZG-CLASS-ID: mo00 Received: from probook.fritz.box ([2001:a60:10a3:eb01:1ec1:deff:feb9:bb48]) by smtp.strato.de (RZmta 37.5 AUTH) with ESMTPSA id V06063r4BBUDJmy (using TLSv1 with cipher ECDHE-RSA-AES256-SHA (curve sect571r1 with 571 ECDH bits, eq. 15360 bits RSA)) (Client did not present a certificate) for ; Mon, 11 May 2015 13:30:13 +0200 (CEST) Received: by probook.fritz.box (Postfix, from userid 1000) id 49650502A7; Mon, 11 May 2015 13:30:13 +0200 (CEST) Date: Mon, 11 May 2015 13:30:13 +0200 From: Olaf Hering To: The development of GNU GRUB Subject: Re: [PATCH] Remove CPPFLAGS_XEN Message-ID: <20150511113013.GA19976@aepfle.de> References: <1431342798-12811-1-git-send-email-olaf@aepfle.de> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.22.rev6346 (2013-10-29) X-detected-operating-system: by eggs.gnu.org: Error: Malformed IPv6 address (bad octet value). X-Received-From: 2a01:238:20a:202:5300::2 X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list Reply-To: The development of GNU GRUB List-Id: The development of GNU GRUB List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 11 May 2015 11:30:17 -0000 On Mon, May 11, Vladimir 'phcoder' Serbinenko wrote: > What is the problem you're trying to solve? We shouldn't require user to pass > additional parameters for common cases of we can avoid it My xen headers are in /odd/path, so I first tried env CPPFLAGS_XEN=/odd/path/include ./configure && make This failed because CPPFLAGS_XEN is a private make variable. Later I looked at ./configure --help and noticed the CPPFLAGS variable, wich is aoppearently the prefered way to specify them. And the common case is maybe that /usr/include already has the xen headers, in which case CPPFLAGS_XEN is not needed. I assume the initial change should have done what my patch does. Olaf