All of lore.kernel.org
 help / color / mirror / Atom feed
From: Sudip Mukherjee <sudipm.mukherjee@gmail.com>
To: Dan Carpenter <dan.carpenter@oracle.com>
Cc: Oleg Drokin <oleg.drokin@intel.com>,
	Andreas Dilger <andreas.dilger@intel.com>,
	Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	HPDD-discuss@ml01.01.org, devel@driverdev.osuosl.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH] staging: lustre: remove unused variable
Date: Mon, 11 May 2015 17:13:53 +0530	[thread overview]
Message-ID: <20150511114330.GA11994@sudip-PC> (raw)
In-Reply-To: <20150511113102.GK14154@mwanda>

On Mon, May 11, 2015 at 02:31:02PM +0300, Dan Carpenter wrote:
> On Mon, May 11, 2015 at 04:17:10PM +0530, Sudip Mukherjee wrote:
> > -	if (set->set_pga) {
> > -		int len = set->set_oabufs * sizeof(*set->set_pga);
> > +	if (set->set_pga)
> >  		OBD_FREE_LARGE(set->set_pga, len);
>                                              ^^^
> It's used right here?

oops.. sorry .. but why i didnot get a build failure after this?

ok, got it ...  

#define OBD_FREE_LARGE(ptr, size)	\
do {					\
		kvfree(ptr);		\
} while (0)

the variable is actually not used. I will make a v2 and send 
tomorrow. today is a day of silly mistakes :( 

regards
sudip

> 
> regards,
> dan carpenter
> 

  reply	other threads:[~2015-05-11 11:44 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-05-11 10:47 [PATCH] staging: lustre: remove unused variable Sudip Mukherjee
2015-05-11 11:31 ` Dan Carpenter
2015-05-11 11:43   ` Sudip Mukherjee [this message]
2015-05-11 11:53     ` Drokin, Oleg
  -- strict thread matches above, loose matches on Subject: below --
2015-11-03 22:16 [patch] " Dan Carpenter
2015-11-03 22:38 ` Simmons, James A.
2015-11-04  1:23   ` Greg Kroah-Hartman

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20150511114330.GA11994@sudip-PC \
    --to=sudipm.mukherjee@gmail.com \
    --cc=HPDD-discuss@ml01.01.org \
    --cc=andreas.dilger@intel.com \
    --cc=dan.carpenter@oracle.com \
    --cc=devel@driverdev.osuosl.org \
    --cc=gregkh@linuxfoundation.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=oleg.drokin@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.