All of lore.kernel.org
 help / color / mirror / Atom feed
From: shawn.guo@linaro.org (Shawn Guo)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v2] ARM: dts: cubox-i: add support for Broadcom Wifi/Bluetooth devices
Date: Mon, 11 May 2015 21:00:17 +0800	[thread overview]
Message-ID: <20150511130016.GE9347@dragon> (raw)
In-Reply-To: <1430932810-28756-1-git-send-email-festevam@gmail.com>

On Wed, May 06, 2015 at 02:20:10PM -0300, Fabio Estevam wrote:
> From: Fabio Estevam <fabio.estevam@freescale.com>
> 
> Add DT support for the Broadcom Wifi/Bluetooth devices found on the
> microsom board.
> 
> [Modified original Russell King's patch to use mmc-pwrseq]
> 
> Signed-off-by: Russell King <rmk+kernel@arm.linux.org.uk>
> Signed-off-by: Fabio Estevam <fabio.estevam@freescale.com>
> ---
> Changes since v1:
> - Do not permanently keep the oscillator on. Use the proper clk bindings
> from powerseq.
> 
>  arch/arm/boot/dts/imx6qdl-microsom.dtsi | 105 ++++++++++++++++++++++++++++++++
>  1 file changed, 105 insertions(+)
> 
> diff --git a/arch/arm/boot/dts/imx6qdl-microsom.dtsi b/arch/arm/boot/dts/imx6qdl-microsom.dtsi
> index 349f82b..846eb89 100644
> --- a/arch/arm/boot/dts/imx6qdl-microsom.dtsi
> +++ b/arch/arm/boot/dts/imx6qdl-microsom.dtsi
> @@ -39,15 +39,100 @@
>   *     FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR
>   *     OTHER DEALINGS IN THE SOFTWARE.
>   */
> +#include <dt-bindings/gpio/gpio.h>
> +/ {
> +	clocks {

One of the device tree maintainers doesn't like "clocks" container.
Since you're not using generic node name for child clock, the container
can just be saved.

Shawn

> +		clk_sdio: sdio-clock {
> +			compatible = "gpio-gate-clock";
> +			#clock-cells = <0>;
> +			pinctrl-names = "default";
> +			pinctrl-0 = <&pinctrl_microsom_brcm_osc>;
> +			enable-gpios = <&gpio5 5 GPIO_ACTIVE_HIGH>;
> +		};
> +	};
> +
> +	regulators {
> +		compatible = "simple-bus";
> +
> +		reg_brcm: brcm-reg {
> +			compatible = "regulator-fixed";
> +			enable-active-high;
> +			gpio = <&gpio3 19 0>;
> +			pinctrl-names = "default";
> +			pinctrl-0 = <&pinctrl_microsom_brcm_reg>;
> +			regulator-name = "brcm_reg";
> +			regulator-min-microvolt = <3300000>;
> +			regulator-max-microvolt = <3300000>;
> +			startup-delay-us = <200000>;
> +		};
> +	};
> +
> +	usdhc1_pwrseq: usdhc1_pwrseq {
> +		compatible = "mmc-pwrseq-simple";
> +		reset-gpios = <&gpio5 26 GPIO_ACTIVE_LOW>,
> +			      <&gpio6 0 GPIO_ACTIVE_LOW>;
> +		clocks = <&clk_sdio>;
> +		clock-names = "ext_clock";
> +	};
> +};
>  
>  &iomuxc {
>  	microsom {
> +		pinctrl_microsom_brcm_bt: microsom-brcm-bt {
> +			fsl,pins = <
> +				MX6QDL_PAD_CSI0_DAT14__GPIO6_IO00	0x40013070
> +				MX6QDL_PAD_CSI0_DAT15__GPIO6_IO01	0x40013070
> +				MX6QDL_PAD_CSI0_DAT18__GPIO6_IO04	0x40013070
> +			>;
> +		};
> +
> +		pinctrl_microsom_brcm_osc: microsom-brcm-osc {
> +			fsl,pins = <
> +				MX6QDL_PAD_DISP0_DAT11__GPIO5_IO05	0x40013070
> +			>;
> +		};
> +
> +		pinctrl_microsom_brcm_reg: microsom-brcm-reg {
> +			fsl,pins = <
> +				MX6QDL_PAD_EIM_D19__GPIO3_IO19		0x40013070
> +			>;
> +		};
> +
> +		pinctrl_microsom_brcm_wifi: microsom-brcm-wifi {
> +			fsl,pins = <
> +				MX6QDL_PAD_GPIO_8__XTALOSC_REF_CLK_32K	0x1b0b0
> +				MX6QDL_PAD_CSI0_DATA_EN__GPIO5_IO20	0x40013070
> +				MX6QDL_PAD_CSI0_DAT8__GPIO5_IO26	0x40013070
> +				MX6QDL_PAD_CSI0_DAT9__GPIO5_IO27	0x40013070
> +			>;
> +		};
> +
>  		pinctrl_microsom_uart1: microsom-uart1 {
>  			fsl,pins = <
>  				MX6QDL_PAD_CSI0_DAT10__UART1_TX_DATA	0x1b0b1
>  				MX6QDL_PAD_CSI0_DAT11__UART1_RX_DATA	0x1b0b1
>  			>;
>  		};
> +
> +		pinctrl_microsom_uart4: microsom-uart4 {
> +			fsl,pins = <
> +				MX6QDL_PAD_CSI0_DAT12__UART4_TX_DATA 0x1b0b1
> +				MX6QDL_PAD_CSI0_DAT13__UART4_RX_DATA 0x1b0b1
> +				MX6QDL_PAD_CSI0_DAT16__UART4_RTS_B 0x1b0b1
> +				MX6QDL_PAD_CSI0_DAT17__UART4_CTS_B 0x1b0b1
> +			>;
> +		};
> +
> +		pinctrl_microsom_usdhc1: microsom-usdhc1 {
> +			fsl,pins = <
> +				MX6QDL_PAD_SD1_CMD__SD1_CMD    0x17059
> +				MX6QDL_PAD_SD1_CLK__SD1_CLK    0x10059
> +				MX6QDL_PAD_SD1_DAT0__SD1_DATA0 0x17059
> +				MX6QDL_PAD_SD1_DAT1__SD1_DATA1 0x17059
> +				MX6QDL_PAD_SD1_DAT2__SD1_DATA2 0x17059
> +				MX6QDL_PAD_SD1_DAT3__SD1_DATA3 0x17059
> +			>;
> +		};
>  	};
>  };
>  
> @@ -56,3 +141,23 @@
>  	pinctrl-0 = <&pinctrl_microsom_uart1>;
>  	status = "okay";
>  };
> +
> +/* UART4 - Connected to optional BRCM Wifi/BT/FM */
> +&uart4 {
> +	pinctrl-names = "default";
> +	pinctrl-0 = <&pinctrl_microsom_brcm_bt &pinctrl_microsom_uart4>;
> +	fsl,uart-has-rtscts;
> +	status = "okay";
> +};
> +
> +/* USDHC1 - Connected to optional BRCM Wifi/BT/FM */
> +&usdhc1 {
> +	pinctrl-names = "default";
> +	pinctrl-0 = <&pinctrl_microsom_brcm_wifi &pinctrl_microsom_usdhc1>;
> +	bus-width = <4>;
> +	mmc-pwrseq = <&usdhc1_pwrseq>;
> +	keep-power-in-suspend;
> +	non-removable;
> +	vmmc-supply = <&reg_brcm>;
> +	status = "okay";
> +};
> -- 
> 1.9.1
> 

  reply	other threads:[~2015-05-11 13:00 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-05-06 17:20 [PATCH v2] ARM: dts: cubox-i: add support for Broadcom Wifi/Bluetooth devices Fabio Estevam
2015-05-11 13:00 ` Shawn Guo [this message]
2015-05-11 13:46   ` Fabio Estevam
2015-05-11 14:15     ` Fabio Estevam
2015-05-11 14:36       ` Shawn Guo

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20150511130016.GE9347@dragon \
    --to=shawn.guo@linaro.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.