All of lore.kernel.org
 help / color / mirror / Atom feed
From: Ingo Molnar <mingo@kernel.org>
To: sylvain.bertrand@gmail.com
Cc: x86@kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] x86: Fix mkcapflags.sh bash-ism again
Date: Mon, 11 May 2015 15:53:33 +0200	[thread overview]
Message-ID: <20150511135333.GA5045@gmail.com> (raw)
In-Reply-To: <20150509234137.GA23627@freedom>


* sylvain.bertrand@gmail.com <sylvain.bertrand@gmail.com> wrote:

> On Mon, Apr 27, 2015 at 03:21:02PM +0000, sylvain.bertrand@gmail.com wrote:
> > While compiling linux, dash shell reports a bash-ism:
> > 
> > /src/linux-4.0/arch/x86/kernel/cpu/mkcapflags.sh: 9: /src/linux-4.0/arch/x86/kernel/cpu/mkcapflags.sh: Syntax error: "(" unexpected
> > 
> > See:
> > http://pubs.opengroup.org/onlinepubs/009695399/utilities/xcu_chap02.html#tag_02_09_05
> > 
> > Cc: Ingo Molnar <mingo@kernel.org>
> > Signed-off-by: Sylvain BERTRAND <sylvain.bertrand@gmail.com>
> > ---
> > Forgot that fix:
> > --- a/arch/x86/kernel/cpu/mkcapflags.sh
> > +++ b/arch/x86/kernel/cpu/mkcapflags.sh
> > @@ -6,7 +6,7 @@
> >  IN=$1
> >  OUT=$2
> >  
> > -function dump_array()
> > +dump_array()
> >  {
> >  	ARRAY=$1
> >  	SIZE=$2
> 
> What's up with this patch?

It's upstream, as commit:

  e85bd9892c4f x86/build: Fix mkcapflags.sh bash-ism

thanks,

	Ingo

      reply	other threads:[~2015-05-11 13:53 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-12-29 15:43 [PATCH] x86: Fix mkcapflags.sh bash-ism again Sylvain BERTRAND
2015-02-19  1:31 ` [tip:x86/build] x86/build: Fix mkcapflags.sh bash-ism tip-bot for Sylvain BERTRAND
2015-04-27 15:21 ` [PATCH] x86: Fix mkcapflags.sh bash-ism again sylvain.bertrand
2015-05-09 23:41   ` sylvain.bertrand
2015-05-11 13:53     ` Ingo Molnar [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20150511135333.GA5045@gmail.com \
    --to=mingo@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=sylvain.bertrand@gmail.com \
    --cc=x86@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.