From: Andrei Borzenkov <arvidjaar@gmail.com>
To: Jan Kara <jack@suse.cz>
Cc: grub-devel@gnu.org
Subject: Re: [PATCH 1/4] xfs: Add helper for inode size
Date: Mon, 11 May 2015 14:53:57 +0300 [thread overview]
Message-ID: <20150511145357.56bdf48d@opensuse.site> (raw)
In-Reply-To: <1405351291-24767-2-git-send-email-jack@suse.cz>
В Mon, 14 Jul 2014 17:21:28 +0200
Jan Kara <jack@suse.cz> пишет:
> Signed-off-by: Jan Kara <jack@suse.cz>
> ---
> grub-core/fs/xfs.c | 17 +++++++++++------
> 1 file changed, 11 insertions(+), 6 deletions(-)
>
> diff --git a/grub-core/fs/xfs.c b/grub-core/fs/xfs.c
> index 16ffd3f1ebd9..a2fc942707c1 100644
> --- a/grub-core/fs/xfs.c
> +++ b/grub-core/fs/xfs.c
> @@ -255,6 +255,11 @@ grub_xfs_inode_offset (struct grub_xfs_data *data,
> data->sblock.log2_inode);
> }
>
> +static inline int
> +grub_xfs_inode_size(struct grub_xfs_data *data)
This should be grub_size_t.
What is the reason to add it? It does not look like subsequent
patches modify this function like making it conditional on XFS version.
next prev parent reply other threads:[~2015-05-11 11:54 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-07-14 15:21 [PATCH 0/4] Support for XFS v5 superblock Jan Kara
2014-07-14 15:21 ` [PATCH 1/4] xfs: Add helper for inode size Jan Kara
2015-05-11 11:53 ` Andrei Borzenkov [this message]
2015-05-11 12:15 ` Jan Kara
2015-05-12 5:26 ` Andrei Borzenkov
2015-05-12 8:07 ` Jan Kara
2014-07-14 15:21 ` [PATCH 2/4] xfs: Fix termination loop for directory iteration Jan Kara
2015-05-11 11:49 ` Andrei Borzenkov
2014-07-14 15:21 ` [PATCH 3/4] xfs: Convert inode numbers to cpu endianity immediately after reading Jan Kara
2015-05-12 5:22 ` Andrei Borzenkov
2014-07-14 15:21 ` [PATCH 4/4] xfs: V5 filesystem format support Jan Kara
2015-05-12 5:23 ` Andrei Borzenkov
2015-05-12 13:47 ` Jan Kara
2015-05-13 4:50 ` Andrei Borzenkov
2015-05-13 7:12 ` Jan Kara
2014-07-21 17:31 ` [PATCH 0/4] Support for XFS v5 superblock Jan Kara
2014-07-21 21:42 ` Vladimir 'φ-coder/phcoder' Serbinenko
2014-09-23 7:39 ` Jan Kara
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150511145357.56bdf48d@opensuse.site \
--to=arvidjaar@gmail.com \
--cc=grub-devel@gnu.org \
--cc=jack@suse.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.