From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from list by lists.gnu.org with archive (Exim 4.71) id 1YrmR3-0003iC-8f for mharc-grub-devel@gnu.org; Mon, 11 May 2015 08:03:49 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:49191) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YrmR0-0003ey-Dx for grub-devel@gnu.org; Mon, 11 May 2015 08:03:47 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YrmQx-0003g5-7q for grub-devel@gnu.org; Mon, 11 May 2015 08:03:46 -0400 Received: from mail-la0-x234.google.com ([2a00:1450:4010:c03::234]:34573) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YrmQw-0003fw-WA for grub-devel@gnu.org; Mon, 11 May 2015 08:03:43 -0400 Received: by laat2 with SMTP id t2so91422832laa.1 for ; Mon, 11 May 2015 05:03:42 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=date:from:to:cc:subject:message-id:in-reply-to:references :mime-version:content-type:content-transfer-encoding; bh=ige6SQm60sIScdbtrVP5QKlvtL6d0C6EIyOy1SA9HXc=; b=ayONWzU4G7AALq7RuQ7scK3OeTpW6aAGgM9QaR6xwf0L1TYffLizO7uudKR+ZvUmTl oqoRJPHLQauJKLqHowy0uAojQaVx1F+tzqW7EZX1JEQZuMqjP8gA7LU8ZSH/tqJT21FS dDKIEfDA0aG8zRuY/emklCnEH2rcg451maHk2TJskJ8Vo9fvUuHAyapLDD2NuLEgh4Pl DC0MvtZlIdFKBKMje2Hb3Frhm10+t9KL9q6mjvVD7GCH3R93UNN0KnV/W/dPmyUKXxZc oF/6DVXb7VBjHzUuOgAmfAxmvUbNgb7ti79sCqNbApABZ9YmeoZbBYVW66LWNzMy/2zo trJg== X-Received: by 10.112.139.130 with SMTP id qy2mr7886326lbb.33.1431345822184; Mon, 11 May 2015 05:03:42 -0700 (PDT) Received: from opensuse.site (ppp91-76-14-38.pppoe.mtu-net.ru. [91.76.14.38]) by mx.google.com with ESMTPSA id xs12sm3007513lac.16.2015.05.11.05.03.40 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 11 May 2015 05:03:41 -0700 (PDT) Date: Mon, 11 May 2015 15:03:39 +0300 From: Andrei Borzenkov To: Olaf Hering Subject: Re: [PATCH] Parse commandline in grub-xen Message-ID: <20150511150339.3f303f6a@opensuse.site> In-Reply-To: <20150511115148.GA18883@aepfle.de> References: <1431336508-17290-1-git-send-email-olaf@aepfle.de> <20150511094320.GB17438@aepfle.de> <20150511104130.GA29233@aepfle.de> <20150511110143.GA3595@aepfle.de> <20150511115148.GA18883@aepfle.de> X-Mailer: Claws Mail 3.11.0 (GTK+ 2.24.27; x86_64-suse-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: Error: Malformed IPv6 address (bad octet value). X-Received-From: 2a00:1450:4010:c03::234 Cc: The development of GNU GRUB X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list Reply-To: The development of GNU GRUB List-Id: The development of GNU GRUB List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 11 May 2015 12:03:47 -0000 =D0=92 Mon, 11 May 2015 13:51:48 +0200 Olaf Hering =D0=BF=D0=B8=D1=88=D0=B5=D1=82: > On Mon, May 11, Vladimir 'phcoder' Serbinenko wrote: >=20 > >=20 > > On May 11, 2015 1:23 PM, "Olaf Hering" wrote: > > > > > > On Mon, May 11, Vladimir 'phcoder' Serbinenko wrote: > > > > > > > Do you really own all those installs to be able to speak on behalf = of all > > of > > > > them? > > > > > > Since there is zero upstream support for anything regarding grub xen > > > distros are forced to provide their own grub-xen binary for dom0. This > > > includes at least some script to do something useful within the very > > > first grub-xen. So in this sense its up to whoever creates such dom0 > > > binary to handle variables as needed, and document the implemented > > > features. > > > > > And your point is? >=20 > That this patch gets in as is? >=20 > How do you envison a way to select a boot device, or set debug=3Dall or > whatever a script may interpret? Either by allowing ${grub.arg.XXX} (not sure if current grammar accepts it) or by adding getarg command, something like getarg --name debug --set debug You do not control what arguments grub gets - end use (admin) controls it. You cannot force end user to actually strictly comply with what you expect. As example, grub.cfg you recently submitted has if [ -n "hddev" ] without initializing it first. So administrator setting this variable will unintentionally change behavior of script.