All of lore.kernel.org
 help / color / mirror / Atom feed
From: Greg KH <gregkh@linuxfoundation.org>
To: Christoffer Dall <christoffer.dall@linaro.org>
Cc: shannon.zhao@linaro.org, stable@vger.kernel.org,
	"Marc Zyngier" <marc.zyngier@arm.com>,
	"Alex Bennée" <alex.bennee@linaro.org>
Subject: Re: [PATCH for 3.14.y stable 47/47] arm/arm64: KVM: Keep elrsr/aisr in sync with software model
Date: Mon, 11 May 2015 11:47:21 -0700	[thread overview]
Message-ID: <20150511184721.GA26447@kroah.com> (raw)
In-Reply-To: <20150511184413.GA20917@cbox>

On Mon, May 11, 2015 at 08:44:13PM +0200, Christoffer Dall wrote:
> Hi Greg,
> 
> On Mon, May 11, 2015 at 08:17:07AM -0700, Greg KH wrote:
> > On Mon, May 04, 2015 at 09:52:42AM +0800, shannon.zhao@linaro.org wrote:
> > > From: Christoffer Dall <christoffer.dall@linaro.org>
> > > 
> > > commit ae705930fca6322600690df9dc1c7d0516145a93 upstream.
> > 
> > No, that's not what the patch below really is.
> > 
> > Do I have to go back by hand and verify each one of these really is the
> > patch you say it is?  That's a major pain...
> > 
> This is a backport of the referenced commit, but it couldn't be applied
> directly because of the churn in the vgic code.
> 
> I believed that the commit X upstream notation would indicate the
> equivalent fix upstream, not the *exact* commit for the relevant stable
> kernel.
> 
> Apologies if that was an incorrect assumption.  I believe this is the
> only patch which was significantly rewritten because of the churn in the
> vgic code and enough users are seeing this in various distro kernels
> that I figured it was important to refactor and backport.
> 
> What would you like me to do with this patch?

You need to document the heck out of the fact that this looks very
different from the git commit id that you are referencing here.  Not
saying anything makes me assume something went wrong.

thanks,

greg k-h

  reply	other threads:[~2015-05-11 18:47 UTC|newest]

Thread overview: 58+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-05-04  1:51 [PATCH for 3.14.y stable 00/47] Backport fixes of KVM/ARM to 3.14.y stable kernel shannon.zhao
2015-05-04  1:51 ` [PATCH for 3.14.y stable 01/47] arm64: KVM: force cache clean on page fault when caches are off shannon.zhao
2015-05-04  1:51 ` [PATCH for 3.14.y stable 02/47] arm64: KVM: allows discrimination of AArch32 sysreg access shannon.zhao
2015-05-04  1:51 ` [PATCH for 3.14.y stable 03/47] arm64: KVM: trap VM system registers until MMU and caches are ON shannon.zhao
2015-05-04  1:51 ` [PATCH for 3.14.y stable 04/47] ARM: KVM: introduce kvm_p*d_addr_end shannon.zhao
2015-05-04  1:52 ` [PATCH for 3.14.y stable 05/47] arm64: KVM: flush VM pages before letting the guest enable caches shannon.zhao
2015-05-04  1:52 ` [PATCH for 3.14.y stable 06/47] ARM: KVM: force cache clean on page fault when caches are off shannon.zhao
2015-05-04  1:52 ` [PATCH for 3.14.y stable 07/47] ARM: KVM: fix handling of trapped 64bit coprocessor accesses shannon.zhao
2015-05-04  1:52 ` [PATCH for 3.14.y stable 08/47] ARM: KVM: fix ordering of " shannon.zhao
2015-05-04  1:52 ` [PATCH for 3.14.y stable 09/47] ARM: KVM: introduce per-vcpu HYP Configuration Register shannon.zhao
2015-05-04  1:52 ` [PATCH for 3.14.y stable 10/47] ARM: KVM: add world-switch for AMAIR{0,1} shannon.zhao
2015-05-04  1:52 ` [PATCH for 3.14.y stable 11/47] ARM: KVM: trap VM system registers until MMU and caches are ON shannon.zhao
2015-05-04  1:52 ` [PATCH for 3.14.y stable 12/47] KVM: arm/arm64: vgic: fix GICD_ICFGR register accesses shannon.zhao
2015-05-04  1:52 ` [PATCH for 3.14.y stable 13/47] KVM: ARM: vgic: Fix the overlap check action about setting the GICD & GICC base address shannon.zhao
2015-05-04  1:52 ` [PATCH for 3.14.y stable 14/47] arm64: kvm: use inner-shareable barriers for inner-shareable maintenance shannon.zhao
2015-05-04  1:52 ` [PATCH for 3.14.y stable 15/47] kvm: arm64: vgic: fix hyp panic with 64k pages on juno platform shannon.zhao
2015-05-04  1:52 ` [PATCH for 3.14.y stable 16/47] arm/arm64: KVM: Fix and refactor unmap_range shannon.zhao
2015-05-04  1:52 ` [PATCH for 3.14.y stable 17/47] ARM: KVM: Unmap IPA on memslot delete/move shannon.zhao
2015-05-04  1:52 ` [PATCH for 3.14.y stable 18/47] ARM: KVM: user_mem_abort: support stage 2 MMIO page mapping shannon.zhao
2015-05-04  1:52 ` [PATCH for 3.14.y stable 19/47] arm64: KVM: export demux regids as KVM_REG_ARM64 shannon.zhao
2015-05-04  1:52 ` [PATCH for 3.14.y stable 20/47] ARM: virt: fix wrong HSCTLR.EE bit setting shannon.zhao
2015-05-04  1:52 ` [PATCH for 3.14.y stable 21/47] ARM64: KVM: store kvm_vcpu_fault_info est_el2 as word shannon.zhao
2015-05-04  1:52 ` [PATCH for 3.14.y stable 22/47] KVM: ARM/arm64: fix non-const declaration of function returning const shannon.zhao
2015-05-04  1:52 ` [PATCH for 3.14.y stable 23/47] KVM: ARM/arm64: fix broken __percpu annotation shannon.zhao
2015-05-04  1:52 ` [PATCH for 3.14.y stable 24/47] KVM: ARM/arm64: avoid returning negative error code as bool shannon.zhao
2015-05-04  1:52 ` [PATCH for 3.14.y stable 25/47] KVM: vgic: return int instead of bool when checking I/O ranges shannon.zhao
2015-05-04  1:52 ` [PATCH for 3.14.y stable 26/47] ARM/arm64: KVM: fix use of WnR bit in kvm_is_write_fault() shannon.zhao
2015-05-04  1:52 ` [PATCH for 3.14.y stable 27/47] KVM: ARM: vgic: plug irq injection race shannon.zhao
2015-05-04  1:52 ` [PATCH for 3.14.y stable 28/47] arm/arm64: KVM: Fix set_clear_sgi_pend_reg offset shannon.zhao
2015-05-04  1:52 ` [PATCH for 3.14.y stable 29/47] arm/arm64: KVM: Fix VTTBR_BADDR_MASK and pgd alloc shannon.zhao
2015-05-04  1:52 ` [PATCH for 3.14.y stable 30/47] arm: kvm: fix CPU hotplug shannon.zhao
2015-05-04  1:52 ` [PATCH for 3.14.y stable 31/47] arm/arm64: KVM: fix potential NULL dereference in user_mem_abort() shannon.zhao
2015-05-04  1:52 ` [PATCH for 3.14.y stable 32/47] arm/arm64: KVM: Ensure memslots are within KVM_PHYS_SIZE shannon.zhao
2015-05-04  1:52 ` [PATCH for 3.14.y stable 33/47] arm: kvm: STRICT_MM_TYPECHECKS fix for user_mem_abort shannon.zhao
2015-05-04  1:52 ` [PATCH for 3.14.y stable 34/47] arm64: KVM: fix unmapping with 48-bit VAs shannon.zhao
2015-05-04  1:52 ` [PATCH for 3.14.y stable 35/47] arm/arm64: KVM: vgic: Fix error code in kvm_vgic_create() shannon.zhao
2015-05-04  1:52 ` [PATCH for 3.14.y stable 36/47] arm64/kvm: Fix assembler compatibility of macros shannon.zhao
2015-05-04  1:52 ` [PATCH for 3.14.y stable 37/47] arm/arm64: kvm: drop inappropriate use of kvm_is_mmio_pfn() shannon.zhao
2015-05-04  1:52 ` [PATCH for 3.14.y stable 38/47] arm/arm64: KVM: Don't clear the VCPU_POWER_OFF flag shannon.zhao
2015-05-04  1:52 ` [PATCH for 3.14.y stable 39/47] arm/arm64: KVM: Correct KVM_ARM_VCPU_INIT power off option shannon.zhao
2015-05-04  1:52 ` [PATCH for 3.14.y stable 40/47] arm/arm64: KVM: Reset the HCR on each vcpu when resetting the vcpu shannon.zhao
2015-05-04  1:52 ` [PATCH for 3.14.y stable 41/47] arm/arm64: KVM: Introduce stage2_unmap_vm shannon.zhao
2015-05-04  1:52 ` [PATCH for 3.14.y stable 42/47] arm/arm64: KVM: Don't allow creating VCPUs after vgic_initialized shannon.zhao
2015-05-04  1:52 ` [PATCH for 3.14.y stable 43/47] arm/arm64: KVM: Require in-kernel vgic for the arch timers shannon.zhao
2015-05-04  1:52 ` [PATCH for 3.14.y stable 44/47] arm64: KVM: Fix TLB invalidation by IPA/VMID shannon.zhao
2015-05-04  1:52 ` [PATCH for 3.14.y stable 45/47] arm64: KVM: Fix HCR setting for 32bit guests shannon.zhao
2015-05-04  1:52 ` [PATCH for 3.14.y stable 46/47] arm64: KVM: Do not use pgd_index to index stage-2 pgd shannon.zhao
2015-05-04  1:52 ` [PATCH for 3.14.y stable 47/47] arm/arm64: KVM: Keep elrsr/aisr in sync with software model shannon.zhao
2015-05-11 15:17   ` Greg KH
2015-05-11 18:44     ` Christoffer Dall
2015-05-11 18:47       ` Greg KH [this message]
2015-05-11  9:39 ` [PATCH for 3.14.y stable 00/47] Backport fixes of KVM/ARM to 3.14.y stable kernel Shannon Zhao
2015-05-11 12:21   ` Greg KH
2015-05-11 15:03     ` Shannon Zhao
2015-05-11 15:20     ` Greg KH
2015-05-11 18:48       ` Christoffer Dall
2015-05-11 20:07         ` Greg KH
2015-05-11 20:17           ` Christoffer Dall

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20150511184721.GA26447@kroah.com \
    --to=gregkh@linuxfoundation.org \
    --cc=alex.bennee@linaro.org \
    --cc=christoffer.dall@linaro.org \
    --cc=marc.zyngier@arm.com \
    --cc=shannon.zhao@linaro.org \
    --cc=stable@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.