All of lore.kernel.org
 help / color / mirror / Atom feed
From: Arnaldo Carvalho de Melo <acme@kernel.org>
To: Jiri Olsa <jolsa@redhat.com>
Cc: Namhyung Kim <namhyung@gmail.com>, David Ahern <dsahern@gmail.com>
Subject: perf tools: Event naming inconsistency
Date: Mon, 11 May 2015 16:16:14 -0300	[thread overview]
Message-ID: <20150511191614.GB5456@kernel.org> (raw)

Hi Jiri,

	Noticed this while testing the PERF_RECORD_LOST_SAMPLES
patchkit:

[root@zoo ~]# perf record -e '{cycles,instructions}:p' usleep 1
[ perf record: Woken up 1 times to write data ]
[ perf record: Captured and wrote 0.017 MB perf.data (16 samples) ]
[root@zoo ~]# perf record -e '{cycles:p,instructions:p}' usleep 1
[ perf record: Woken up 1 times to write data ]
[ perf record: Captured and wrote 0.017 MB perf.data (16 samples) ]
[root@zoo ~]#

Thse should be equivalent, right?

If I do:

[root@zoo ~]# perf evlist -i perf.data.old
cycles
instructions
[root@zoo ~]# perf evlist -i perf.data
cycles:p
instructions:p
[root@zoo ~]#

But:

[root@zoo ~]# perf evlist -v -i perf.data.old
cycles: size: 112, { sample_period, sample_freq }: 4000, sample_type:
IP|TID|TIME|ID|PERIOD, read_format: ID, disabled: 1, inherit: 1, mmap:
1, comm: 1, freq: 1, enable_on_exec: 1, task: 1, precise_ip: 1,
sample_id_all: 1, exclude_guest: 1, mmap2: 1, comm_exec: 1
instructions: size: 112, config: 1, { sample_period, sample_freq }:
4000, sample_type: IP|TID|TIME|ID|PERIOD, read_format: ID, inherit: 1,
freq: 1, precise_ip: 1, sample_id_all: 1, exclude_guest: 1
[root@zoo ~]#

[root@zoo ~]# perf evlist -v -i perf.data
cycles:p: size: 112, { sample_period, sample_freq }: 4000, sample_type:
IP|TID|TIME|ID|PERIOD, read_format: ID, disabled: 1, inherit: 1, mmap:
1, comm: 1, freq: 1, enable_on_exec: 1, task: 1, precise_ip: 1,
sample_id_all: 1, exclude_guest: 1, mmap2: 1, comm_exec: 1
instructions:p: size: 112, config: 1, { sample_period, sample_freq }:
4000, sample_type: IP|TID|TIME|ID|PERIOD, read_format: ID, inherit: 1,
freq: 1, precise_ip: 1, sample_id_all: 1, exclude_guest: 1
[root@zoo ~]# 

Both are exactly the same, would be nice that tooling when showing both
cases showed the same event name, to avoid confusion... Anyway, not that
high prio ;-)

- Arnaldo

                 reply	other threads:[~2015-05-11 19:16 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20150511191614.GB5456@kernel.org \
    --to=acme@kernel.org \
    --cc=dsahern@gmail.com \
    --cc=jolsa@redhat.com \
    --cc=namhyung@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.