From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from list by lists.gnu.org with archive (Exim 4.71) id 1Yrqwo-0002FF-9X for mharc-grub-devel@gnu.org; Mon, 11 May 2015 12:52:54 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:41823) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Yrqwl-0002Bk-Nv for grub-devel@gnu.org; Mon, 11 May 2015 12:52:52 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Yrqwf-00081G-22 for grub-devel@gnu.org; Mon, 11 May 2015 12:52:51 -0400 Received: from mail-la0-x235.google.com ([2a00:1450:4010:c03::235]:35133) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Yrqwe-000812-RJ for grub-devel@gnu.org; Mon, 11 May 2015 12:52:45 -0400 Received: by labbd9 with SMTP id bd9so97755212lab.2 for ; Mon, 11 May 2015 09:52:44 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=date:from:to:cc:subject:message-id:in-reply-to:references :mime-version:content-type:content-transfer-encoding; bh=UFwWNTN5hUfzO8aciDqYIxV6XfmjIHzoM60orfSITMk=; b=LVP3R2jVCvwauiRGO32Kn7ex6pHlRa5qvauZv1m2nlTBoZBkqYUAmvJLrynsZw4ZN7 /Kvpus3uKwX16Gthak0t/oBvCWoiFCzaeMdoBqqxffXRzl2V+2ykKhtXb7vrykd/UYmK j2i2AlsaM803WCm1kFHBNHc5LXVl7w90lBxwAu9Oa07U90B77iOHs6Azhdt2wBcuEurj pgRXFHkx68yP3P+9QVHhb6HRKmwyWviT09wVpqUG/2GwyVbj1UC1bTWZv0c2j7P87bbo uzAURAfL9hjTsAO4BPrCi04dUAcCOhyE/ED3KnvrJcGzg/uGYzG0FF6Dq5QmZjdeTNF6 F7qg== X-Received: by 10.153.7.66 with SMTP id da2mr8680551lad.94.1431363163954; Mon, 11 May 2015 09:52:43 -0700 (PDT) Received: from opensuse.site (ppp91-76-14-38.pppoe.mtu-net.ru. [91.76.14.38]) by mx.google.com with ESMTPSA id ba4sm3156373lab.31.2015.05.11.09.52.42 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 11 May 2015 09:52:42 -0700 (PDT) Date: Mon, 11 May 2015 19:52:40 +0300 From: Andrei Borzenkov To: "Vladimir 'phcoder' Serbinenko" Subject: Re: [PATCH] Parse commandline in grub-xen Message-ID: <20150511195240.53084942@opensuse.site> In-Reply-To: References: <1431336508-17290-1-git-send-email-olaf@aepfle.de> <20150511094320.GB17438@aepfle.de> <20150511104130.GA29233@aepfle.de> <20150511110143.GA3595@aepfle.de> <20150511115148.GA18883@aepfle.de> <20150511150339.3f303f6a@opensuse.site> X-Mailer: Claws Mail 3.11.0 (GTK+ 2.24.27; x86_64-suse-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: Error: Malformed IPv6 address (bad octet value). X-Received-From: 2a00:1450:4010:c03::235 Cc: The development of GRUB 2 X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list Reply-To: The development of GNU GRUB List-Id: The development of GNU GRUB List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 11 May 2015 16:52:52 -0000 =D0=92 Mon, 11 May 2015 14:55:34 +0200 "Vladimir 'phcoder' Serbinenko" =D0=BF=D0=B8=D1=88=D0= =B5=D1=82: > On May 11, 2015 2:04 PM, "Andrei Borzenkov" wrote: > > > > =D0=92 Mon, 11 May 2015 13:51:48 +0200 > > Olaf Hering =D0=BF=D0=B8=D1=88=D0=B5=D1=82: > > > > > On Mon, May 11, Vladimir 'phcoder' Serbinenko wrote: > > > > > > > > > > > On May 11, 2015 1:23 PM, "Olaf Hering" wrote: > > > > > > > > > > On Mon, May 11, Vladimir 'phcoder' Serbinenko wrote: > > > > > > > > > > > Do you really own all those installs to be able to speak on > behalf of all > > > > of > > > > > > them? > > > > > > > > > > Since there is zero upstream support for anything regarding grub = xen > > > > > distros are forced to provide their own grub-xen binary for dom0. > This > > > > > includes at least some script to do something useful within the v= ery > > > > > first grub-xen. So in this sense its up to whoever creates such d= om0 > > > > > binary to handle variables as needed, and document the implemented > > > > > features. > > > > > > > > > And your point is? > > > > > > That this patch gets in as is? > > > > > > How do you envison a way to select a boot device, or set debug=3Dall = or > > > whatever a script may interpret? > > > > Either by allowing ${grub.arg.XXX} (not sure if current grammar accepts > > it) or by adding getarg command, something like > > > I prefer the former. But probably fwarg. Would be a better prefix. This w= ay > one can do: > extra=3D"grub.root=3Dxvda1" > And then get it as fwarg.grub.root whereas root for Linux would be > fwarg.root and thus avoiding any conflict Using it as variable name means change to parser with possible side effects; also it means it will go into core for every platform, even if platform itself does not support such variable passing, increasing its size. Having it as external command does not require any core changes, will be used only when needed and could be modeled after getopt e.g. allowing loop over arguments. > > getarg --name debug --set debug > > > > You do not control what arguments grub gets - end use (admin) controls > > it. You cannot force end user to actually strictly comply with what you > > expect. As example, grub.cfg you recently submitted has > > > > if [ -n "hddev" ] > > > > without initializing it first. So administrator setting this variable > > will unintentionally change behavior of script. > > > > _______________________________________________ > > Grub-devel mailing list > > Grub-devel@gnu.org > > https://lists.gnu.org/mailman/listinfo/grub-devel