Re: [meta-networking][PATCH] networkingmanager: QA warning for rdepends on polkit

[Martin Jansa <martin.jansa@gmail.com>]

On Mon, May 11, 2015 at 12:46:13PM -0700, Khem Raj wrote:
> On Mon, May 11, 2015 at 12:43 PM, Khem Raj <raj.khem@gmail.com> wrote:
> > On Mon, May 11, 2015 at 12:00 PM, Martin Jansa <martin.jansa@gmail.com> wrote:
> >>
> >> RDEPENDS adds dependency only between do_package tasks for build time
> >> dependency you need do_configure depending on do_populate_sysroot
> >
> > its do_build which will depend on do_package_write task in case of RDEPENDS
> > and do_package_write task will then recurse further to build it.
> 
> backtracking on warning
> 
> WARNING: QA Issue: networkmanager rdepends on polkit, but it isn't a
> build dependency? [build-deps]
> 
> its confusing to me. It says 'rdepends' but then expects it in
> build-dependency and not build-rdep or somesuch

It says "rdepends" because that dependency was added by shlib providers
code to RDEPENDS. But that means that some binary is linked against
library provided by polkit -> it's build time dependency autodetected in
do_configure -> needs polkit in DEPENDS.

> but lets say it depends on buildtime then I agree adding it to third
> place is needed and may be adding to 4th place too
> if shlib is not detecting it.

It needs it only in 3rd, because shlib code works correctly, otherwise you
wouldn't see this QA warning.

In other words the QA check warns about runtime dependencies being added
by shlibs code without having their providers in build time dependencies.

-- 
Martin 'JaMa' Jansa     jabber: Martin.Jansa@gmail.com