From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from list by lists.gnu.org with archive (Exim 4.71) id 1YrsiI-0001OY-Jd for mharc-grub-devel@gnu.org; Mon, 11 May 2015 14:46:02 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:39240) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YrsiG-0001OG-74 for grub-devel@gnu.org; Mon, 11 May 2015 14:46:01 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YrsiA-0002NL-6K for grub-devel@gnu.org; Mon, 11 May 2015 14:46:00 -0400 Received: from mail-lb0-x22b.google.com ([2a00:1450:4010:c04::22b]:33288) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Yrsi9-0002NF-Ub for grub-devel@gnu.org; Mon, 11 May 2015 14:45:54 -0400 Received: by lbbzk7 with SMTP id zk7so100652159lbb.0 for ; Mon, 11 May 2015 11:45:53 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=date:from:to:subject:message-id:in-reply-to:references:mime-version :content-type:content-transfer-encoding; bh=0FHqukT6bpMrGnlUaw3DCvVrDOCGfZy2rUyXOag14jU=; b=p4asC2qPRIrOyUB7yvPEycVOUkXTveMeYoN8H055lHGLAvZEKyhwYjIhXqz6Ifa7ZV D3DAok3iejLtcwLRuzn7YkbvWIHFvRkUI6Z1SWczIbfVf9apY7KtVX2KyfqyvOejlts6 iV9F8Sqk+v1M/BEKi8PL3CL56wepnhEtYyCKDo79E61GW18DFgoehorS36g0FmBWlUwY XvNUwhjSCzZ5ZsonwTcAKAVTwi5PfA/Q0PcShwmmAfOSbXFKN/RsgaikodIf3uR0q/MF NXZTYhOl9f4/+UL9NOczgi4mtAGlasMZgqdn4MfU2bObmkIM2K/PFOJeqZ3Lhd7A9HKy btFg== X-Received: by 10.112.63.201 with SMTP id i9mr8906787lbs.93.1431369953097; Mon, 11 May 2015 11:45:53 -0700 (PDT) Received: from opensuse.site (ppp91-76-14-38.pppoe.mtu-net.ru. [91.76.14.38]) by mx.google.com with ESMTPSA id r6sm3227884lbw.10.2015.05.11.11.45.51 for (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 11 May 2015 11:45:52 -0700 (PDT) Date: Mon, 11 May 2015 21:45:50 +0300 From: Andrei Borzenkov To: grub-devel@gnu.org Subject: Re: [PATCH] Parse commandline in grub-xen Message-ID: <20150511214550.559c9141@opensuse.site> In-Reply-To: References: <1431336508-17290-1-git-send-email-olaf@aepfle.de> <20150511094320.GB17438@aepfle.de> <20150511104130.GA29233@aepfle.de> <20150511110143.GA3595@aepfle.de> <20150511115148.GA18883@aepfle.de> <20150511150339.3f303f6a@opensuse.site> <20150511195240.53084942@opensuse.site> X-Mailer: Claws Mail 3.11.0 (GTK+ 2.24.27; x86_64-suse-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: Error: Malformed IPv6 address (bad octet value). X-Received-From: 2a00:1450:4010:c04::22b X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list Reply-To: The development of GNU GRUB List-Id: The development of GNU GRUB List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 11 May 2015 18:46:01 -0000 =D0=92 Mon, 11 May 2015 19:14:14 +0200 "Vladimir 'phcoder' Serbinenko" =D0=BF=D0=B8=D1=88=D0= =B5=D1=82: > On May 11, 2015 6:52 PM, "Andrei Borzenkov" wrote: > > > > =D0=92 Mon, 11 May 2015 14:55:34 +0200 > > "Vladimir 'phcoder' Serbinenko" =D0=BF=D0=B8=D1=88= =D0=B5=D1=82: > > > > > On May 11, 2015 2:04 PM, "Andrei Borzenkov" wro= te: > > > > > > > > =D0=92 Mon, 11 May 2015 13:51:48 +0200 > > > > Olaf Hering =D0=BF=D0=B8=D1=88=D0=B5=D1=82: > > > > > > > > > On Mon, May 11, Vladimir 'phcoder' Serbinenko wrote: > > > > > > > > > > > > > > > > > On May 11, 2015 1:23 PM, "Olaf Hering" wrote: > > > > > > > > > > > > > > On Mon, May 11, Vladimir 'phcoder' Serbinenko wrote: > > > > > > > > > > > > > > > Do you really own all those installs to be able to speak on > > > behalf of all > > > > > > of > > > > > > > > them? > > > > > > > > > > > > > > Since there is zero upstream support for anything regarding > grub xen > > > > > > > distros are forced to provide their own grub-xen binary for > dom0. > > > This > > > > > > > includes at least some script to do something useful within t= he > very > > > > > > > first grub-xen. So in this sense its up to whoever creates su= ch > dom0 > > > > > > > binary to handle variables as needed, and document the > implemented > > > > > > > features. > > > > > > > > > > > > > And your point is? > > > > > > > > > > That this patch gets in as is? > > > > > > > > > > How do you envison a way to select a boot device, or set debug=3D= all > or > > > > > whatever a script may interpret? > > > > > > > > Either by allowing ${grub.arg.XXX} (not sure if current grammar > accepts > > > > it) or by adding getarg command, something like > > > > > > > I prefer the former. But probably fwarg. Would be a better prefix. Th= is > way > > > one can do: > > > extra=3D"grub.root=3Dxvda1" > > > And then get it as fwarg.grub.root whereas root for Linux would be > > > fwarg.root and thus avoiding any conflict > > > > Using it as variable name means change to parser with possible side > > effects; also it means it will go into core for every platform, even if > > platform itself does not support such variable passing, increasing its > > size. > We can link it in only for the affected platforms and call from > grub-machine-init. Also we don't need the full parser Having different syntax for different platforms is really no-go. > >Having it as external command does not require any core changes, > > will be used only when needed and could be modeled after getopt e.g. > > allowing loop over arguments. > > > > > > getarg --name debug --set debug > > > >