From: Christoph Hellwig <hch@lst.de>
To: Brian Foster <bfoster@redhat.com>
Cc: Christoph Hellwig <hch@lst.de>, xfs@oss.sgi.com
Subject: Re: [PATCH 4/5] xfs: saner xfs_trans_commit interface
Date: Tue, 12 May 2015 08:36:32 +0200 [thread overview]
Message-ID: <20150512063632.GA25562@lst.de> (raw)
In-Reply-To: <20150511203237.GA59885@bfoster.bfoster>
On Mon, May 11, 2015 at 04:32:37PM -0400, Brian Foster wrote:
> > xfs_trans_unreserve_and_mod_dquots(tp);
> > if (tp->t_ticket) {
> > + int log_flags = 0;
> > +
> > + if (regrant) {
> > + ASSERT(tp->t_flags & XFS_TRANS_PERM_LOG_RES);
> > + log_flags = XFS_LOG_REL_PERM_RESERV;
> > + }
>
> Is the regrant logic here and in xfs_log_commit_cil() backwards or am I
> misreading?
Yes, it's actually wrong, but fixed up by the next patch.
I'll wait for more review feedback and will resend a fixed version.
p.s. can you please properly quote when replying? I had to trim over 600 lines
to get to your two line comment..
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
next prev parent reply other threads:[~2015-05-12 6:36 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-05-10 19:18 [PATCH 1/5] xfs: switch remaining xfs_trans_dup users to xfs_trans_roll Christoph Hellwig
2015-05-10 19:18 ` [PATCH 2/5] xfs: pass a boolean flag to xfs_trans_free_items Christoph Hellwig
2015-05-10 19:18 ` [PATCH 3/5] xfs: remove the flags argument to xfs_trans_cancel Christoph Hellwig
2015-05-10 19:18 ` [PATCH 4/5] xfs: saner xfs_trans_commit interface Christoph Hellwig
2015-05-11 20:32 ` Brian Foster
2015-05-12 6:36 ` Christoph Hellwig [this message]
2015-05-27 0:46 ` Dave Chinner
2015-05-10 19:18 ` [PATCH 5/5] xfs: fix xfs_log_done interface Christoph Hellwig
-- strict thread matches above, loose matches on Subject: below --
2015-06-03 12:49 simplify transaction commit and cancel interfaces V2 Christoph Hellwig
2015-06-03 12:49 ` [PATCH 4/5] xfs: saner xfs_trans_commit interface Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150512063632.GA25562@lst.de \
--to=hch@lst.de \
--cc=bfoster@redhat.com \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.