From: Arnaldo Carvalho de Melo <acme@kernel.org>
To: Peter Zijlstra <peterz@infradead.org>
Cc: "Liang, Kan" <kan.liang@intel.com>,
Ingo Molnar <mingo@kernel.org>,
Stephane Eranian <eranian@google.com>,
Andi Kleen <andi@firstfloor.org>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH V9 8/8] perf tools: handle PERF_RECORD_LOST_SAMPLES
Date: Tue, 12 May 2015 10:04:21 -0300 [thread overview]
Message-ID: <20150512130421.GB29215@kernel.org> (raw)
In-Reply-To: <20150512124344.GP21418@twins.programming.kicks-ass.net>
Em Tue, May 12, 2015 at 02:43:44PM +0200, Peter Zijlstra escreveu:
> On Mon, May 11, 2015 at 06:27:58PM -0300, Arnaldo Carvalho de Melo wrote:
> > I disagree, since the support is there, we need to have it in
> > hists->events_stats[PERF_RECORD_LOST_SAMPLES].
> > But that can be done in a follow up patch.
> Agreed, it would be good to know of which event the samples got lost.
> > It just came quickly to my attention because of all the discussion about
> > where to store something (PERF_SAMPLE_ID via sample_type + sample_id_all)
> > that doesn't get used in the patch that introduces it :-)
> >
> > I'll try to test this all tomorrow and will try to do the needed wiring
> > to hists_evsel->hists->events_stats.
> >
> > All working I can push this all via my perf/core event, if PeterZ
> > agrees and is ok with the kernel specific bits.
>
> I would like to carry these as there some conflicts with other patches I
> have.
So go ahead and do it, when it lands on tip I'll check and try to
continue what was discussed here, thanks!
- Arnaldo
next prev parent reply other threads:[~2015-05-12 13:04 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-05-10 19:13 [PATCH V9 0/8] large PEBS interrupt threshold Kan Liang
2015-05-10 19:13 ` [PATCH V9 1/8] perf, x86: use the PEBS auto reload mechanism when possible Kan Liang
2015-05-10 19:13 ` [PATCH V9 2/8] perf, x86: introduce setup_pebs_sample_data() Kan Liang
2015-05-10 19:13 ` [PATCH V9 3/8] perf, x86: handle multiple records in PEBS buffer Kan Liang
2015-05-12 13:25 ` [RFC][PATCH] perf, pebs: Add PEBS v3 record decoding Peter Zijlstra
2015-05-12 18:08 ` Andi Kleen
2015-05-13 1:31 ` Liang, Kan
2015-05-10 19:13 ` [PATCH V9 4/8] perf, x86: large PEBS interrupt threshold Kan Liang
2015-05-10 19:13 ` [PATCH V9 5/8] perf, x86: drain PEBS buffer during context switch Kan Liang
2015-05-10 19:13 ` [PATCH V9 6/8] perf, x86: enlarge PEBS buffer Kan Liang
2015-05-10 19:13 ` [PATCH V9 7/8] perf, x86: introduce PERF_RECORD_LOST_SAMPLES Kan Liang
2015-05-11 19:06 ` Arnaldo Carvalho de Melo
2015-06-07 17:50 ` [tip:perf/core] perf/x86/intel: Introduce PERF_RECORD_LOST_SAMPLES tip-bot for Kan Liang
2015-05-10 19:13 ` [PATCH V9 8/8] perf tools: handle PERF_RECORD_LOST_SAMPLES Kan Liang
2015-05-11 19:22 ` Arnaldo Carvalho de Melo
2015-05-11 20:40 ` Liang, Kan
2015-05-11 21:27 ` Arnaldo Carvalho de Melo
2015-05-12 12:43 ` Peter Zijlstra
2015-05-12 13:04 ` Arnaldo Carvalho de Melo [this message]
2015-06-07 17:51 ` [tip:perf/core] " tip-bot for Kan Liang
2015-05-11 16:06 ` [PATCH V9 0/8] large PEBS interrupt threshold Peter Zijlstra
2015-05-11 16:08 ` Liang, Kan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150512130421.GB29215@kernel.org \
--to=acme@kernel.org \
--cc=andi@firstfloor.org \
--cc=eranian@google.com \
--cc=kan.liang@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@kernel.org \
--cc=peterz@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.