From: Marek Vasut <marex@denx.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH v2 0/5] Introduce BIT and GENMASK
Date: Tue, 12 May 2015 13:33:39 +0200 [thread overview]
Message-ID: <201505121333.39390.marex@denx.de> (raw)
In-Reply-To: <CAD6G_RRbQX=1ZiqHt1pOC8wgXbBQGTJfq_vr3yLUnzX63EiBQQ@mail.gmail.com>
On Tuesday, May 12, 2015 at 01:25:30 PM, Jagan Teki wrote:
> On 10 May 2015 at 20:52, Jagan Teki <jteki@openedev.com> wrote:
> > I have sent one v1 for BIT macro change for entire u-boot,
> > but this time I'm just introduce by changing this with spi/sf
> > code, will send more in changes in future.
> >
> > Along with BIT and also introduces GENMASK with spi/sf code.
> >
> > Changes for v2:
> > - break the BIT macro patch only for spi/sf code.
> >
> > thanks!
> > Jagan.
> >
> > Jagan Teki (5):
> > spi/sf: Add BIT macro in linux/bitops.h
> > spi: Remove #define BIT in local file
> > spi/sf: Use BIT macro from linux/bitops.h
> > linux/bitops.h: GENMASK copy from linux
> > spi: Use GENMASK instead of numeric hexcodes
>
> Any comments on this series - early push will have enough time to test and
> I have more patches that need to use these macros.
I'm not very fond of this macro, it makes the code more cryptic .
Best regards,
Marek Vasut
next prev parent reply other threads:[~2015-05-12 11:33 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-05-10 15:22 [U-Boot] [PATCH v2 0/5] Introduce BIT and GENMASK Jagan Teki
2015-05-10 15:22 ` [U-Boot] [PATCH v2 1/5] spi/sf: Add BIT macro in linux/bitops.h Jagan Teki
2015-05-10 15:22 ` [U-Boot] [PATCH v2 2/5] spi: Remove #define BIT in local file Jagan Teki
2015-05-10 15:22 ` [U-Boot] [PATCH v2 3/5] spi/sf: Use BIT macro from linux/bitops.h Jagan Teki
2015-05-10 15:22 ` [U-Boot] [PATCH v2 4/5] linux/bitops.h: GENMASK copy from linux Jagan Teki
2015-05-10 15:22 ` [U-Boot] [PATCH v2 5/5] spi: Use GENMASK instead of numeric hexcodes Jagan Teki
2015-05-12 11:25 ` [U-Boot] [PATCH v2 0/5] Introduce BIT and GENMASK Jagan Teki
2015-05-12 11:33 ` Marek Vasut [this message]
2015-05-12 15:02 ` Tom Rini
2015-05-12 15:23 ` Marek Vasut
2015-05-13 1:48 ` Simon Glass
2015-05-15 19:19 ` Jagan Teki
2015-05-15 19:46 ` Wolfgang Denk
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201505121333.39390.marex@denx.de \
--to=marex@denx.de \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.