All of lore.kernel.org
 help / color / mirror / Atom feed
From: "George Spelvin" <linux@horizon.com>
To: linux@horizon.com, linux@rasmusvillemoes.dk
Cc: joe@perches.com, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/2 v2] lib/vsprintf.c: Further simplify uuid_string()
Date: 12 May 2015 09:57:36 -0400	[thread overview]
Message-ID: <20150512135736.7868.qmail@ns.horizon.com> (raw)
In-Reply-To: <87vbfy6nph.fsf@rasmusvillemoes.dk>

> Acked-by: Rasmus Villemoes <linux@rasmusvillemoes.dk>
> 
> You may want/need to include Andrew Morton in the cc-list to get these
> picked up.

Thank you; I sent it to you because I'm not sure who's really in charge
of this.

>> +	/* Insert the fixed punctuation */
>> +	uuid[23] = uuid[18] = uuid[13] = uuid[8] = '-';
>> +	uuid[36] = 0;

> I think '\0' is more common.

It's that way beause of it was replacing

>> -	*p = 0;

But yes, I prefer the char constant, too.  And it would be consistent with
the rest of the file.

  reply	other threads:[~2015-05-12 13:57 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-05-11 16:32 [RFC PATCH] lib/vsprintf.c: Simplify uuid_string() George Spelvin
2015-05-11 16:49 ` Joe Perches
2015-05-11 16:55   ` George Spelvin
2015-05-11 19:53 ` [PATCH 1/2] " George Spelvin
2015-05-11 19:55 ` [PATCH 2/2] lib/vsprintf.c: Further simplify uuid_string() George Spelvin
2015-05-12  2:14   ` Joe Perches
2015-05-12  9:10     ` [PATCH 2/2 v2] " George Spelvin
2015-05-12 11:26       ` Rasmus Villemoes
2015-05-12 13:57         ` George Spelvin [this message]
2015-05-12 16:59           ` Joe Perches

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20150512135736.7868.qmail@ns.horizon.com \
    --to=linux@horizon.com \
    --cc=joe@perches.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux@rasmusvillemoes.dk \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.