From mboxrd@z Thu Jan 1 00:00:00 1970 From: Dan Carpenter Date: Tue, 12 May 2015 18:07:37 +0000 Subject: [patch] drm/edid: fix a debug message Message-Id: <20150512180737.GA5672@mwanda> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Daniel Vetter , Todd Previte Cc: intel-gfx@lists.freedesktop.org, kernel-janitors@vger.kernel.org, dri-devel@lists.freedesktop.org There is an extra semi-colon on the if statement so the debug output always says "Failed to write EDID checksum" even when it didn't fail. Fixes: 559be30cb74d ('drm/i915: Implement the intel_dp_autotest_edid function for DP EDID complaince tests') Signed-off-by: Dan Carpenter diff --git a/drivers/gpu/drm/i915/intel_dp.c b/drivers/gpu/drm/i915/intel_dp.c index eca82cf..75bccd6 100644 --- a/drivers/gpu/drm/i915/intel_dp.c +++ b/drivers/gpu/drm/i915/intel_dp.c @@ -4142,7 +4142,7 @@ static uint8_t intel_dp_autotest_edid(struct intel_dp *intel_dp) if (!drm_dp_dpcd_write(&intel_dp->aux, DP_TEST_EDID_CHECKSUM, &intel_connector->detect_edid->checksum, - 1)); + 1)) DRM_DEBUG_KMS("Failed to write EDID checksum\n"); test_result = DP_TEST_ACK | DP_TEST_EDID_CHECKSUM_WRITE; From mboxrd@z Thu Jan 1 00:00:00 1970 From: Dan Carpenter Subject: [patch] drm/edid: fix a debug message Date: Tue, 12 May 2015 21:07:37 +0300 Message-ID: <20150512180737.GA5672@mwanda> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Content-Disposition: inline List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Daniel Vetter , Todd Previte Cc: intel-gfx@lists.freedesktop.org, kernel-janitors@vger.kernel.org, dri-devel@lists.freedesktop.org List-Id: dri-devel@lists.freedesktop.org VGhlcmUgaXMgYW4gZXh0cmEgc2VtaS1jb2xvbiBvbiB0aGUgaWYgc3RhdGVtZW50IHNvIHRoZSBk ZWJ1ZyBvdXRwdXQKYWx3YXlzIHNheXMgIkZhaWxlZCB0byB3cml0ZSBFRElEIGNoZWNrc3VtIiBl dmVuIHdoZW4gaXQgZGlkbid0IGZhaWwuCgpGaXhlczogNTU5YmUzMGNiNzRkICgnZHJtL2k5MTU6 IEltcGxlbWVudCB0aGUgaW50ZWxfZHBfYXV0b3Rlc3RfZWRpZCBmdW5jdGlvbiBmb3IgRFAgRURJ RCBjb21wbGFpbmNlIHRlc3RzJykKU2lnbmVkLW9mZi1ieTogRGFuIENhcnBlbnRlciA8ZGFuLmNh cnBlbnRlckBvcmFjbGUuY29tPgoKZGlmZiAtLWdpdCBhL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2lu dGVsX2RwLmMgYi9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9kcC5jCmluZGV4IGVjYTgyY2Yu Ljc1YmNjZDYgMTAwNjQ0Ci0tLSBhL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX2RwLmMKKysr IGIvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfZHAuYwpAQCAtNDE0Miw3ICs0MTQyLDcgQEAg c3RhdGljIHVpbnQ4X3QgaW50ZWxfZHBfYXV0b3Rlc3RfZWRpZChzdHJ1Y3QgaW50ZWxfZHAgKmlu dGVsX2RwKQogCQlpZiAoIWRybV9kcF9kcGNkX3dyaXRlKCZpbnRlbF9kcC0+YXV4LAogCQkJCQlE UF9URVNUX0VESURfQ0hFQ0tTVU0sCiAJCQkJCSZpbnRlbF9jb25uZWN0b3ItPmRldGVjdF9lZGlk LT5jaGVja3N1bSwKLQkJCQkJMSkpOworCQkJCQkxKSkKIAkJCURSTV9ERUJVR19LTVMoIkZhaWxl ZCB0byB3cml0ZSBFRElEIGNoZWNrc3VtXG4iKTsKIAogCQl0ZXN0X3Jlc3VsdCA9IERQX1RFU1Rf QUNLIHwgRFBfVEVTVF9FRElEX0NIRUNLU1VNX1dSSVRFOwpfX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fXwpkcmktZGV2ZWwgbWFpbGluZyBsaXN0CmRyaS1kZXZl bEBsaXN0cy5mcmVlZGVza3RvcC5vcmcKaHR0cDovL2xpc3RzLmZyZWVkZXNrdG9wLm9yZy9tYWls bWFuL2xpc3RpbmZvL2RyaS1kZXZlbAo=