From: Dan Carpenter <dan.carpenter-QHcLZuEGTsvQT0dZR+AlfA@public.gmane.org>
To: mcgrof-IBi9RG/b67k@public.gmane.org
Cc: linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Subject: re: IB/qib: use arch_phys_wc_add()
Date: Tue, 12 May 2015 21:09:05 +0300 [thread overview]
Message-ID: <20150512180905.GC5672@mwanda> (raw)
Hello Luis R. Rodriguez,
The patch d4988623cc60: "IB/qib: use arch_phys_wc_add()" from Apr 22,
2015, leads to the following static checker warning:
drivers/infiniband/hw/qib/qib_wc_x86_64.c:120 qib_enable_wc()
warn: unsigned 'dd->wc_cookie' is never less than zero.
drivers/infiniband/hw/qib/qib_wc_x86_64.c
117
118 if (!ret) {
119 dd->wc_cookie = arch_phys_wc_add(pioaddr, piolen);
120 if (dd->wc_cookie < 0)
^^^^^^^^^^^^^^^^^
arch_phys_wc_add() does return negatives on error but this is unsigned.
121 ret = -EINVAL;
122 }
123
124 return ret;
125 }
regards,
dan carpenter
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
reply other threads:[~2015-05-12 18:09 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150512180905.GC5672@mwanda \
--to=dan.carpenter-qhclzuegtsvqt0dzr+alfa@public.gmane.org \
--cc=linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=mcgrof-IBi9RG/b67k@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.