All of lore.kernel.org
 help / color / mirror / Atom feed
From: Tom Rini <trini@konsulko.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] serial: stm32: Automatically generate CR when LF is observed
Date: Tue, 12 May 2015 17:56:36 -0400	[thread overview]
Message-ID: <20150512215636.GD5729@bill-the-cat> (raw)
In-Reply-To: <CAOqy4DKhkN794DoeneX8zVDXfpMCqXhb5BD0ys3n+NGYK+bksw@mail.gmail.com>

On Tue, May 12, 2015 at 10:35:55PM +0200, Kamil Lulko wrote:

> Strange, this was already posted by Kunhua Huang - then reverted in
> commit 698a12bef9e782dcd99c555a739c16eec8669f14. Anyway, yes this
> carriage return should be added there. I simply forgot it since I had
> implicit CR for each LF turned on in my terminal. Never thought this
> would cause so much havoc for users ;)

I reverted it since the author said it wasn't needed with the other
patch they did being applied.  Daniel, can you confirm the odd behavior
exists with top of tree? Thanks!

-- 
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 836 bytes
Desc: Digital signature
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20150512/7d809f1d/attachment.sig>

  reply	other threads:[~2015-05-12 21:56 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-05-12 19:25 [U-Boot] [PATCH] serial: stm32: Automatically generate CR when LF is observed Daniel Thompson
2015-05-12 20:35 ` Kamil Lulko
2015-05-12 21:56   ` Tom Rini [this message]
2015-05-13  4:41     ` Kunhua Huang
2015-05-13 14:11     ` Daniel Thompson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20150512215636.GD5729@bill-the-cat \
    --to=trini@konsulko.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.